[INFO] fetching crate cargo-inspect 0.10.3... [INFO] checking cargo-inspect-0.10.3 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate cargo-inspect 0.10.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate cargo-inspect 0.10.3 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-inspect 0.10.3 [INFO] finished tweaking crates.io crate cargo-inspect 0.10.3 [INFO] tweaked toml for crates.io crate cargo-inspect 0.10.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-inspect 0.10.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ac679adf206fbb5b54a46aecefff6e62bec2466d093efade861e68f72a1a8e90 [INFO] running `Command { std: "docker" "start" "-a" "ac679adf206fbb5b54a46aecefff6e62bec2466d093efade861e68f72a1a8e90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ac679adf206fbb5b54a46aecefff6e62bec2466d093efade861e68f72a1a8e90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac679adf206fbb5b54a46aecefff6e62bec2466d093efade861e68f72a1a8e90", kill_on_drop: false }` [INFO] [stdout] ac679adf206fbb5b54a46aecefff6e62bec2466d093efade861e68f72a1a8e90 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9cbcc422cdf81be2d92ce25c65ebcb65a3d58764f5f8dd0d860aec1452ede3bc [INFO] running `Command { std: "docker" "start" "-a" "9cbcc422cdf81be2d92ce25c65ebcb65a3d58764f5f8dd0d860aec1452ede3bc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling syn v1.0.30 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling cc v1.0.54 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Compiling serde v1.0.111 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking gimli v0.21.0 [INFO] [stderr] Checking object v0.19.0 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Checking miniz_oxide v0.3.6 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling indexmap v1.4.0 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking line-wrap v0.1.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.2 [INFO] [stderr] Compiling proc-macro-error v1.0.2 [INFO] [stderr] Compiling error-chain v0.12.2 [INFO] [stderr] Compiling derive_builder v0.9.0 [INFO] [stderr] Checking linked-hash-map v0.5.3 [INFO] [stderr] Checking xml-rs v0.8.3 [INFO] [stderr] Checking base64 v0.12.1 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking termios v0.3.2 [INFO] [stderr] Compiling quote v1.0.6 [INFO] [stderr] Checking terminal_size v0.1.12 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Checking yaml-rust v0.4.4 [INFO] [stderr] Checking flate2 v1.0.14 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Compiling onig_sys v69.5.0 [INFO] [stderr] Compiling ansi_colours v1.0.1 [INFO] [stderr] Checking clicolors-control v1.0.1 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Checking directories v2.0.2 [INFO] [stderr] Checking content_inspector v0.2.4 [INFO] [stderr] Checking number_prefix v0.3.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking shell-words v0.1.0 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking addr2line v0.12.1 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking backtrace v0.3.48 [INFO] [stderr] Checking console v0.10.3 [INFO] [stderr] Checking console v0.11.3 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking indicatif v0.14.0 [INFO] [stderr] Checking bincode v1.2.1 [INFO] [stderr] Checking plist v1.0.0 [INFO] [stderr] Checking serde_json v1.0.53 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Compiling serde_derive v1.0.111 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking onig v6.0.0 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Compiling structopt-derive v0.4.7 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling derive_builder_core v0.9.0 [INFO] [stderr] Checking structopt v0.3.14 [INFO] [stderr] Checking syntect v4.2.0 [INFO] [stderr] Checking prettyprint v0.8.1 [INFO] [stderr] Checking cargo-inspect v0.10.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/hir.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | let mut p = process::Command::new("cargo") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | unused_qualifications [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 42 - let mut p = process::Command::new("cargo") [INFO] [stdout] 42 + let mut p = Command::new("cargo") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/hir.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | let mut p = process::Command::new("cargo") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | unused_qualifications [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 42 - let mut p = process::Command::new("cargo") [INFO] [stdout] 42 + let mut p = Command::new("cargo") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `source` is never read [INFO] [stdout] --> src/hir.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct HIR { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 10 | /// Source file or crate of HIR [INFO] [stdout] 11 | pub source: PathBuf, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/errors.rs:7:17 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_InspectError` [INFO] [stdout] 8 | /// Custom type for inspection errors [INFO] [stdout] 9 | pub enum InspectError { [INFO] [stdout] | ------------ `InspectError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/errors.rs:7:17 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_InspectError` [INFO] [stdout] 8 | /// Custom type for inspection errors [INFO] [stdout] 9 | pub enum InspectError { [INFO] [stdout] | ------------ `InspectError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `source` is never read [INFO] [stdout] --> src/hir.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct HIR { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 10 | /// Source file or crate of HIR [INFO] [stdout] 11 | pub source: PathBuf, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/errors.rs:7:17 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_InspectError` [INFO] [stdout] 8 | /// Custom type for inspection errors [INFO] [stdout] 9 | pub enum InspectError { [INFO] [stdout] | ------------ `InspectError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/errors.rs:7:17 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_InspectError` [INFO] [stdout] 8 | /// Custom type for inspection errors [INFO] [stdout] 9 | pub enum InspectError { [INFO] [stdout] | ------------ `InspectError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/bin/inspect/main.rs:44:22 [INFO] [stdout] | [INFO] [stdout] 44 | for cause in Fail::iter_causes(&err) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 44 | for cause in ::iter_causes(&err) { [INFO] [stdout] | ++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/bin/inspect/main.rs:44:22 [INFO] [stdout] | [INFO] [stdout] 44 | for cause in Fail::iter_causes(&err) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 44 | for cause in ::iter_causes(&err) { [INFO] [stdout] | ++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.55s [INFO] running `Command { std: "docker" "inspect" "9cbcc422cdf81be2d92ce25c65ebcb65a3d58764f5f8dd0d860aec1452ede3bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9cbcc422cdf81be2d92ce25c65ebcb65a3d58764f5f8dd0d860aec1452ede3bc", kill_on_drop: false }` [INFO] [stdout] 9cbcc422cdf81be2d92ce25c65ebcb65a3d58764f5f8dd0d860aec1452ede3bc