[INFO] fetching crate cardano-serialization-lib 12.1.0... [INFO] checking cardano-serialization-lib-12.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate cardano-serialization-lib 12.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate cardano-serialization-lib 12.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cardano-serialization-lib 12.1.0 [INFO] finished tweaking crates.io crate cardano-serialization-lib 12.1.0 [INFO] tweaked toml for crates.io crate cardano-serialization-lib 12.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 92 packages to latest compatible versions [INFO] [stderr] Adding autocfg v0.1.8 (available: v1.4.0) [INFO] [stderr] Adding bech32 v0.7.3 (available: v0.11.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding block-buffer v0.9.0 (available: v0.10.4) [INFO] [stderr] Adding cloudabi v0.0.3 (available: v0.1.0) [INFO] [stderr] Adding digest v0.9.0 (available: v0.10.7) [INFO] [stderr] Adding env_logger v0.7.1 (available: v0.11.5) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (available: v0.2.15) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding js-sys v0.3.69 (available: v0.3.70) [INFO] [stderr] Adding quickcheck v0.9.2 (available: v1.0.3) [INFO] [stderr] Adding quickcheck_macros v0.9.1 (available: v1.0.0) [INFO] [stderr] Adding rand v0.7.3 (available: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding rand_chacha v0.2.2 (available: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.5.1 (available: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (available: v0.3.2) [INFO] [stderr] Adding rand_os v0.1.3 (available: v0.2.2) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding serde-wasm-bindgen v0.4.5 (available: v0.6.5) [INFO] [stderr] Adding sha2 v0.9.9 (available: v0.10.8) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasm-bindgen v0.2.92 (available: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-backend v0.2.92 (available: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-macro v0.2.92 (available: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-macro-support v0.2.92 (available: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-shared v0.2.92 (available: v0.2.93) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ec6c452ef50f7cfbfcc223a93098a38f0cf85300421a0a1586ca55afa03c8c1a [INFO] running `Command { std: "docker" "start" "-a" "ec6c452ef50f7cfbfcc223a93098a38f0cf85300421a0a1586ca55afa03c8c1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ec6c452ef50f7cfbfcc223a93098a38f0cf85300421a0a1586ca55afa03c8c1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec6c452ef50f7cfbfcc223a93098a38f0cf85300421a0a1586ca55afa03c8c1a", kill_on_drop: false }` [INFO] [stdout] ec6c452ef50f7cfbfcc223a93098a38f0cf85300421a0a1586ca55afa03c8c1a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24fc5f253a498f64702000f6f3b7fde8d4df2005de6f1b0ed8fee6e65235e32b [INFO] running `Command { std: "docker" "start" "-a" "24fc5f253a498f64702000f6f3b7fde8d4df2005de6f1b0ed8fee6e65235e32b", kill_on_drop: false }` [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling schemars v0.8.21 [INFO] [stderr] Compiling clear_on_drop v0.2.5 [INFO] [stderr] Checking cryptoxide v0.4.4 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking cbor_event v2.4.0 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Checking bech32 v0.7.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Compiling schemars_derive v0.8.21 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking ed25519-bip32 v0.4.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking cardano-serialization-lib v12.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking quickcheck v0.9.2 [INFO] [stderr] Compiling quickcheck_macros v0.9.1 [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/legacy_address/crc32.rs:278:53 [INFO] [stdout] | [INFO] [stdout] 278 | pub fn update<'a, I>(&'a mut self, bytes: I) -> &mut Self [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/legacy_address/crc32.rs:278:53 [INFO] [stdout] | [INFO] [stdout] 278 | pub fn update<'a, I>(&'a mut self, bytes: I) -> &mut Self [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `protocol_types::plutus::plutus_data::ConstrPlutusData` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol_types/plutus/plutus_data.rs:222:39 [INFO] [stdout] | [INFO] [stdout] 220 | let mut list = PlutusList::new(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | list.add(plutus_data); [INFO] [stdout] 222 | Self::new_constr_plutus_data(&ConstrPlutusData::new(alternative, &list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `protocol_types::plutus::plutus_data::ConstrPlutusData` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol_types/plutus/plutus_data.rs:359:48 [INFO] [stdout] | [INFO] [stdout] 336 | let payment_data = PlutusData::from_stake_credential(&payment_cred)?; [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let staking_optional_data = match (staking_data, pointer_data) { [INFO] [stdout] | --------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | let mut data_list = PlutusList::new(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | Ok(PlutusData::new_constr_plutus_data(&ConstrPlutusData::new( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 360 | | &BigNum::from(0u32), [INFO] [stdout] 361 | | &data_list, [INFO] [stdout] 362 | | ))) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `protocol_types::plutus::plutus_data::ConstrPlutusData` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol_types/plutus/plutus_data.rs:391:48 [INFO] [stdout] | [INFO] [stdout] 384 | let mut data_list = PlutusList::new(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 391 | Ok(PlutusData::new_constr_plutus_data(&ConstrPlutusData::new( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 392 | | &BigNum::from(1u32), [INFO] [stdout] 393 | | &data_list, [INFO] [stdout] 394 | | ))) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `protocol_types::witnesses::vkeywitnesses::Vkeywitnesses` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/builders/tx_builder.rs:4217:9 [INFO] [stdout] | [INFO] [stdout] 4212 | let mut tx_builder = fake_reallistic_tx_builder(); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4216 | let tx: Transaction = fake_full_tx(&tx_builder, tx_builder.build().unwrap()).unwrap(); [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 4217 | tx.witness_set.vkeys.unwrap().len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `protocol_types::witnesses::vkeywitnesses::Vkeywitnesses` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/builders/tx_builder.rs:4473:9 [INFO] [stdout] | [INFO] [stdout] 4460 | let mut tx_builder = fake_reallistic_tx_builder(); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4472 | let tx: Transaction = fake_full_tx(&tx_builder, tx_builder.build().unwrap()).unwrap(); [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 4473 | tx.witness_set.vkeys.unwrap().len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cardano-serialization-lib` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `protocol_types::plutus::plutus_data::ConstrPlutusData` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol_types/plutus/plutus_data.rs:222:39 [INFO] [stdout] | [INFO] [stdout] 220 | let mut list = PlutusList::new(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | list.add(plutus_data); [INFO] [stdout] 222 | Self::new_constr_plutus_data(&ConstrPlutusData::new(alternative, &list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `protocol_types::plutus::plutus_data::ConstrPlutusData` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol_types/plutus/plutus_data.rs:359:48 [INFO] [stdout] | [INFO] [stdout] 336 | let payment_data = PlutusData::from_stake_credential(&payment_cred)?; [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let staking_optional_data = match (staking_data, pointer_data) { [INFO] [stdout] | --------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | let mut data_list = PlutusList::new(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | Ok(PlutusData::new_constr_plutus_data(&ConstrPlutusData::new( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 360 | | &BigNum::from(0u32), [INFO] [stdout] 361 | | &data_list, [INFO] [stdout] 362 | | ))) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `protocol_types::plutus::plutus_data::ConstrPlutusData` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol_types/plutus/plutus_data.rs:391:48 [INFO] [stdout] | [INFO] [stdout] 384 | let mut data_list = PlutusList::new(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 391 | Ok(PlutusData::new_constr_plutus_data(&ConstrPlutusData::new( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 392 | | &BigNum::from(1u32), [INFO] [stdout] 393 | | &data_list, [INFO] [stdout] 394 | | ))) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cardano-serialization-lib` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "24fc5f253a498f64702000f6f3b7fde8d4df2005de6f1b0ed8fee6e65235e32b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24fc5f253a498f64702000f6f3b7fde8d4df2005de6f1b0ed8fee6e65235e32b", kill_on_drop: false }` [INFO] [stdout] 24fc5f253a498f64702000f6f3b7fde8d4df2005de6f1b0ed8fee6e65235e32b