[INFO] fetching crate bwt 0.2.4... [INFO] checking bwt-0.2.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate bwt 0.2.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate bwt 0.2.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bwt 0.2.4 [INFO] finished tweaking crates.io crate bwt 0.2.4 [INFO] tweaked toml for crates.io crate bwt 0.2.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate bwt 0.2.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1670879a04bb68c34d09b5b9baf29b961479c9f3a2ce7a822cc87999886d5bac [INFO] running `Command { std: "docker" "start" "-a" "1670879a04bb68c34d09b5b9baf29b961479c9f3a2ce7a822cc87999886d5bac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1670879a04bb68c34d09b5b9baf29b961479c9f3a2ce7a822cc87999886d5bac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1670879a04bb68c34d09b5b9baf29b961479c9f3a2ce7a822cc87999886d5bac", kill_on_drop: false }` [INFO] [stdout] 1670879a04bb68c34d09b5b9baf29b961479c9f3a2ce7a822cc87999886d5bac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0e4a3a3a4ea0d6da47330bea2515c2cd1f245c2b1695a4e83d11a30122a66b57 [INFO] running `Command { std: "docker" "start" "-a" "0e4a3a3a4ea0d6da47330bea2515c2cd1f245c2b1695a4e83d11a30122a66b57", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.91 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.64 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling httparse v1.3.5 [INFO] [stderr] Checking tinyvec v1.1.1 [INFO] [stderr] Checking futures-core v0.3.13 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling cc v1.0.67 [INFO] [stderr] Checking futures-sink v0.3.13 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking http v0.2.3 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling tokio v1.4.0 [INFO] [stderr] Checking futures-task v0.3.13 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking futures-util v0.3.13 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking tracing-core v0.1.17 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking unicode-normalization v0.1.17 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Compiling unicase v1.4.2 [INFO] [stderr] Checking cpuid-bool v0.1.2 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking mio v0.7.11 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling mime_guess v2.0.3 [INFO] [stderr] Checking tracing v0.1.25 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking base64-compat v1.0.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking bech32 v0.7.3 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Compiling secp256k1-sys v0.4.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking idna v0.2.2 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking futures-channel v0.3.13 [INFO] [stderr] Checking input_buffer v0.4.0 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking utf-8 v0.7.5 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking language-tags v0.2.2 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking typeable v0.1.2 [INFO] [stderr] Checking regex-syntax v0.6.23 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking url v2.2.1 [INFO] [stderr] Checking http-body v0.4.1 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking socket2 v0.3.19 [INFO] [stderr] Checking buf_redux v0.8.4 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking futures-io v0.3.13 [INFO] [stderr] Compiling anyhow v1.0.39 [INFO] [stderr] Checking sha-1 v0.9.4 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking httpdate v0.3.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking hyper v0.10.16 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking tungstenite v0.12.0 [INFO] [stderr] Checking headers v0.3.4 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking dirs v3.0.1 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking signal-hook v0.1.17 [INFO] [stderr] Checking multipart v0.17.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking futures v0.3.13 [INFO] [stderr] Checking regex v1.4.5 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling tokio-macros v1.1.0 [INFO] [stderr] Compiling pin-project-internal v1.0.5 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking pin-project v1.0.5 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking tokio-util v0.6.5 [INFO] [stderr] Checking tokio-stream v0.1.5 [INFO] [stderr] Checking tokio-tungstenite v0.13.0 [INFO] [stderr] Checking h2 v0.3.1 [INFO] [stderr] Checking secp256k1 v0.20.1 [INFO] [stderr] Checking bitcoin_hashes v0.9.4 [INFO] [stderr] Checking serde_urlencoded v0.7.0 [INFO] [stderr] Checking jsonrpc v0.11.0 [INFO] [stderr] Checking hyper v0.14.4 [INFO] [stderr] Checking bitcoin v0.26.0 [INFO] [stderr] Checking warp v0.3.0 [INFO] [stderr] Checking bitcoincore-rpc-json v0.13.0 [INFO] [stderr] Checking miniscript v5.1.0 [INFO] [stderr] Checking bitcoincore-rpc v0.13.0 [INFO] [stderr] Checking bwt v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::collections::hash_map::Entry<'_, K, V>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/mod.rs:68:41 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn remove_if(hm: &mut HashMap, key: K, predicate: impl Fn(&mut V) -> bool) -> bool [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | if let Entry::Occupied(mut entry) = hm.entry(key) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::hash_map::Entry<'_, K, V>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/mod.rs:68:41 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn remove_if(hm: &mut HashMap, key: K, predicate: impl Fn(&mut V) -> bool) -> bool [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | if let Entry::Occupied(mut entry) = hm.entry(key) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/electrum/server.rs:465:27 [INFO] [stdout] | [INFO] [stdout] 454 | pub fn run(mut self, access_token: Arc>) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 465 | if let Err(err) = child.join().expect("receiver panicked") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/electrum/server.rs:634:31 [INFO] [stdout] | [INFO] [stdout] 633 | pub fn join(mut self) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 634 | if let Some(server) = self.server.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/electrum/server.rs:465:27 [INFO] [stdout] | [INFO] [stdout] 454 | pub fn run(mut self, access_token: Arc>) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 465 | if let Err(err) = child.join().expect("receiver panicked") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bwt` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/electrum/server.rs:634:31 [INFO] [stdout] | [INFO] [stdout] 633 | pub fn join(mut self) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 634 | if let Some(server) = self.server.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bwt` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "0e4a3a3a4ea0d6da47330bea2515c2cd1f245c2b1695a4e83d11a30122a66b57", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e4a3a3a4ea0d6da47330bea2515c2cd1f245c2b1695a4e83d11a30122a66b57", kill_on_drop: false }` [INFO] [stdout] 0e4a3a3a4ea0d6da47330bea2515c2cd1f245c2b1695a4e83d11a30122a66b57