[INFO] fetching crate buildstructor 0.5.4... [INFO] checking buildstructor-0.5.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate buildstructor 0.5.4 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate buildstructor 0.5.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate buildstructor 0.5.4 [INFO] finished tweaking crates.io crate buildstructor 0.5.4 [INFO] tweaked toml for crates.io crate buildstructor 0.5.4 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate buildstructor 0.5.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5d96d69a5dbd35f9813de576df8276f8d7719920aa2e247a78bb1f37e99121f2 [INFO] running `Command { std: "docker" "start" "-a" "5d96d69a5dbd35f9813de576df8276f8d7719920aa2e247a78bb1f37e99121f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5d96d69a5dbd35f9813de576df8276f8d7719920aa2e247a78bb1f37e99121f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d96d69a5dbd35f9813de576df8276f8d7719920aa2e247a78bb1f37e99121f2", kill_on_drop: false }` [INFO] [stdout] 5d96d69a5dbd35f9813de576df8276f8d7719920aa2e247a78bb1f37e99121f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9aa7113aba466706f87e2634e1a43d418be3790036ee7b9e50fc9d1be38f2279 [INFO] running `Command { std: "docker" "start" "-a" "9aa7113aba466706f87e2634e1a43d418be3790036ee7b9e50fc9d1be38f2279", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.5 [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling syn v1.0.103 [INFO] [stderr] Compiling thiserror v1.0.47 [INFO] [stderr] Checking itoa v1.0.4 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling trybuild v1.0.83 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling tokio v1.21.2 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking similar v2.2.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking once_cell v1.16.0 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Checking rust-format v0.3.4 [INFO] [stderr] Checking quote v1.0.33 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking syn v2.0.29 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking console v0.15.5 [INFO] [stderr] Checking insta v1.31.0 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking basic-toml v0.1.2 [INFO] [stderr] Checking multimap v0.9.0 [INFO] [stderr] Checking str_inflector v0.12.0 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling thiserror-impl v1.0.47 [INFO] [stderr] Compiling try_match_inner v0.5.1 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Checking try_match v0.4.1 [INFO] [stderr] Checking buildstructor v0.5.4 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buildstructor/codegen.rs:393:25 [INFO] [stdout] | [INFO] [stdout] 275 | let before = builder_generics [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | let after = builder_generics [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | let new_state = params(ir, idx, field_name, &builder_type_generics, set); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | let builder_type_generics = Generics::combine(vec![&builder_type_generics.without(idx), &builder_generics]); [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 393 | let mut field_key_type = f.generic_types.key_type.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 421 | Some(quote! { [INFO] [stdout] | ______________________________- [INFO] [stdout] 422 | | <#(#into_generics),*> [INFO] [stdout] 423 | | }) [INFO] [stdout] | |_________________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buildstructor/codegen.rs:393:25 [INFO] [stdout] | [INFO] [stdout] 275 | let before = builder_generics [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | let after = builder_generics [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | let new_state = params(ir, idx, field_name, &builder_type_generics, set); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | let builder_type_generics = Generics::combine(vec![&builder_type_generics.without(idx), &builder_generics]); [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 393 | let mut field_key_type = f.generic_types.key_type.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 421 | Some(quote! { [INFO] [stdout] | ______________________________- [INFO] [stdout] 422 | | <#(#into_generics),*> [INFO] [stdout] 423 | | }) [INFO] [stdout] | |_________________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:11 [INFO] [stdout] | [INFO] [stdout] 95 | item: TokenStream, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | ) -> TokenStream { [INFO] [stdout] 97 | match parse::parse(item.clone().into()).map_err(|e| e.into_compile_error()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 169 | let input: DeriveInput = parse2(item.into()).unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | let parameters: Vec = s [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 221 | / quote::quote! { [INFO] [stdout] 222 | | #[buildstructor::buildstructor] [INFO] [stdout] 223 | | impl #impl_generics #self_ty #ty_generics #where_clause { [INFO] [stdout] 224 | | #[doc=#constructor_doc] [INFO] [stdout] ... | [INFO] [stdout] 234 | | [INFO] [stdout] 235 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:11 [INFO] [stdout] | [INFO] [stdout] 95 | item: TokenStream, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | ) -> TokenStream { [INFO] [stdout] 97 | match parse::parse(item.clone().into()).map_err(|e| e.into_compile_error()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `doc` is never read [INFO] [stdout] --> src/buildstructor/lower.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub struct BuilderField { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 42 | pub doc: Vec, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `attributes` is never read [INFO] [stdout] --> src/buildstructor/parse.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Ast { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 7 | pub attributes: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Ast` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_bound` is never used [INFO] [stdout] --> src/buildstructor/utils.rs:67:8 [INFO] [stdout] | [INFO] [stdout] 60 | pub trait GenericsExt { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 67 | fn add_bound(self, ident: &Ident, ty: &Type) -> Self; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 169 | let input: DeriveInput = parse2(item.into()).unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | let parameters: Vec = s [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 221 | / quote::quote! { [INFO] [stdout] 222 | | #[buildstructor::buildstructor] [INFO] [stdout] 223 | | impl #impl_generics #self_ty #ty_generics #where_clause { [INFO] [stdout] 224 | | #[doc=#constructor_doc] [INFO] [stdout] ... | [INFO] [stdout] 234 | | [INFO] [stdout] 235 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `doc` is never read [INFO] [stdout] --> src/buildstructor/lower.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub struct BuilderField { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 42 | pub doc: Vec, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `attributes` is never read [INFO] [stdout] --> src/buildstructor/parse.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Ast { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 7 | pub attributes: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Ast` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_bound` is never used [INFO] [stdout] --> src/buildstructor/utils.rs:67:8 [INFO] [stdout] | [INFO] [stdout] 60 | pub trait GenericsExt { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 67 | fn add_bound(self, ident: &Ident, ty: &Type) -> Self; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `buildstructor` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `buildstructor` (lib) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9aa7113aba466706f87e2634e1a43d418be3790036ee7b9e50fc9d1be38f2279", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9aa7113aba466706f87e2634e1a43d418be3790036ee7b9e50fc9d1be38f2279", kill_on_drop: false }` [INFO] [stdout] 9aa7113aba466706f87e2634e1a43d418be3790036ee7b9e50fc9d1be38f2279