[INFO] fetching crate bsalib 0.1.0... [INFO] checking bsalib-0.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate bsalib 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate bsalib 0.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bsalib 0.1.0 [INFO] finished tweaking crates.io crate bsalib 0.1.0 [INFO] tweaked toml for crates.io crate bsalib 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 24 packages to latest compatible versions [INFO] [stderr] Adding generics v0.3.2 (available: v0.5.3) [INFO] [stderr] Adding libflate v1.4.0 (available: v2.1.0) [INFO] [stderr] Adding libflate_lz77 v1.2.0 (available: v2.1.0) [INFO] [stderr] Adding macro-attr-2018 v1.1.2 (available: v3.0.1) [INFO] [stderr] Adding newtype-derive-2018 v0.0.3 (available: v0.2.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bc87e5c6a60eda52c159b0ef9342f0a8743660e952692f4e708b7341a44534b0 [INFO] running `Command { std: "docker" "start" "-a" "bc87e5c6a60eda52c159b0ef9342f0a8743660e952692f4e708b7341a44534b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bc87e5c6a60eda52c159b0ef9342f0a8743660e952692f4e708b7341a44534b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc87e5c6a60eda52c159b0ef9342f0a8743660e952692f4e708b7341a44534b0", kill_on_drop: false }` [INFO] [stdout] bc87e5c6a60eda52c159b0ef9342f0a8743660e952692f4e708b7341a44534b0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a9d69114e9cba5c7eb480d9155bfd10d8f0791ac52af43f507fc85ecdd7c0338 [INFO] running `Command { std: "docker" "start" "-a" "a9d69114e9cba5c7eb480d9155bfd10d8f0791ac52af43f507fc85ecdd7c0338", kill_on_drop: false }` [INFO] [stderr] Checking rle-decode-fast v1.0.3 [INFO] [stderr] Checking generics v0.3.2 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking macro-attr-2018 v1.1.2 [INFO] [stderr] Compiling lz4-sys v1.11.1+lz4-1.10.0 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking newtype-derive-2018 v0.0.3 [INFO] [stderr] Checking libflate_lz77 v1.2.0 [INFO] [stderr] Checking libflate v1.4.0 [INFO] [stderr] Compiling enumflags2_derive v0.7.10 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Checking enumflags2 v0.7.10 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Checking lz4 v1.28.0 [INFO] [stderr] Checking bsalib v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `arbitrary_enum_discriminant` has been stable since 1.66.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:2:73 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(associated_type_defaults, wrapping_int_impl, specialization, arbitrary_enum_discriminant)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `arbitrary_enum_discriminant` has been stable since 1.66.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:2:73 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(associated_type_defaults, wrapping_int_impl, specialization, arbitrary_enum_discriminant)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/v10x.rs:530:25 [INFO] [stdout] | [INFO] [stdout] 530 | .map(|(dir, mut pdr)| { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/v10x.rs:586:24 [INFO] [stdout] | [INFO] [stdout] 586 | for (file, mut fr) in dir.files.iter().zip(&mut pfcr.data.files) { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/v10x.rs:530:25 [INFO] [stdout] | [INFO] [stdout] 530 | .map(|(dir, mut pdr)| { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/v10x.rs:586:24 [INFO] [stdout] | [INFO] [stdout] 586 | for (file, mut fr) in dir.files.iter().zip(&mut pfcr.data.files) { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/bin.rs:129:18 [INFO] [stdout] | [INFO] [stdout] 129 | for a in self { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 129 | while let Some(a) = self { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 129 | if let Some(a) = self { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/bin.rs:129:18 [INFO] [stdout] | [INFO] [stdout] 129 | for a in self { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 129 | while let Some(a) = self { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 129 | if let Some(a) = self { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.82s [INFO] running `Command { std: "docker" "inspect" "a9d69114e9cba5c7eb480d9155bfd10d8f0791ac52af43f507fc85ecdd7c0338", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9d69114e9cba5c7eb480d9155bfd10d8f0791ac52af43f507fc85ecdd7c0338", kill_on_drop: false }` [INFO] [stdout] a9d69114e9cba5c7eb480d9155bfd10d8f0791ac52af43f507fc85ecdd7c0338