[INFO] fetching crate browseraft 0.1.2... [INFO] checking browseraft-0.1.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate browseraft 0.1.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate browseraft 0.1.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate browseraft 0.1.2 [INFO] finished tweaking crates.io crate browseraft 0.1.2 [INFO] tweaked toml for crates.io crate browseraft 0.1.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 46 packages to latest compatible versions [INFO] [stderr] Adding autocfg v0.1.8 (available: v1.4.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding cloudabi v0.0.3 (available: v0.1.0) [INFO] [stderr] Adding gloo v0.2.1 (available: v0.11.0) [INFO] [stderr] Adding gloo-events v0.1.2 (available: v0.2.0) [INFO] [stderr] Adding gloo-file v0.1.0 (available: v0.3.0) [INFO] [stderr] Adding gloo-timers v0.2.6 (available: v0.3.0) [INFO] [stderr] Adding rand v0.6.5 (available: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (available: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (available: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (available: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (available: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (available: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (available: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9caa9f7cdeb1b1e8367697d68a1c093a38d985c515f58dd95df2eadf33f851c3 [INFO] running `Command { std: "docker" "start" "-a" "9caa9f7cdeb1b1e8367697d68a1c093a38d985c515f58dd95df2eadf33f851c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9caa9f7cdeb1b1e8367697d68a1c093a38d985c515f58dd95df2eadf33f851c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9caa9f7cdeb1b1e8367697d68a1c093a38d985c515f58dd95df2eadf33f851c3", kill_on_drop: false }` [INFO] [stdout] 9caa9f7cdeb1b1e8367697d68a1c093a38d985c515f58dd95df2eadf33f851c3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 86644f8bc42a25a681c254fa858cdcc9ba10a7f00c75ff0010b788f52aa657a4 [INFO] running `Command { std: "docker" "start" "-a" "86644f8bc42a25a681c254fa858cdcc9ba10a7f00c75ff0010b788f52aa657a4", kill_on_drop: false }` [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.93 [INFO] [stderr] Compiling bumpalo v3.16.0 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling wasm-bindgen v0.2.93 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.93 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.93 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.93 [INFO] [stderr] Checking js-sys v0.3.70 [INFO] [stderr] Checking web-sys v0.3.70 [INFO] [stderr] Checking gloo-timers v0.2.6 [INFO] [stderr] Checking gloo-events v0.1.2 [INFO] [stderr] Checking gloo-console-timer v0.1.0 [INFO] [stderr] Checking gloo-file v0.1.0 [INFO] [stderr] Checking gloo v0.2.1 [INFO] [stderr] Checking browseraft v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Role` [INFO] [stdout] --> src/rpc.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | raft::{Peer, Role}, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Role` [INFO] [stdout] --> src/rpc.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | raft::{Peer, Role}, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `wasm_bindgen::JsValue::from_serde`: causes dependency cycles, use `serde-wasm-bindgen` or `gloo_utils::format::JsValueSerdeExt` instead [INFO] [stdout] --> src/rpc.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 55 | JsValue::from_serde(&self).expect("failed to serialize") [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `wasm_bindgen::JsValue::into_serde`: causes dependency cycles, use `serde-wasm-bindgen` or `gloo_utils::format::JsValueSerdeExt` instead [INFO] [stdout] --> src/rpc.rs:59:18 [INFO] [stdout] | [INFO] [stdout] 59 | JsValue::into_serde(&value).expect("failed to deserialize") [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `wasm_bindgen::JsValue::from_serde`: causes dependency cycles, use `serde-wasm-bindgen` or `gloo_utils::format::JsValueSerdeExt` instead [INFO] [stdout] --> src/rpc.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 55 | JsValue::from_serde(&self).expect("failed to serialize") [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `wasm_bindgen::JsValue::into_serde`: causes dependency cycles, use `serde-wasm-bindgen` or `gloo_utils::format::JsValueSerdeExt` instead [INFO] [stdout] --> src/rpc.rs:59:18 [INFO] [stdout] | [INFO] [stdout] 59 | JsValue::into_serde(&value).expect("failed to deserialize") [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:246:33 [INFO] [stdout] | [INFO] [stdout] 245 | pub(crate) fn replace_election_task(&mut self, new_task: Option) { [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | if let Some(old_task) = if let Some(new_task) = new_task { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 247 | | self.election_task.replace(new_task) [INFO] [stdout] 248 | | } else { [INFO] [stdout] 249 | | self.election_task.take() [INFO] [stdout] 250 | | } { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:256:33 [INFO] [stdout] | [INFO] [stdout] 255 | pub(crate) fn replace_heartbeat_task(&mut self, new_task: Option) { [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | if let Some(old_task) = if let Some(new_task) = new_task { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 257 | | self.heartbeat_task.replace(new_task) [INFO] [stdout] 258 | | } else { [INFO] [stdout] 259 | | self.heartbeat_task.take() [INFO] [stdout] 260 | | } { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:246:33 [INFO] [stdout] | [INFO] [stdout] 245 | pub(crate) fn replace_election_task(&mut self, new_task: Option) { [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | if let Some(old_task) = if let Some(new_task) = new_task { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 247 | | self.election_task.replace(new_task) [INFO] [stdout] 248 | | } else { [INFO] [stdout] 249 | | self.election_task.take() [INFO] [stdout] 250 | | } { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:256:33 [INFO] [stdout] | [INFO] [stdout] 255 | pub(crate) fn replace_heartbeat_task(&mut self, new_task: Option) { [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | if let Some(old_task) = if let Some(new_task) = new_task { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 257 | | self.heartbeat_task.replace(new_task) [INFO] [stdout] 258 | | } else { [INFO] [stdout] 259 | | self.heartbeat_task.take() [INFO] [stdout] 260 | | } { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:81:30 [INFO] [stdout] | [INFO] [stdout] 79 | pub(crate) fn new_listener(self: Arc) -> EventListener { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let node = self.clone(); [INFO] [stdout] 81 | EventListener::new(&*self.channel.clone(), "message", move |event| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:81:30 [INFO] [stdout] | [INFO] [stdout] 79 | pub(crate) fn new_listener(self: Arc) -> EventListener { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let node = self.clone(); [INFO] [stdout] 81 | EventListener::new(&*self.channel.clone(), "message", move |event| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:271:33 [INFO] [stdout] | [INFO] [stdout] 266 | let mut state = self.state.lock().expect("poisoned!"); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | if let Some(listener) = state.channel_listener.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:271:33 [INFO] [stdout] | [INFO] [stdout] 266 | let mut state = self.state.lock().expect("poisoned!"); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | if let Some(listener) = state.channel_listener.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `browseraft` (lib) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `browseraft` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "86644f8bc42a25a681c254fa858cdcc9ba10a7f00c75ff0010b788f52aa657a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86644f8bc42a25a681c254fa858cdcc9ba10a7f00c75ff0010b788f52aa657a4", kill_on_drop: false }` [INFO] [stdout] 86644f8bc42a25a681c254fa858cdcc9ba10a7f00c75ff0010b788f52aa657a4