[INFO] fetching crate binstalk-manifests 0.15.3... [INFO] checking binstalk-manifests-0.15.3 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate binstalk-manifests 0.15.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate binstalk-manifests 0.15.3 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate binstalk-manifests 0.15.3 [INFO] finished tweaking crates.io crate binstalk-manifests 0.15.3 [INFO] tweaked toml for crates.io crate binstalk-manifests 0.15.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 89 packages to latest compatible versions [INFO] [stderr] Adding errno v0.2.8 (available: v0.3.9) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 68dc7c814052fe2bfac44f36871d8f937ed64dd576775e9dbc390eb711074909 [INFO] running `Command { std: "docker" "start" "-a" "68dc7c814052fe2bfac44f36871d8f937ed64dd576775e9dbc390eb711074909", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "68dc7c814052fe2bfac44f36871d8f937ed64dd576775e9dbc390eb711074909", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "68dc7c814052fe2bfac44f36871d8f937ed64dd576775e9dbc390eb711074909", kill_on_drop: false }` [INFO] [stdout] 68dc7c814052fe2bfac44f36871d8f937ed64dd576775e9dbc390eb711074909 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 734f0bf3c3271aa19bd3b617b590476d972e2042da2df240ba37b9f7b6d71ddd [INFO] running `Command { std: "docker" "start" "-a" "734f0bf3c3271aa19bd3b617b590476d972e2042da2df240ba37b9f7b6d71ddd", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling detect-targets v0.1.22 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking fs4 v0.9.1 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Checking guess_host_triple v0.1.4 [INFO] [stderr] Checking fs-lock v0.1.4 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking maybe-owned v0.3.4 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking serde-tuple-vec-map v1.0.1 [INFO] [stderr] Checking beef v0.5.2 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking toml_edit v0.22.22 [INFO] [stderr] Checking binstalk-types v0.9.0 [INFO] [stderr] Checking binstalk-manifests v0.15.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::iter::Map<::IntoIter, fn(T) -> binstall_crates_v1::Data {>::from}>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binstall_crates_v1.rs:50:30 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn append_to_path(path: impl AsRef, iter: Iter) -> Result<(), Error> [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let mut file = FileLock::new_exclusive(create_if_not_exist(path.as_ref())?)?; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | write_to(&mut file, &mut iter.into_iter().map(Data::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::iter::Map<::IntoIter, fn(T) -> binstall_crates_v1::Data {>::from}>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binstall_crates_v1.rs:50:30 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn append_to_path(path: impl AsRef, iter: Iter) -> Result<(), Error> [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let mut file = FileLock::new_exclusive(create_if_not_exist(path.as_ref())?)?; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | write_to(&mut file, &mut iter.into_iter().map(Data::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binstalk-manifests` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binstalk-manifests` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "734f0bf3c3271aa19bd3b617b590476d972e2042da2df240ba37b9f7b6d71ddd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "734f0bf3c3271aa19bd3b617b590476d972e2042da2df240ba37b9f7b6d71ddd", kill_on_drop: false }` [INFO] [stdout] 734f0bf3c3271aa19bd3b617b590476d972e2042da2df240ba37b9f7b6d71ddd