[INFO] fetching crate binstalk-git-repo-api 0.5.2... [INFO] checking binstalk-git-repo-api-0.5.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate binstalk-git-repo-api 0.5.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate binstalk-git-repo-api 0.5.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate binstalk-git-repo-api 0.5.2 [INFO] finished tweaking crates.io crate binstalk-git-repo-api 0.5.2 [INFO] tweaked toml for crates.io crate binstalk-git-repo-api 0.5.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 239 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (available: v0.10.0) [INFO] [stderr] Adding foreign-types v0.3.2 (available: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding h3 v0.0.5 (available: v0.0.6) [INFO] [stderr] Adding h3-quinn v0.0.6 (available: v0.0.7) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding hostname v0.3.1 (available: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding quick-error v1.2.3 (available: v2.0.1) [INFO] [stderr] Adding redox_syscall v0.3.5 (available: v0.5.6) [INFO] [stderr] Adding rustls-native-certs v0.7.3 (available: v0.8.0) [INFO] [stderr] Adding security-framework v2.11.1 (available: v3.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-registry v0.2.0 (available: v0.3.0) [INFO] [stderr] Adding windows-strings v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding windows-sys v0.48.0 (available: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding winreg v0.50.0 (available: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de9472e534155771456a6b69afbc989d778c593cec7674f995f5d9573584f830 [INFO] running `Command { std: "docker" "start" "-a" "de9472e534155771456a6b69afbc989d778c593cec7674f995f5d9573584f830", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de9472e534155771456a6b69afbc989d778c593cec7674f995f5d9573584f830", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de9472e534155771456a6b69afbc989d778c593cec7674f995f5d9573584f830", kill_on_drop: false }` [INFO] [stdout] de9472e534155771456a6b69afbc989d778c593cec7674f995f5d9573584f830 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d08ac143017c03bc0034cacb69fe9cc65c90cd3f328927494b958669d7e21eff [INFO] running `Command { std: "docker" "start" "-a" "d08ac143017c03bc0034cacb69fe9cc65c90cd3f328927494b958669d7e21eff", kill_on_drop: false }` [INFO] [stderr] Checking rustls-pki-types v1.9.0 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking deflate64 v0.1.9 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking maybe-owned v0.3.4 [INFO] [stderr] Checking serde-tuple-vec-map v1.0.1 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking webpki-roots v0.26.6 [INFO] [stderr] Checking rustix v0.38.37 [INFO] [stderr] Checking rustls-native-certs v0.8.0 [INFO] [stderr] Checking rustls-native-certs v0.7.3 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling cc v1.1.22 [INFO] [stderr] Checking binstalk-types v0.9.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tempfile v3.13.0 [INFO] [stderr] Checking tokio-tar v0.3.1 [INFO] [stderr] Checking binstall-tar v0.4.42 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Checking hyper-util v0.1.9 [INFO] [stderr] Compiling rustls v0.23.13 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking async_zip v0.0.17 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking hyper-rustls v0.27.3 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking binstalk-downloader v0.13.1 [INFO] [stderr] Checking binstalk-git-repo-api v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client/common.rs:124:30 [INFO] [stdout] | [INFO] [stdout] 120 | let mut response: GraphQLResponse = response.json().await?; [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | if let Some(error) = response.errors.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client/common.rs:124:30 [INFO] [stdout] | [INFO] [stdout] 120 | let mut response: GraphQLResponse = response.json().await?; [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | if let Some(error) = response.errors.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binstalk-git-repo-api` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `gh_api_client::GhRelease` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client.rs:478:17 [INFO] [stdout] | [INFO] [stdout] 472 | repo: GhRepo { owner, repo }, [INFO] [stdout] | ----- ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 473 | tag, [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 478 | release, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `binstalk_downloader::bytes::Bytes` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client.rs:674:33 [INFO] [stdout] | [INFO] [stdout] 647 | let artifact = GhReleaseArtifact { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 652 | let browser_download_task = client.get_auth_token().map(|_| { [INFO] [stdout] | --------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 674 | let artifact_download_data = loop { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binstalk-git-repo-api` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "d08ac143017c03bc0034cacb69fe9cc65c90cd3f328927494b958669d7e21eff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d08ac143017c03bc0034cacb69fe9cc65c90cd3f328927494b958669d7e21eff", kill_on_drop: false }` [INFO] [stdout] d08ac143017c03bc0034cacb69fe9cc65c90cd3f328927494b958669d7e21eff