[INFO] fetching crate binserde 0.1.7... [INFO] checking binserde-0.1.7 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate binserde 0.1.7 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate binserde 0.1.7 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate binserde 0.1.7 [INFO] finished tweaking crates.io crate binserde 0.1.7 [INFO] tweaked toml for crates.io crate binserde 0.1.7 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] [stderr] Adding darling v0.10.2 (available: v0.20.10) [INFO] [stderr] Adding darling_core v0.10.2 (available: v0.20.10) [INFO] [stderr] Adding darling_macro v0.10.2 (available: v0.20.10) [INFO] [stderr] Adding strsim v0.9.3 (available: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 990cd77a3a8bb413a9bd410416ab92be52a7ed5bd5c46d16aa5e282991a4842c [INFO] running `Command { std: "docker" "start" "-a" "990cd77a3a8bb413a9bd410416ab92be52a7ed5bd5c46d16aa5e282991a4842c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "990cd77a3a8bb413a9bd410416ab92be52a7ed5bd5c46d16aa5e282991a4842c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "990cd77a3a8bb413a9bd410416ab92be52a7ed5bd5c46d16aa5e282991a4842c", kill_on_drop: false }` [INFO] [stdout] 990cd77a3a8bb413a9bd410416ab92be52a7ed5bd5c46d16aa5e282991a4842c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 35d3d6fee61633affb0e3a8b2a9282ebc6f385b663b8813c1b7c3a6ba94eda41 [INFO] running `Command { std: "docker" "start" "-a" "35d3d6fee61633affb0e3a8b2a9282ebc6f385b663b8813c1b7c3a6ba94eda41", kill_on_drop: false }` [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling binserde_derive v0.1.4 [INFO] [stderr] Checking binserde v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Ref<'_, T>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serdeimpl.rs:434:9 [INFO] [stdout] | [INFO] [stdout] 433 | fn serialize(&self, serializer: S) -> Result<(), Error> { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 434 | / self.try_borrow() [INFO] [stdout] 435 | | .map_err(|e| Error::custom(e))? [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/util.rs:54:29 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn serialize_iter(mut iter: I, mut serializer: S) -> Result<()> [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `write_str` is never used [INFO] [stdout] --> src/write_ext.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub trait WriteExt { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] 10 | fn write_str(&mut self, s: &str) -> Result; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read_str` is never used [INFO] [stdout] --> src/write_ext.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 39 | pub trait ReadExt { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 40 | fn read_str(&mut self) -> Result; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, T>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serdeimpl.rs:434:9 [INFO] [stdout] | [INFO] [stdout] 433 | fn serialize(&self, serializer: S) -> Result<(), Error> { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 434 | / self.try_borrow() [INFO] [stdout] 435 | | .map_err(|e| Error::custom(e))? [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binserde` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/util.rs:54:29 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn serialize_iter(mut iter: I, mut serializer: S) -> Result<()> [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Test` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:356:17 [INFO] [stdout] | [INFO] [stdout] 314 | let s = Test { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | let s1: Test = deserialize(&buf).expect("failed to deserialize"); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `write_str` is never used [INFO] [stdout] --> src/write_ext.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub trait WriteExt { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] 10 | fn write_str(&mut self, s: &str) -> Result; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read_str` is never used [INFO] [stdout] --> src/write_ext.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 39 | pub trait ReadExt { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 40 | fn read_str(&mut self) -> Result; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binserde` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "35d3d6fee61633affb0e3a8b2a9282ebc6f385b663b8813c1b7c3a6ba94eda41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "35d3d6fee61633affb0e3a8b2a9282ebc6f385b663b8813c1b7c3a6ba94eda41", kill_on_drop: false }` [INFO] [stdout] 35d3d6fee61633affb0e3a8b2a9282ebc6f385b663b8813c1b7c3a6ba94eda41