[INFO] fetching crate binrw_derive 0.14.0... [INFO] checking binrw_derive-0.14.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate binrw_derive 0.14.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate binrw_derive 0.14.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate binrw_derive 0.14.0 [INFO] finished tweaking crates.io crate binrw_derive 0.14.0 [INFO] tweaked toml for crates.io crate binrw_derive 0.14.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] [stderr] Adding owo-colors v3.5.0 (available: v4.1.0) [INFO] [stderr] Adding runtime-macros-derive v0.4.0 (available: v0.6.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 87fbbae0d7df05b42fb9d13fa6d33713d44f31d9578a9c3099ac4e9f2d089ca7 [INFO] running `Command { std: "docker" "start" "-a" "87fbbae0d7df05b42fb9d13fa6d33713d44f31d9578a9c3099ac4e9f2d089ca7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "87fbbae0d7df05b42fb9d13fa6d33713d44f31d9578a9c3099ac4e9f2d089ca7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87fbbae0d7df05b42fb9d13fa6d33713d44f31d9578a9c3099ac4e9f2d089ca7", kill_on_drop: false }` [INFO] [stdout] 87fbbae0d7df05b42fb9d13fa6d33713d44f31d9578a9c3099ac4e9f2d089ca7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 976deb39a38f16b845b6bc3eb87ff1e3ceb4c1226d3912d08a90f904558491c3 [INFO] running `Command { std: "docker" "start" "-a" "976deb39a38f16b845b6bc3eb87ff1e3ceb4c1226d3912d08a90f904558491c3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling binrw_derive v0.14.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking runtime-macros-derive v0.4.0 [INFO] [stdout] error: this value of type `TokenStream2` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binrw/codegen/mod.rs:293:17 [INFO] [stdout] | [INFO] [stdout] 293 | let extra_args = directives_to_args(field, stream); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 294 | / quote_spanned_any! { span=> [INFO] [stdout] 295 | | #ARGS_MACRO! { #extra_args #(#fields, )* } [INFO] [stdout] 296 | | } [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | }), [INFO] [stdout] 298 | PassedArgs::List(list) => Some(quote_spanned! {span=> (#(#list,)*) }), [INFO] [stdout] | ------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/util.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | let mut _inner_ts = proc_macro2::TokenStream::new(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let mut _ts = proc_macro2::TokenStream::new(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `top_level_attrs::Struct` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binrw/parser/field_level_attrs.rs:289:15 [INFO] [stdout] | [INFO] [stdout] 285 | fn from(value: UnitEnumField) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | ..<_>::default() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `PartialResult` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fn_helper/mod.rs:21:11 [INFO] [stdout] | [INFO] [stdout] 19 | input: TokenStream, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | ) -> TokenStream { [INFO] [stdout] 21 | match generate::( [INFO] [stdout] | ___________^ [INFO] [stdout] 22 | | parse_macro_input!(attr as Options), [INFO] [stdout] | | ------------------------------------------ [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | | parse_macro_input!(input as ItemFn), [INFO] [stdout] | | ----------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `TokenStream2` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binrw/codegen/mod.rs:293:17 [INFO] [stdout] | [INFO] [stdout] 293 | let extra_args = directives_to_args(field, stream); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 294 | / quote_spanned_any! { span=> [INFO] [stdout] 295 | | #ARGS_MACRO! { #extra_args #(#fields, )* } [INFO] [stdout] 296 | | } [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | }), [INFO] [stdout] 298 | PassedArgs::List(list) => Some(quote_spanned! {span=> (#(#list,)*) }), [INFO] [stdout] | ------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/util.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | let mut _inner_ts = proc_macro2::TokenStream::new(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let mut _ts = proc_macro2::TokenStream::new(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `top_level_attrs::Struct` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binrw/parser/field_level_attrs.rs:289:15 [INFO] [stdout] | [INFO] [stdout] 285 | fn from(value: UnitEnumField) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | ..<_>::default() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `E` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/result.rs:57:32 [INFO] [stdout] | [INFO] [stdout] 53 | pub(crate) fn unwrap_tuple(self) -> (T, Option) { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | PartialResult::Err(error) => panic!( [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binrw_derive` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `result::PartialResult` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fn_helper/mod.rs:21:11 [INFO] [stdout] | [INFO] [stdout] 19 | input: TokenStream, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | ) -> TokenStream { [INFO] [stdout] 21 | match generate::( [INFO] [stdout] | ___________^ [INFO] [stdout] 22 | | parse_macro_input!(attr as Options), [INFO] [stdout] | | ------------------------------------------ [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | | parse_macro_input!(input as ItemFn), [INFO] [stdout] | | ----------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `E` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/result.rs:42:39 [INFO] [stdout] | [INFO] [stdout] 39 | pub(crate) fn unwrap(self) -> T { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | PartialResult::Partial(_, error) => panic!( [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `E` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/result.rs:57:32 [INFO] [stdout] | [INFO] [stdout] 53 | pub(crate) fn unwrap_tuple(self) -> (T, Option) { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | PartialResult::Err(error) => panic!( [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binrw_derive` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "976deb39a38f16b845b6bc3eb87ff1e3ceb4c1226d3912d08a90f904558491c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "976deb39a38f16b845b6bc3eb87ff1e3ceb4c1226d3912d08a90f904558491c3", kill_on_drop: false }` [INFO] [stdout] 976deb39a38f16b845b6bc3eb87ff1e3ceb4c1226d3912d08a90f904558491c3