[INFO] fetching crate bgzf_rust_reader 0.2.1... [INFO] checking bgzf_rust_reader-0.2.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate bgzf_rust_reader 0.2.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate bgzf_rust_reader 0.2.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bgzf_rust_reader 0.2.1 [INFO] finished tweaking crates.io crate bgzf_rust_reader 0.2.1 [INFO] tweaked toml for crates.io crate bgzf_rust_reader 0.2.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] [stderr] Adding byteorder v0.5.3 (available: v1.5.0) [INFO] [stderr] Adding libdeflate-sys v0.7.5 (available: v1.21.0) [INFO] [stderr] Adding libdeflater v0.7.5 (available: v1.21.0) [INFO] [stderr] Adding positioned-io v0.2.2 (available: v0.3.3) [INFO] [stderr] Adding winapi v0.2.8 (available: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2536c916abe3c8ac0c48bea0dc6f3364eca17385a1729fe4341590fdd8a307a8 [INFO] running `Command { std: "docker" "start" "-a" "2536c916abe3c8ac0c48bea0dc6f3364eca17385a1729fe4341590fdd8a307a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2536c916abe3c8ac0c48bea0dc6f3364eca17385a1729fe4341590fdd8a307a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2536c916abe3c8ac0c48bea0dc6f3364eca17385a1729fe4341590fdd8a307a8", kill_on_drop: false }` [INFO] [stdout] 2536c916abe3c8ac0c48bea0dc6f3364eca17385a1729fe4341590fdd8a307a8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3d5e9a09b22f1e71a28160f8ed44661a413af919185a78cde0475671c0f4fa75 [INFO] running `Command { std: "docker" "start" "-a" "3d5e9a09b22f1e71a28160f8ed44661a413af919185a78cde0475671c0f4fa75", kill_on_drop: false }` [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking byteorder v0.5.3 [INFO] [stderr] Checking positioned-io v0.2.2 [INFO] [stderr] Compiling cc v1.1.22 [INFO] [stderr] Compiling libdeflate-sys v0.7.5 [INFO] [stderr] Checking libdeflater v0.7.5 [INFO] [stderr] Checking bgzf_rust_reader v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:379:11 [INFO] [stdout] | [INFO] [stdout] 378 | let bgzf_file = File::open("bgzf_test.bgz").unwrap(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 379 | match read_block(&bgzf_file, 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `BgzfReader` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:397:10 [INFO] [stdout] | [INFO] [stdout] 395 | let bgzf_reader = BgzfReader::new(String::from("bgzf_test.bgz")); [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 396 | match bgzf_reader { [INFO] [stdout] 397 | Ok(reader) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/lib.rs:426:11 [INFO] [stdout] | [INFO] [stdout] 426 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bgzf_rust_reader` (lib test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> tests/integration_test.rs:22:3 [INFO] [stdout] | [INFO] [stdout] 22 | reader.read_to(&mut test_buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 22 | let _ = reader.read_to(&mut test_buffer); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "3d5e9a09b22f1e71a28160f8ed44661a413af919185a78cde0475671c0f4fa75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d5e9a09b22f1e71a28160f8ed44661a413af919185a78cde0475671c0f4fa75", kill_on_drop: false }` [INFO] [stdout] 3d5e9a09b22f1e71a28160f8ed44661a413af919185a78cde0475671c0f4fa75