[INFO] fetching crate bex 0.2.0... [INFO] checking bex-0.2.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate bex 0.2.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate bex 0.2.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bex 0.2.0 [INFO] finished tweaking crates.io crate bex 0.2.0 [INFO] tweaked toml for crates.io crate bex 0.2.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate bex 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 494b0563bcca7d66c80dafaf1bbbaa889b850c686a608e1ae1bef3cf00a7ff2a [INFO] running `Command { std: "docker" "start" "-a" "494b0563bcca7d66c80dafaf1bbbaa889b850c686a608e1ae1bef3cf00a7ff2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "494b0563bcca7d66c80dafaf1bbbaa889b850c686a608e1ae1bef3cf00a7ff2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "494b0563bcca7d66c80dafaf1bbbaa889b850c686a608e1ae1bef3cf00a7ff2a", kill_on_drop: false }` [INFO] [stdout] 494b0563bcca7d66c80dafaf1bbbaa889b850c686a608e1ae1bef3cf00a7ff2a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e89feb3c52da6ffaba0929adb9d55a366ee8334e7bb9a326cf1ec78deb3a141b [INFO] running `Command { std: "docker" "start" "-a" "e89feb3c52da6ffaba0929adb9d55a366ee8334e7bb9a326cf1ec78deb3a141b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.140 [INFO] [stderr] Compiling parking_lot_core v0.9.7 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling crossbeam-utils v0.8.15 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Checking iana-time-zone v0.1.54 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Checking once_cell v1.17.1 [INFO] [stderr] Compiling bex v0.2.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking boxcar v0.1.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking bencher v0.1.5 [INFO] [stderr] Checking concurrent-queue v2.1.0 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking dashmap v5.4.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking chrono v0.4.24 [INFO] [stderr] Checking simplelog v0.5.3 [INFO] [stdout] warning: unexpected `cfg` condition name: `todo` [INFO] [stdout] --> src/base.rs:213:7 [INFO] [stdout] | [INFO] [stdout] 213 | #[cfg(todo)] pub fn order(x:T, y:T)->(T,T) { if x < y { (x,y) } else { (y,x) }} [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `fmt_debug`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(todo)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(todo)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `todo` [INFO] [stdout] --> src/base.rs:214:7 [INFO] [stdout] | [INFO] [stdout] 214 | #[cfg(todo)] pub fn order3(x:T, y:T, z:T)->(T,T,T) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(todo)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(todo)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `todo` [INFO] [stdout] --> src/base.rs:213:7 [INFO] [stdout] | [INFO] [stdout] 213 | #[cfg(todo)] pub fn order(x:T, y:T)->(T,T) { if x < y { (x,y) } else { (y,x) }} [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `fmt_debug`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(todo)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(todo)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `todo` [INFO] [stdout] --> src/base.rs:214:7 [INFO] [stdout] | [INFO] [stdout] 214 | #[cfg(todo)] pub fn order3(x:T, y:T, z:T)->(T,T,T) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(todo)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(todo)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bdd/bdd_swarm.rs:125:15 [INFO] [stdout] | [INFO] [stdout] 116 | fn work_step(&mut self, qid:&QID, q:Q)->Option { [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | { let mut m = s.work.qid.lock().unwrap(); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/swap.rs:304:19 [INFO] [stdout] | [INFO] [stdout] 304 | if let Some(mut ixrc) = row.hm.get_mut(&vhl.hilo()) { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bdd/bdd_swarm.rs:125:15 [INFO] [stdout] | [INFO] [stdout] 116 | fn work_step(&mut self, qid:&QID, q:Q)->Option { [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | { let mut m = s.work.qid.lock().unwrap(); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bex` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/swap.rs:304:19 [INFO] [stdout] | [INFO] [stdout] 304 | if let Some(mut ixrc) = row.hm.get_mut(&vhl.hilo()) { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bex` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e89feb3c52da6ffaba0929adb9d55a366ee8334e7bb9a326cf1ec78deb3a141b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e89feb3c52da6ffaba0929adb9d55a366ee8334e7bb9a326cf1ec78deb3a141b", kill_on_drop: false }` [INFO] [stdout] e89feb3c52da6ffaba0929adb9d55a366ee8334e7bb9a326cf1ec78deb3a141b