[INFO] fetching crate aws_secretsmanager_caching 1.0.0... [INFO] checking aws_secretsmanager_caching-1.0.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate aws_secretsmanager_caching 1.0.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate aws_secretsmanager_caching 1.0.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate aws_secretsmanager_caching 1.0.0 [INFO] finished tweaking crates.io crate aws_secretsmanager_caching 1.0.0 [INFO] tweaked toml for crates.io crate aws_secretsmanager_caching 1.0.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 220 packages to latest compatible versions [INFO] [stderr] Adding assert-json-diff v1.1.0 (available: v2.0.2) [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding core-foundation v0.9.4 (available: v0.10.0) [INFO] [stderr] Adding extend v0.1.2 (available: v1.2.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding h2 v0.3.26 (available: v0.4.6) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (available: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (available: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (available: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.24.2 (available: v0.27.3) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding matchers v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding regex-automata v0.1.10 (available: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding roxmltree v0.14.1 (available: v0.20.0) [INFO] [stderr] Adding rustls v0.21.12 (available: v0.23.13) [INFO] [stderr] Adding rustls-native-certs v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (available: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (available: v0.102.8) [INFO] [stderr] Adding security-framework v2.11.1 (available: v3.0.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding tokio-rustls v0.24.1 (available: v0.26.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1a61885a9375cd6e432ce69afb5001d7be95c67ce76a1324704a379afb9a8bda [INFO] running `Command { std: "docker" "start" "-a" "1a61885a9375cd6e432ce69afb5001d7be95c67ce76a1324704a379afb9a8bda", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1a61885a9375cd6e432ce69afb5001d7be95c67ce76a1324704a379afb9a8bda", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a61885a9375cd6e432ce69afb5001d7be95c67ce76a1324704a379afb9a8bda", kill_on_drop: false }` [INFO] [stdout] 1a61885a9375cd6e432ce69afb5001d7be95c67ce76a1324704a379afb9a8bda [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0d466990074d37599127f2a3adeaabe3f37251d079f2a143b505321e9f5ada40 [INFO] running `Command { std: "docker" "start" "-a" "0d466990074d37599127f2a3adeaabe3f37251d079f2a143b505321e9f5ada40", kill_on_drop: false }` [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking rustls v0.21.12 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking separator v0.4.1 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking bs58 v0.5.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking roxmltree v0.14.1 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking pretty_assertions v1.4.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking cbor-diag v0.1.12 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling serde_with_macros v3.9.0 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking aws-smithy-async v1.2.1 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking aws-smithy-types v1.2.7 [INFO] [stderr] Compiling extend v0.1.2 [INFO] [stderr] Checking aws-smithy-runtime-api v1.7.2 [INFO] [stderr] Checking aws-smithy-json v0.60.7 [INFO] [stderr] Checking aws-smithy-query v0.60.7 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking serde_with v3.9.0 [INFO] [stderr] Checking aws-credential-types v1.2.1 [INFO] [stderr] Checking aws-smithy-http v0.60.11 [INFO] [stderr] Checking aws-smithy-mocks-experimental v0.2.1 [INFO] [stderr] Checking aws-types v1.3.3 [INFO] [stderr] Checking aws-sigv4 v1.2.4 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking assert-json-diff v1.1.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking aws-smithy-protocol-test v0.62.0 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking aws-smithy-runtime v1.7.1 [INFO] [stderr] Checking aws-runtime v1.4.3 [INFO] [stderr] Checking aws-sdk-ssooidc v1.45.0 [INFO] [stderr] Checking aws-sdk-sso v1.44.0 [INFO] [stderr] Checking aws-sdk-sts v1.44.0 [INFO] [stderr] Checking aws-sdk-secretsmanager v1.48.0 [INFO] [stderr] Checking aws-config v1.5.7 [INFO] [stderr] Checking aws_secretsmanager_caching v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secret_store/memory_store/mod.rs:156:15 [INFO] [stdout] | [INFO] [stdout] 152 | let mut store = MemoryStore::default(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | match store.get_secret_value(NAME, None, None) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secret_store/memory_store/mod.rs:175:15 [INFO] [stdout] | [INFO] [stdout] 171 | let mut store = MemoryStore::default(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | match store.get_secret_value(NAME, None, Some("AWSCURRENT")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `secret_store::SecretStoreError` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secret_store/memory_store/mod.rs:244:20 [INFO] [stdout] | [INFO] [stdout] 225 | let mut store = MemoryStore::new(NonZeroUsize::new(1).unwrap(), Duration::from_secs(1000)); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | let secret_value_output_read = store.get_secret_value(NAME, None, None); [INFO] [stdout] | ------------------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let second_secret_read = [INFO] [stdout] | ------------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | if let Err(e) = second_secret_read { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secret_store/memory_store/mod.rs:260:15 [INFO] [stdout] | [INFO] [stdout] 251 | let mut store = MemoryStore::default(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | match store.get_secret_value(NAME, Some(VERSION_ID), Some("AWSCURRENT")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secret_store/memory_store/mod.rs:272:15 [INFO] [stdout] | [INFO] [stdout] 268 | let mut store = MemoryStore::default(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | match store.get_secret_value(NAME, None, Some("NONEXISTENTSTAGE")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:577:15 [INFO] [stdout] | [INFO] [stdout] 566 | let client = fake_client(Some(Duration::from_secs(0))); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 577 | match client.get_secret_value(secret_id, version_id, None).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aws_secretsmanager_caching` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "0d466990074d37599127f2a3adeaabe3f37251d079f2a143b505321e9f5ada40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d466990074d37599127f2a3adeaabe3f37251d079f2a143b505321e9f5ada40", kill_on_drop: false }` [INFO] [stdout] 0d466990074d37599127f2a3adeaabe3f37251d079f2a143b505321e9f5ada40