[INFO] fetching crate atm0s-sdn-network 0.5.0... [INFO] checking atm0s-sdn-network-0.5.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate atm0s-sdn-network 0.5.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate atm0s-sdn-network 0.5.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate atm0s-sdn-network 0.5.0 [INFO] finished tweaking crates.io crate atm0s-sdn-network 0.5.0 [INFO] tweaked toml for crates.io crate atm0s-sdn-network 0.5.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 151 packages to latest compatible versions [INFO] [stderr] Adding convert_case v0.4.0 (available: v0.6.0) [INFO] [stderr] Adding derive_more v0.99.18 (available: v1.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding mockall v0.12.1 (available: v0.13.0) [INFO] [stderr] Adding mockall_derive v0.12.1 (available: v0.13.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding termtree v0.4.1 (available: v0.5.1) [INFO] [stderr] Adding unsigned-varint v0.7.2 (available: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5659b62446492e0b49e7fb0311b3ec1627cb3a8b46ac7bbf5573c240732ec5a6 [INFO] running `Command { std: "docker" "start" "-a" "5659b62446492e0b49e7fb0311b3ec1627cb3a8b46ac7bbf5573c240732ec5a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5659b62446492e0b49e7fb0311b3ec1627cb3a8b46ac7bbf5573c240732ec5a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5659b62446492e0b49e7fb0311b3ec1627cb3a8b46ac7bbf5573c240732ec5a6", kill_on_drop: false }` [INFO] [stdout] 5659b62446492e0b49e7fb0311b3ec1627cb3a8b46ac7bbf5573c240732ec5a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0e0d7622559260fdbd1891a08a61343fb4e9cd11355fb9b5052d223b7eb69fe0 [INFO] running `Command { std: "docker" "start" "-a" "0e0d7622559260fdbd1891a08a61343fb4e9cd11355fb9b5052d223b7eb69fe0", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling data-encoding v2.6.0 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking unsigned-varint v0.7.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking multihash v0.19.1 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking quick-protobuf v0.8.1 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking base-x v0.2.11 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking libp2p-identity v0.2.9 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking unsigned-varint v0.8.0 [INFO] [stderr] Compiling mockall_derive v0.12.1 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling num_enum_derive v0.7.3 [INFO] [stderr] Checking predicates v3.1.2 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking atm0s-sdn-utils v0.2.1 [INFO] [stderr] Checking num_enum v0.7.3 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking mockall v0.12.1 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.13 [INFO] [stderr] Compiling convert-enum v0.1.0 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking sans-io-runtime v0.2.1 [INFO] [stderr] Checking data-encoding-macro v0.1.15 [INFO] [stderr] Checking multibase v0.9.1 [INFO] [stderr] Checking multiaddr v0.18.2 [INFO] [stderr] Checking atm0s-sdn-identity v0.3.1 [INFO] [stderr] Checking atm0s-sdn-router v0.2.1 [INFO] [stderr] Checking atm0s-sdn-network v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `ExtIn` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_plane.rs:166:24 [INFO] [stdout] | [INFO] [stdout] 164 | pub fn on_event(&mut self, now_ms: u64, event: Input) { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | match event { [INFO] [stdout] 166 | Input::Ext(ext) => match ext { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ExtIn` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_plane.rs:166:24 [INFO] [stdout] | [INFO] [stdout] 164 | pub fn on_event(&mut self, now_ms: u64, event: Input) { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | match event { [INFO] [stdout] 166 | Input::Ext(ext) => match ext { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/features/socket.rs:283:13 [INFO] [stdout] | [INFO] [stdout] 283 | _ => {} [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/features/socket.rs:283:13 [INFO] [stdout] | [INFO] [stdout] 230 | FeatureWorkerInput::Network(_conn, meta, buf) => { [INFO] [stdout] | --------------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 234 | FeatureWorkerInput::FromController(_, control) => match control { [INFO] [stdout] | ---------------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 250 | FeatureWorkerInput::Control(actor, control) => { [INFO] [stdout] | ------------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 279 | FeatureWorkerInput::Local(meta, buf) => { [INFO] [stdout] | ------------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 283 | _ => {} [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pkt` [INFO] [stdout] --> src/features/vpn.rs:77:60 [INFO] [stdout] | [INFO] [stdout] 77 | fn process_udp(&mut self, _ctx: &FeatureWorkerContext, pkt: Buffer) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_pkt` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/features/socket.rs:283:13 [INFO] [stdout] | [INFO] [stdout] 283 | _ => {} [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/features/socket.rs:283:13 [INFO] [stdout] | [INFO] [stdout] 230 | FeatureWorkerInput::Network(_conn, meta, buf) => { [INFO] [stdout] | --------------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 234 | FeatureWorkerInput::FromController(_, control) => match control { [INFO] [stdout] | ---------------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 250 | FeatureWorkerInput::Control(actor, control) => { [INFO] [stdout] | ------------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 279 | FeatureWorkerInput::Local(meta, buf) => { [INFO] [stdout] | ------------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 283 | _ => {} [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pkt` [INFO] [stdout] --> src/features/vpn.rs:77:60 [INFO] [stdout] | [INFO] [stdout] 77 | fn process_udp(&mut self, _ctx: &FeatureWorkerContext, pkt: Buffer) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_pkt` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atm0s-sdn-network` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `atm0s-sdn-network` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0e0d7622559260fdbd1891a08a61343fb4e9cd11355fb9b5052d223b7eb69fe0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e0d7622559260fdbd1891a08a61343fb4e9cd11355fb9b5052d223b7eb69fe0", kill_on_drop: false }` [INFO] [stdout] 0e0d7622559260fdbd1891a08a61343fb4e9cd11355fb9b5052d223b7eb69fe0