[INFO] fetching crate arrow-flight 53.0.0... [INFO] checking arrow-flight-53.0.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate arrow-flight 53.0.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate arrow-flight 53.0.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate arrow-flight 53.0.0 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate arrow-flight 53.0.0 [INFO] tweaked toml for crates.io crate arrow-flight 53.0.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate arrow-flight 53.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] db849d8e77a5849b3faaaae8aa263d267976b01f5bed75e19a7400bec5c7f6d5 [INFO] running `Command { std: "docker" "start" "-a" "db849d8e77a5849b3faaaae8aa263d267976b01f5bed75e19a7400bec5c7f6d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "db849d8e77a5849b3faaaae8aa263d267976b01f5bed75e19a7400bec5c7f6d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db849d8e77a5849b3faaaae8aa263d267976b01f5bed75e19a7400bec5c7f6d5", kill_on_drop: false }` [INFO] [stdout] db849d8e77a5849b3faaaae8aa263d267976b01f5bed75e19a7400bec5c7f6d5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ba110e453bfe04f9fe150a80adc0c5d921b161185c90a509753fb81618352d1b [INFO] running `Command { std: "docker" "start" "-a" "ba110e453bfe04f9fe150a80adc0c5d921b161185c90a509753fb81618352d1b", kill_on_drop: false }` [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking predicates v3.1.2 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking assert_cmd v2.0.16 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tower v0.5.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.82 [INFO] [stderr] Compiling prost-derive v0.13.2 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking prost v0.13.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking arrow-array v53.0.0 [INFO] [stderr] Checking prost-types v0.13.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking arrow-select v53.0.0 [INFO] [stderr] Checking arrow-cast v53.0.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking arrow-ipc v53.0.0 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-timeout v0.5.1 [INFO] [stderr] Checking tonic v0.12.2 [INFO] [stderr] Checking arrow-flight v53.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::vec::Drain<'_, arrow_array::RecordBatch>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:1286:13 [INFO] [stdout] | [INFO] [stdout] 1278 | async fn verify_flight_round_trip(mut batches: Vec) { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1286 | let mut expected_batches = batches.drain(..); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `FlightDataEncoder` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:1589:17 [INFO] [stdout] | [INFO] [stdout] 1580 | async fn verify_encoded_split(batch: RecordBatch, allowed_overage: usize) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1589 | let mut stream = FlightDataEncoderBuilder::new() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::task::Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/streams.rs:63:22 [INFO] [stdout] | [INFO] [stdout] 63 | match ready!(request_streams.poll_next_unpin(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::task::Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/streams.rs:128:22 [INFO] [stdout] | [INFO] [stdout] 128 | match ready!(pinned.response_stream.poll_next_unpin(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arrow-flight` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:750:35 [INFO] [stdout] | [INFO] [stdout] 742 | let mut decoder = FlightDataDecoder::new(encoder); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 745 | let mut expected_arrays = vec![ [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 750 | while let Some(decoded) = decoder.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:850:35 [INFO] [stdout] | [INFO] [stdout] 812 | let mut builder = ListBuilder::new(StringDictionaryBuilder::::new()); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 835 | let mut decoder = FlightDataDecoder::new(encoder); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 844 | let mut expected_arrays = vec![ [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 850 | while let Some(decoded) = decoder.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:956:35 [INFO] [stdout] | [INFO] [stdout] 900 | let mut struct_builder = StructBuilder::new( [INFO] [stdout] | ------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 937 | let mut decoder = FlightDataDecoder::new(encoder); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 950 | let mut expected_arrays = vec![ [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 956 | while let Some(decoded) = decoder.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encode.rs:1145:35 [INFO] [stdout] | [INFO] [stdout] 1045 | let mut builder = builder::ListBuilder::new(StringDictionaryBuilder::::new()); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1114 | let mut decoder = FlightDataDecoder::new(encoder); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1137 | let mut expected_arrays = vec![ [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1145 | while let Some(decoded) = decoder.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::task::Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/streams.rs:63:22 [INFO] [stdout] | [INFO] [stdout] 63 | match ready!(request_streams.poll_next_unpin(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::task::Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/streams.rs:128:22 [INFO] [stdout] | [INFO] [stdout] 128 | match ready!(pinned.response_stream.poll_next_unpin(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arrow-flight` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "ba110e453bfe04f9fe150a80adc0c5d921b161185c90a509753fb81618352d1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba110e453bfe04f9fe150a80adc0c5d921b161185c90a509753fb81618352d1b", kill_on_drop: false }` [INFO] [stdout] ba110e453bfe04f9fe150a80adc0c5d921b161185c90a509753fb81618352d1b