[INFO] fetching crate app_ctx 0.2.0-SNAPSHOT... [INFO] checking app_ctx-0.2.0-SNAPSHOT against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate app_ctx 0.2.0-SNAPSHOT into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate app_ctx 0.2.0-SNAPSHOT on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate app_ctx 0.2.0-SNAPSHOT [INFO] finished tweaking crates.io crate app_ctx 0.2.0-SNAPSHOT [INFO] tweaked toml for crates.io crate app_ctx 0.2.0-SNAPSHOT written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 38 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ccd927014eb8d29808ac37ade8935881f997eb5cc7b46c2e7bc213844fe72511 [INFO] running `Command { std: "docker" "start" "-a" "ccd927014eb8d29808ac37ade8935881f997eb5cc7b46c2e7bc213844fe72511", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ccd927014eb8d29808ac37ade8935881f997eb5cc7b46c2e7bc213844fe72511", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ccd927014eb8d29808ac37ade8935881f997eb5cc7b46c2e7bc213844fe72511", kill_on_drop: false }` [INFO] [stdout] ccd927014eb8d29808ac37ade8935881f997eb5cc7b46c2e7bc213844fe72511 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4a9530fb1bbd9b7ee805aaea1f6f46be186e1b5d0826f5857a1727cefb4e39c6 [INFO] running `Command { std: "docker" "start" "-a" "4a9530fb1bbd9b7ee805aaea1f6f46be186e1b5d0826f5857a1727cefb4e39c6", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking app_ctx v0.2.0-SNAPSHOT (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::any::Any` [INFO] [stdout] --> src/error.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::any::Any; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:448:9 [INFO] [stdout] | [INFO] [stdout] 448 | mut self, [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `m` [INFO] [stdout] --> src/error.rs:39:34 [INFO] [stdout] | [INFO] [stdout] 39 | if let BeanError::Custom(m, e) = self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_m` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/lib.rs:222:20 [INFO] [stdout] | [INFO] [stdout] 222 | if let BeanPriority::DependsOn(v) = T::priority() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/lib.rs:243:20 [INFO] [stdout] | [INFO] [stdout] 243 | if let BeanPriority::DependsOn(v) = T::priority() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/lib.rs:293:20 [INFO] [stdout] | [INFO] [stdout] 293 | if let BeanPriority::DependsOn(v) = T::priority() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/lib.rs:324:20 [INFO] [stdout] | [INFO] [stdout] 324 | if let BeanPriority::DependsOn(v) = T::priority() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:425:9 [INFO] [stdout] | [INFO] [stdout] 425 | mut self, [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `meta` [INFO] [stdout] --> src/lib.rs:510:21 [INFO] [stdout] | [INFO] [stdout] 510 | .find(|(meta, bean)| !bean.initialized()) [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_meta` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:695:15 [INFO] [stdout] | [INFO] [stdout] 693 | CustomFnEnum::Sync(Arc::new(|wrap| { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 694 | let r = wrap.build_bean_ref::().acquire(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 695 | match r.init_self() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:708:15 [INFO] [stdout] | [INFO] [stdout] 706 | CustomFnEnum::Sync(Arc::new(|wrap| { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 707 | let r = wrap.build_bean_ref::().acquire(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 708 | match r.clean_self() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:723:19 [INFO] [stdout] | [INFO] [stdout] 722 | let r = wrap.build_bean_ref::().acquire(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 723 | match r.init_self().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:738:19 [INFO] [stdout] | [INFO] [stdout] 737 | let r = wrap.build_bean_ref::().acquire(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 738 | match r.clean_self().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/lib.rs:793:26 [INFO] [stdout] | [INFO] [stdout] 793 | .filter(|(k, v)| k.type_name == type_name::()) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `k` [INFO] [stdout] --> src/lib.rs:794:20 [INFO] [stdout] | [INFO] [stdout] 794 | .map(|(k, v)| v.clone().build_bean_ref()) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_k` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/lib.rs:806:26 [INFO] [stdout] | [INFO] [stdout] 806 | .filter(|(k, v)| k.bean_name == name) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `k` [INFO] [stdout] --> src/lib.rs:807:20 [INFO] [stdout] | [INFO] [stdout] 807 | .map(|(k, v)| v.clone().build_bean_ref()) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_k` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `sync_one`, `async_one`, `run_destroy_fn`, and `run_destroy_fn_async` are never used [INFO] [stdout] --> src/lib.rs:210:19 [INFO] [stdout] | [INFO] [stdout] 193 | impl BeanWrapper { [INFO] [stdout] | ---------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 210 | pub(crate) fn sync_one(bean: OnceCell, meta: BeanMetadata) -> Self [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 231 | pub(crate) fn async_one(bean: OnceCell, meta: BeanMetadata) -> Self [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 355 | pub(crate) fn run_destroy_fn(&self) -> Result<(), BeanError> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 365 | pub(crate) async fn run_destroy_fn_async(&self) -> Result<(), BeanError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `EventType` is never used [INFO] [stdout] --> src/event.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | pub enum EventType {} [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EventType` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AppEvent` is never constructed [INFO] [stdout] --> src/event.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct AppEvent { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AppEvent` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `app_ctx` (lib) due to 5 previous errors; 16 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "4a9530fb1bbd9b7ee805aaea1f6f46be186e1b5d0826f5857a1727cefb4e39c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a9530fb1bbd9b7ee805aaea1f6f46be186e1b5d0826f5857a1727cefb4e39c6", kill_on_drop: false }` [INFO] [stdout] 4a9530fb1bbd9b7ee805aaea1f6f46be186e1b5d0826f5857a1727cefb4e39c6