[INFO] fetching crate apollo-smith 0.14.0... [INFO] checking apollo-smith-0.14.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate apollo-smith 0.14.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate apollo-smith 0.14.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate apollo-smith 0.14.0 [INFO] finished tweaking crates.io crate apollo-smith 0.14.0 [INFO] tweaked toml for crates.io crate apollo-smith 0.14.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate apollo-smith 0.14.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3775c3088f6b10c2dca6677707e8dbfdc2d412c743f98d78e79276781d0b47f2 [INFO] running `Command { std: "docker" "start" "-a" "3775c3088f6b10c2dca6677707e8dbfdc2d412c743f98d78e79276781d0b47f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3775c3088f6b10c2dca6677707e8dbfdc2d412c743f98d78e79276781d0b47f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3775c3088f6b10c2dca6677707e8dbfdc2d412c743f98d78e79276781d0b47f2", kill_on_drop: false }` [INFO] [stdout] 3775c3088f6b10c2dca6677707e8dbfdc2d412c743f98d78e79276781d0b47f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7329a733d0132dbd6e1e9d39f7a6ea69f85398c74f51eeb77e5f51e0a022103e [INFO] running `Command { std: "docker" "start" "-a" "7329a733d0132dbd6e1e9d39f7a6ea69f85398c74f51eeb77e5f51e0a022103e", kill_on_drop: false }` [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking concolor-query v0.3.3 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling syn v2.0.70 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking dissimilar v1.0.9 [INFO] [stderr] Checking concolor v0.1.1 [INFO] [stderr] Checking ariadne v0.4.1 [INFO] [stderr] Checking expect-test v1.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking rowan v0.15.15 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling derive_arbitrary v1.3.2 [INFO] [stderr] Checking arbitrary v1.3.2 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Checking apollo-parser v0.8.2 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking serde v1.0.204 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking serde_json v1.0.120 [INFO] [stderr] Checking triomphe v0.1.13 [INFO] [stderr] Checking jsonpath-rust v0.3.5 [INFO] [stderr] Checking serde_json_bytes v0.2.4 [INFO] [stderr] Checking apollo-compiler v1.0.0-beta.24 [INFO] [stderr] Checking apollo-smith v0.14.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `apollo_parser::cst::Definition` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/description.rs:96:52 [INFO] [stdout] | [INFO] [stdout] 94 | let cst = parser.parse(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let document = cst.document(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | if let Definition::SchemaDefinition(def) = document.definitions().next().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `apollo_parser::cst::EnumValue` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/enum_.rs:141:20 [INFO] [stdout] | [INFO] [stdout] 137 | enum_value_def: apollo_parser::cst::EnumValueDefinition, [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | value: enum_value_def [INFO] [stdout] | ____________________^ [INFO] [stdout] 142 | | .enum_value() [INFO] [stdout] 143 | | .expect("enum value def must have enum value") [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `apollo_parser::cst::EnumValue` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/enum_.rs:141:20 [INFO] [stdout] | [INFO] [stdout] 137 | enum_value_def: apollo_parser::cst::EnumValueDefinition, [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | value: enum_value_def [INFO] [stdout] | ____________________^ [INFO] [stdout] 142 | | .enum_value() [INFO] [stdout] 143 | | .expect("enum value def must have enum value") [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `FragmentName` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragment.rs:42:19 [INFO] [stdout] | [INFO] [stdout] 40 | fn try_from(fragment_def: apollo_parser::cst::FragmentDefinition) -> Result { [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Ok(Self { [INFO] [stdout] 42 | name: fragment_def.fragment_name().unwrap().name().unwrap().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `FragmentName` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragment.rs:80:19 [INFO] [stdout] | [INFO] [stdout] 78 | fn try_from(fragment_spread: apollo_parser::cst::FragmentSpread) -> Result { [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Ok(Self { [INFO] [stdout] 80 | name: fragment_spread [INFO] [stdout] | ___________________^ [INFO] [stdout] 81 | | .fragment_name() [INFO] [stdout] 82 | | .unwrap() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `apollo_parser::cst::NamedType` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragment.rs:148:19 [INFO] [stdout] | [INFO] [stdout] 146 | fn from(type_condition: apollo_parser::cst::TypeCondition) -> Self { [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | Self { [INFO] [stdout] 148 | name: type_condition.named_type().unwrap().name().unwrap().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `FragmentName` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragment.rs:42:19 [INFO] [stdout] | [INFO] [stdout] 40 | fn try_from(fragment_def: apollo_parser::cst::FragmentDefinition) -> Result { [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Ok(Self { [INFO] [stdout] 42 | name: fragment_def.fragment_name().unwrap().name().unwrap().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `FragmentName` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragment.rs:80:19 [INFO] [stdout] | [INFO] [stdout] 78 | fn try_from(fragment_spread: apollo_parser::cst::FragmentSpread) -> Result { [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Ok(Self { [INFO] [stdout] 80 | name: fragment_spread [INFO] [stdout] | ___________________^ [INFO] [stdout] 81 | | .fragment_name() [INFO] [stdout] 82 | | .unwrap() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `apollo_parser::cst::NamedType` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragment.rs:148:19 [INFO] [stdout] | [INFO] [stdout] 146 | fn from(type_condition: apollo_parser::cst::TypeCondition) -> Self { [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | Self { [INFO] [stdout] 148 | name: type_condition.named_type().unwrap().name().unwrap().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `rowan::api::SyntaxToken` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/name.rs:64:19 [INFO] [stdout] | [INFO] [stdout] 62 | fn from(name: apollo_parser::cst::Name) -> Self { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Self { [INFO] [stdout] 64 | name: name.ident_token().unwrap().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `rowan::api::SyntaxToken` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/name.rs:64:19 [INFO] [stdout] | [INFO] [stdout] 62 | fn from(name: apollo_parser::cst::Name) -> Self { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Self { [INFO] [stdout] 64 | name: name.ident_token().unwrap().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `apollo_parser::cst::NonNullType` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ty.rs:49:51 [INFO] [stdout] | [INFO] [stdout] 43 | fn from(ty: apollo_parser::cst::Type) -> Self { [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | apollo_parser::cst::Type::NonNullType(non_null) => { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `apollo_parser::cst::NonNullType` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ty.rs:49:51 [INFO] [stdout] | [INFO] [stdout] 43 | fn from(ty: apollo_parser::cst::Type) -> Self { [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | apollo_parser::cst::Type::NonNullType(non_null) => { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `apollo-smith` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `apollo-smith` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "7329a733d0132dbd6e1e9d39f7a6ea69f85398c74f51eeb77e5f51e0a022103e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7329a733d0132dbd6e1e9d39f7a6ea69f85398c74f51eeb77e5f51e0a022103e", kill_on_drop: false }` [INFO] [stdout] 7329a733d0132dbd6e1e9d39f7a6ea69f85398c74f51eeb77e5f51e0a022103e