[INFO] fetching crate alt 0.1.0... [INFO] checking alt-0.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate alt 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate alt 0.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate alt 0.1.0 [INFO] finished tweaking crates.io crate alt 0.1.0 [INFO] tweaked toml for crates.io crate alt 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate alt 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3ffa884f31dad5e59eed1a778558ac9af61d168613cff8cb87c304a4584173de [INFO] running `Command { std: "docker" "start" "-a" "3ffa884f31dad5e59eed1a778558ac9af61d168613cff8cb87c304a4584173de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3ffa884f31dad5e59eed1a778558ac9af61d168613cff8cb87c304a4584173de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ffa884f31dad5e59eed1a778558ac9af61d168613cff8cb87c304a4584173de", kill_on_drop: false }` [INFO] [stdout] 3ffa884f31dad5e59eed1a778558ac9af61d168613cff8cb87c304a4584173de [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ef512b3973ba92365945078275157823d17f4e5ef858f4fb4d2b5bf8dc90c118 [INFO] running `Command { std: "docker" "start" "-a" "ef512b3973ba92365945078275157823d17f4e5ef858f4fb4d2b5bf8dc90c118", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.30 [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking futures-core v0.3.5 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling error-chain v0.10.0 [INFO] [stderr] Compiling toml v0.2.1 [INFO] [stderr] Checking futures-sink v0.3.5 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling serde v1.0.111 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling proc-macro-nested v0.1.5 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking bytes v0.5.4 [INFO] [stderr] Checking once_cell v1.4.0 [INFO] [stderr] Checking pin-project-lite v0.1.7 [INFO] [stderr] Compiling proc-macro-hack v0.5.16 [INFO] [stderr] Checking futures-channel v0.3.5 [INFO] [stderr] Checking futures-task v0.3.5 [INFO] [stderr] Compiling metadeps v1.1.2 [INFO] [stderr] Checking futures-io v0.3.5 [INFO] [stderr] Compiling zmq v0.9.2 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling anyhow v1.0.31 [INFO] [stderr] Checking base64 v0.12.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Compiling zmq-sys v0.11.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking simplelog v0.8.0 [INFO] [stderr] Compiling serde_derive v1.0.111 [INFO] [stderr] Compiling tokio-macros v0.2.5 [INFO] [stderr] Compiling pin-project-internal v0.4.20 [INFO] [stderr] Compiling futures-macro v0.3.5 [INFO] [stderr] Compiling serde_repr v0.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.19 [INFO] [stderr] Checking tokio v0.2.21 [INFO] [stderr] Checking thiserror v1.0.19 [INFO] [stderr] Checking pin-project v0.4.20 [INFO] [stderr] Checking futures-util v0.3.5 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking futures-executor v0.3.5 [INFO] [stderr] Checking futures v0.3.5 [INFO] [stderr] Checking tmq v0.2.1 [INFO] [stderr] Checking serde_json v1.0.53 [INFO] [stderr] Checking ron v0.6.0 [INFO] [stderr] Checking i3ipc-types v0.8.0 [INFO] [stderr] Checking tokio-i3ipc v0.8.0 [INFO] [stderr] Checking alt v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `I3FocusListener` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | let mut i3listener = I3FocusListener::new(agg_tx); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 120 | / tokio::join!( [INFO] [stdout] 121 | | gateway.event_loop(), [INFO] [stdout] 122 | | i3listener.event_loop(), [INFO] [stdout] 123 | | aggregator.event_loop(), [INFO] [stdout] 124 | | client.event_loop(), [INFO] [stdout] 125 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `I3FocusListener` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | let mut i3listener = I3FocusListener::new(agg_tx); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 120 | / tokio::join!( [INFO] [stdout] 121 | | gateway.event_loop(), [INFO] [stdout] 122 | | i3listener.event_loop(), [INFO] [stdout] 123 | | aggregator.event_loop(), [INFO] [stdout] 124 | | client.event_loop(), [INFO] [stdout] 125 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/config.rs:9:24 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Clone, Debug, Deserialize, Eq, PartialEq, Hash)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Requirement` [INFO] [stdout] 10 | pub enum Requirement { [INFO] [stdout] | ----------- `Requirement` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/config.rs:15:24 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Clone, Debug, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Agg` [INFO] [stdout] 16 | pub struct Agg { [INFO] [stdout] | --- `Agg` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/config.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 22 | #[derive(Clone, Debug, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_AltCfg` [INFO] [stdout] 23 | pub struct AltCfg { [INFO] [stdout] | ------ `AltCfg` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/config.rs:9:24 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Clone, Debug, Deserialize, Eq, PartialEq, Hash)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Requirement` [INFO] [stdout] 10 | pub enum Requirement { [INFO] [stdout] | ----------- `Requirement` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/config.rs:15:24 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Clone, Debug, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Agg` [INFO] [stdout] 16 | pub struct Agg { [INFO] [stdout] | --- `Agg` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/config.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 22 | #[derive(Clone, Debug, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_AltCfg` [INFO] [stdout] 23 | pub struct AltCfg { [INFO] [stdout] | ------ `AltCfg` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `alt` (bin "alt" test) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `alt` (bin "alt") due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ef512b3973ba92365945078275157823d17f4e5ef858f4fb4d2b5bf8dc90c118", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef512b3973ba92365945078275157823d17f4e5ef858f4fb4d2b5bf8dc90c118", kill_on_drop: false }` [INFO] [stdout] ef512b3973ba92365945078275157823d17f4e5ef858f4fb4d2b5bf8dc90c118