[INFO] fetching crate allium 0.1.3... [INFO] checking allium-0.1.3 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate allium 0.1.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate allium 0.1.3 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate allium 0.1.3 [INFO] finished tweaking crates.io crate allium 0.1.3 [INFO] tweaked toml for crates.io crate allium 0.1.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate allium 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a16df956a581c0ba5841c961e2c7303dc4952a28dedf444667f1b6fe81df0c56 [INFO] running `Command { std: "docker" "start" "-a" "a16df956a581c0ba5841c961e2c7303dc4952a28dedf444667f1b6fe81df0c56", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a16df956a581c0ba5841c961e2c7303dc4952a28dedf444667f1b6fe81df0c56", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a16df956a581c0ba5841c961e2c7303dc4952a28dedf444667f1b6fe81df0c56", kill_on_drop: false }` [INFO] [stdout] a16df956a581c0ba5841c961e2c7303dc4952a28dedf444667f1b6fe81df0c56 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a37b7eb9d3423d018e61ba7f925ab124fb6b4a0cb866dbd2dc984143573fc72 [INFO] running `Command { std: "docker" "start" "-a" "5a37b7eb9d3423d018e61ba7f925ab124fb6b4a0cb866dbd2dc984143573fc72", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling cc v1.0.69 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Checking instant v0.1.10 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling futures-core v0.3.15 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling openssl v0.10.35 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling anyhow v1.0.42 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Compiling tokio v1.8.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling openssl-sys v0.9.65 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Compiling tokio-macros v1.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.26 [INFO] [stderr] Checking thiserror v1.0.26 [INFO] [stderr] Checking tokio-stream v0.1.7 [INFO] [stderr] Checking allium v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `tokio::sync::broadcast::Receiver` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/onion.rs:269:13 [INFO] [stdout] | [INFO] [stdout] 269 | let mut events = self.ctx.events.subscribe(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 270 | loop { [INFO] [stdout] 271 | / tokio::select! { [INFO] [stdout] 272 | | Ok(evt) = events.recv() => { [INFO] [stdout] 273 | | if evt == tunnel::Event::Switchover { [INFO] [stdout] 274 | | self.update_tunnel().await; [INFO] [stdout] ... | [INFO] [stdout] 286 | | else => break, [INFO] [stdout] 287 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::broadcast::Receiver` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/onion.rs:269:13 [INFO] [stdout] | [INFO] [stdout] 269 | let mut events = self.ctx.events.subscribe(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 270 | loop { [INFO] [stdout] 271 | / tokio::select! { [INFO] [stdout] 272 | | Ok(evt) = events.recv() => { [INFO] [stdout] 273 | | if evt == tunnel::Event::Switchover { [INFO] [stdout] 274 | | self.update_tunnel().await; [INFO] [stdout] ... | [INFO] [stdout] 286 | | else => break, [INFO] [stdout] 287 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `protocol::CircuitOpaque` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/onion/circuit.rs:202:16 [INFO] [stdout] | [INFO] [stdout] 197 | msg: SocketResult>, [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | Ok(mut msg) => { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `protocol::CircuitOpaque` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/onion/circuit.rs:202:16 [INFO] [stdout] | [INFO] [stdout] 197 | msg: SocketResult>, [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | Ok(mut msg) => { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Interval` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/onion.rs:434:13 [INFO] [stdout] | [INFO] [stdout] 434 | let mut round_timer = time::interval(self.round_duration); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 438 | / tokio::select! { [INFO] [stdout] 439 | | _ = round_timer.tick() => { [INFO] [stdout] 440 | | info!("next round"); [INFO] [stdout] 441 | | let _ = self.events.send(tunnel::Event::Switchover); [INFO] [stdout] ... | [INFO] [stdout] 445 | | } [INFO] [stdout] 446 | | } [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Interval` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/onion.rs:434:13 [INFO] [stdout] | [INFO] [stdout] 434 | let mut round_timer = time::interval(self.round_duration); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 438 | / tokio::select! { [INFO] [stdout] 439 | | _ = round_timer.tick() => { [INFO] [stdout] 440 | | info!("next round"); [INFO] [stdout] 441 | | let _ = self.events.send(tunnel::Event::Switchover); [INFO] [stdout] ... | [INFO] [stdout] 445 | | } [INFO] [stdout] 446 | | } [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/onion/protocol.rs:681:15 [INFO] [stdout] | [INFO] [stdout] 680 | pub(crate) fn verify(self, public_key: &RsaPublicKey) -> Result { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 681 | match public_key.verify(self.key.bytes().as_ref(), self.signature.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SIGNATURE_LEN` is never used [INFO] [stdout] --> src/onion/crypto/crypto_openssl.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | pub(crate) const SIGNATURE_LEN: usize = 512; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from_bytes` is never used [INFO] [stdout] --> src/onion/crypto/crypto_openssl.rs:137:19 [INFO] [stdout] | [INFO] [stdout] 120 | impl SessionKey { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 137 | pub(crate) fn from_bytes(bytes: &[u8]) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Destroy` is never constructed [INFO] [stdout] --> src/onion/tunnel.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 49 | pub(crate) enum Event { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] 50 | Switchover, [INFO] [stdout] 51 | Destroy, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Event` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/onion.rs:283:25 [INFO] [stdout] | [INFO] [stdout] 283 | tunnel.write(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 283 | let _ = tunnel.write(data); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `allium` (lib) due to 5 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::result::Result<(), anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/onion/protocol.rs:681:15 [INFO] [stdout] | [INFO] [stdout] 680 | pub(crate) fn verify(self, public_key: &RsaPublicKey) -> Result { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 681 | match public_key.verify(self.key.bytes().as_ref(), self.signature.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/onion/tests.rs:186:34 [INFO] [stdout] | [INFO] [stdout] 185 | let mut tunnel = incoming_rx.recv().await.unwrap(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | while let Ok(data) = tunnel.read().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Destroy` is never constructed [INFO] [stdout] --> src/onion/tunnel.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 49 | pub(crate) enum Event { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] 50 | Switchover, [INFO] [stdout] 51 | Destroy, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Event` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `ROUND_DURATION` is never used [INFO] [stdout] --> src/onion/tests.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const ROUND_DURATION: Duration = Duration::from_secs(5); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/onion.rs:283:25 [INFO] [stdout] | [INFO] [stdout] 283 | tunnel.write(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 283 | let _ = tunnel.write(data); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `allium` (lib test) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5a37b7eb9d3423d018e61ba7f925ab124fb6b4a0cb866dbd2dc984143573fc72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a37b7eb9d3423d018e61ba7f925ab124fb6b4a0cb866dbd2dc984143573fc72", kill_on_drop: false }` [INFO] [stdout] 5a37b7eb9d3423d018e61ba7f925ab124fb6b4a0cb866dbd2dc984143573fc72