[INFO] fetching crate all-is-cubes-mesh 0.8.0... [INFO] checking all-is-cubes-mesh-0.8.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate all-is-cubes-mesh 0.8.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate all-is-cubes-mesh 0.8.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate all-is-cubes-mesh 0.8.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate all-is-cubes-mesh 0.8.0 [INFO] tweaked toml for crates.io crate all-is-cubes-mesh 0.8.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate all-is-cubes-mesh 0.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f44bc7eac5e956c70166fee7d6b2a8e0dcdfce88887af4ce258e0476d17c62c2 [INFO] running `Command { std: "docker" "start" "-a" "f44bc7eac5e956c70166fee7d6b2a8e0dcdfce88887af4ce258e0476d17c62c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f44bc7eac5e956c70166fee7d6b2a8e0dcdfce88887af4ce258e0476d17c62c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f44bc7eac5e956c70166fee7d6b2a8e0dcdfce88887af4ce258e0476d17c62c2", kill_on_drop: false }` [INFO] [stdout] f44bc7eac5e956c70166fee7d6b2a8e0dcdfce88887af4ce258e0476d17c62c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e7516b64b0a97055b3adbfc4483c25ac362f4f6329320dce9536ff200634a2f5 [INFO] running `Command { std: "docker" "start" "-a" "e7516b64b0a97055b3adbfc4483c25ac362f4f6329320dce9536ff200634a2f5", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling az v1.2.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling never-say-never v6.6.666 [INFO] [stderr] Compiling syn v2.0.69 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling higher-kinded-types v0.1.1 [INFO] [stderr] Compiling mutants v0.0.3 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Compiling micromath v2.1.0 [INFO] [stderr] Compiling pin-project-lite v0.2.14 [INFO] [stderr] Compiling futures-task v0.3.30 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling polonius-the-crab v0.4.1 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling manyfmt v0.1.0 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking mint v0.5.9 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking yield-progress v0.1.7 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking embedded-graphics-core v0.4.0 [INFO] [stderr] Checking imgref v1.10.1 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking clap_builder v4.5.8 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking euclid v0.22.10 [INFO] [stderr] Compiling ordered-float v4.2.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking embedded-graphics v0.8.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking async_fn_traits v0.1.1 [INFO] [stderr] Compiling macro_rules_attribute-proc_macro v0.2.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking macro_rules_attribute v0.2.0 [INFO] [stderr] Checking noise v0.9.0 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking pollster v0.3.0 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Compiling num_enum_derive v0.5.11 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking clap v4.5.8 [INFO] [stderr] Checking num_enum v0.5.11 [INFO] [stderr] Checking png-decoder v0.1.1 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling exhaust-macros v0.1.1 [INFO] [stderr] Compiling bytemuck_derive v1.7.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling exhaust v0.1.1 [INFO] [stderr] Compiling bytemuck v1.16.1 [INFO] [stderr] Compiling all-is-cubes-base v0.8.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling all-is-cubes v0.8.0 [INFO] [stderr] Checking arcstr v1.2.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking all-is-cubes-render v0.8.0 [INFO] [stderr] Checking all-is-cubes-ui v0.8.0 [INFO] [stderr] Checking all-is-cubes-mesh v0.8.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking all-is-cubes-content v0.8.0 [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/block_mesh/analyze.rs:301:18 [INFO] [stdout] | [INFO] [stdout] 301 | dbg!(std::mem::size_of::()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W unused-qualifications` [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 301 - dbg!(std::mem::size_of::()), [INFO] [stdout] 301 + dbg!(size_of::()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/space_mesh.rs:1011:50 [INFO] [stdout] | [INFO] [stdout] 1011 | assert_eq!(dbg!(mesh.total_byte_size()), mem::size_of::()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 1011 - assert_eq!(dbg!(mesh.total_byte_size()), mem::size_of::()); [INFO] [stdout] 1011 + assert_eq!(dbg!(mesh.total_byte_size()), size_of::()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/space_mesh.rs:1023:34 [INFO] [stdout] | [INFO] [stdout] 1023 | let expected_data_size = mem::size_of_val::<[BlockVertex]>(mesh.vertices()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 1023 - let expected_data_size = mem::size_of_val::<[BlockVertex]>(mesh.vertices()) [INFO] [stdout] 1023 + let expected_data_size = size_of_val::<[BlockVertex]>(mesh.vertices()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/space_mesh.rs:1027:31 [INFO] [stdout] | [INFO] [stdout] 1027 | assert!(actual_size > mem::size_of::() + expected_data_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 1027 - assert!(actual_size > mem::size_of::() + expected_data_size); [INFO] [stdout] 1027 + assert!(actual_size > size_of::() + expected_data_size); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/space_mesh.rs:1028:32 [INFO] [stdout] | [INFO] [stdout] 1028 | assert!(actual_size <= mem::size_of::() + expected_data_size * 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 1028 - assert!(actual_size <= mem::size_of::() + expected_data_size * 3); [INFO] [stdout] 1028 + assert!(actual_size <= size_of::() + expected_data_size * 3); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `all_is_cubes::block::Block` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_mesh/analyze.rs:312:17 [INFO] [stdout] | [INFO] [stdout] 309 | let mut u = Universe::new(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | let slab = all_is_cubes::content::make_slab(&mut u, thickness, Resolution::R4); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `EvaluatedBlock` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:56:10 [INFO] [stdout] | [INFO] [stdout] 54 | pub(crate) fn test_block_mesh(block: Block) -> BlockMesh { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | BlockMesh::new( [INFO] [stdout] 56 | &block.evaluate().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `EvaluatedBlock` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:70:10 [INFO] [stdout] | [INFO] [stdout] 68 | fn test_block_mesh_threshold(block: Block) -> BlockMesh { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | BlockMesh::new( [INFO] [stdout] 70 | &block.evaluate().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Iterator as MeshTypes>::Vertex>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:662:30 [INFO] [stdout] | [INFO] [stdout] 659 | let mut universe = Universe::new(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 662 | for (face, face_mesh) in mesh.all_face_meshes() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `all-is-cubes-mesh` (lib test) due to 5 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e7516b64b0a97055b3adbfc4483c25ac362f4f6329320dce9536ff200634a2f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e7516b64b0a97055b3adbfc4483c25ac362f4f6329320dce9536ff200634a2f5", kill_on_drop: false }` [INFO] [stdout] e7516b64b0a97055b3adbfc4483c25ac362f4f6329320dce9536ff200634a2f5