[INFO] fetching crate algebraics 0.3.0... [INFO] checking algebraics-0.3.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate algebraics 0.3.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate algebraics 0.3.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate algebraics 0.3.0 [INFO] finished tweaking crates.io crate algebraics 0.3.0 [INFO] tweaked toml for crates.io crate algebraics 0.3.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 48 packages to latest compatible versions [INFO] [stderr] Adding indoc v1.0.9 (available: v2.0.5) [INFO] [stderr] Adding pyo3 v0.16.6 (available: v0.22.3) [INFO] [stderr] Adding pyo3-build-config v0.16.6 (available: v0.22.3) [INFO] [stderr] Adding pyo3-ffi v0.16.6 (available: v0.22.3) [INFO] [stderr] Adding pyo3-macros v0.16.6 (available: v0.22.3) [INFO] [stderr] Adding pyo3-macros-backend v0.16.6 (available: v0.22.3) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding unindent v0.1.11 (available: v0.2.3) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 87858441954e2efe749afd73810c2105e910338b4b6b6d1701699e4bbd01fd8f [INFO] running `Command { std: "docker" "start" "-a" "87858441954e2efe749afd73810c2105e910338b4b6b6d1701699e4bbd01fd8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "87858441954e2efe749afd73810c2105e910338b4b6b6d1701699e4bbd01fd8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87858441954e2efe749afd73810c2105e910338b4b6b6d1701699e4bbd01fd8f", kill_on_drop: false }` [INFO] [stdout] 87858441954e2efe749afd73810c2105e910338b4b6b6d1701699e4bbd01fd8f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 96aa8d8c20727a34cbe4cd29b269493a0a1f77dfa8a003e664d749593a4c7b2a [INFO] running `Command { std: "docker" "start" "-a" "96aa8d8c20727a34cbe4cd29b269493a0a1f77dfa8a003e664d749593a4c7b2a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking rand_pcg v0.3.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking algebraics v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/util.rs:937:9 [INFO] [stdout] | [INFO] [stdout] 933 | fn to_leaf_or_node_pair<'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 937 | &Self, [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/util.rs:937:9 [INFO] [stdout] | [INFO] [stdout] 933 | fn to_leaf_or_node_pair<'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 937 | &Self, [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ModularInteger` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mod_int.rs:1051:19 [INFO] [stdout] | [INFO] [stdout] 1050 | fn div(self, rhs: ModularInteger) -> ModularInteger { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1051 | self.mul(&rhs.inverse()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Polynomial` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial/gcd.rs:128:21 [INFO] [stdout] | [INFO] [stdout] 107 | u: Polynomial, [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | v: Polynomial, [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | psi_p: T, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let r = u.clone().pseudo_div_rem(&v).remainder; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:1402:40 [INFO] [stdout] | [INFO] [stdout] 1400 | remainder, factor, .. [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1401 | } = a.clone().pseudo_div_rem(b); [INFO] [stdout] 1402 | if let Some(content) = remainder.nonzero_content() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `minimal_polynomial` is never read [INFO] [stdout] --> src/algebraic_numbers.rs:319:5 [INFO] [stdout] | [INFO] [stdout] 318 | struct IntervalShrinker<'a> { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 319 | minimal_polynomial: &'a Polynomial, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `IntervalShrinker` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `DivRemNearest` is never used [INFO] [stdout] --> src/traits.rs:208:18 [INFO] [stdout] | [INFO] [stdout] 208 | pub(crate) trait DivRemNearest: Sized { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `IsolatedRealRoot` is never used [INFO] [stdout] --> src/traits.rs:477:18 [INFO] [stdout] | [INFO] [stdout] 477 | pub(crate) trait IsolatedRealRoot { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/array2d.rs:73:28 [INFO] [stdout] | [INFO] [stdout] 73 | data: this.data.borrow(), [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[T]` does not implement `Borrow`, so calling `borrow` on `&[T]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/polynomial/div_rem.rs:247:67 [INFO] [stdout] | [INFO] [stdout] 247 | let (quotient, factor) = self.clone().exact_pseudo_div(rhs.borrow()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Polynomial` does not implement `Borrow`, so calling `borrow` on `&Polynomial` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 247 - let (quotient, factor) = self.clone().exact_pseudo_div(rhs.borrow()); [INFO] [stdout] 247 + let (quotient, factor) = self.clone().exact_pseudo_div(rhs); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Polynomial`, implement `Clone` for it [INFO] [stdout] --> src/polynomial.rs:829:1 [INFO] [stdout] | [INFO] [stdout] 829 + #[derive(Clone)] [INFO] [stdout] 830 | pub struct Polynomial { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/polynomial/div_rem.rs:251:75 [INFO] [stdout] | [INFO] [stdout] 251 | let (quotient, factor) = self.clone().checked_exact_pseudo_div(rhs.borrow())?; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Polynomial` does not implement `Borrow`, so calling `borrow` on `&Polynomial` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 251 - let (quotient, factor) = self.clone().checked_exact_pseudo_div(rhs.borrow())?; [INFO] [stdout] 251 + let (quotient, factor) = self.clone().checked_exact_pseudo_div(rhs)?; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Polynomial`, implement `Clone` for it [INFO] [stdout] --> src/polynomial.rs:829:1 [INFO] [stdout] | [INFO] [stdout] 829 + #[derive(Clone)] [INFO] [stdout] 830 | pub struct Polynomial { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `algebraics` (lib) due to 4 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `mod_int::ModularInteger` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mod_int.rs:1051:19 [INFO] [stdout] | [INFO] [stdout] 1050 | fn div(self, rhs: ModularInteger) -> ModularInteger { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1051 | self.mul(&rhs.inverse()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `polynomial::Polynomial` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial/gcd.rs:128:21 [INFO] [stdout] | [INFO] [stdout] 107 | u: Polynomial, [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | v: Polynomial, [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | psi_p: T, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let r = u.clone().pseudo_div_rem(&v).remainder; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:1402:40 [INFO] [stdout] | [INFO] [stdout] 1400 | remainder, factor, .. [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1401 | } = a.clone().pseudo_div_rem(b); [INFO] [stdout] 1402 | if let Some(content) = remainder.nonzero_content() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `minimal_polynomial` is never read [INFO] [stdout] --> src/algebraic_numbers.rs:319:5 [INFO] [stdout] | [INFO] [stdout] 318 | struct IntervalShrinker<'a> { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 319 | minimal_polynomial: &'a Polynomial, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `IntervalShrinker` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `DivRemNearest` is never used [INFO] [stdout] --> src/traits.rs:208:18 [INFO] [stdout] | [INFO] [stdout] 208 | pub(crate) trait DivRemNearest: Sized { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `IsolatedRealRoot` is never used [INFO] [stdout] --> src/traits.rs:477:18 [INFO] [stdout] | [INFO] [stdout] 477 | pub(crate) trait IsolatedRealRoot { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/array2d.rs:73:28 [INFO] [stdout] | [INFO] [stdout] 73 | data: this.data.borrow(), [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[T]` does not implement `Borrow`, so calling `borrow` on `&[T]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/polynomial/div_rem.rs:247:67 [INFO] [stdout] | [INFO] [stdout] 247 | let (quotient, factor) = self.clone().exact_pseudo_div(rhs.borrow()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `polynomial::Polynomial` does not implement `Borrow`, so calling `borrow` on `&polynomial::Polynomial` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 247 - let (quotient, factor) = self.clone().exact_pseudo_div(rhs.borrow()); [INFO] [stdout] 247 + let (quotient, factor) = self.clone().exact_pseudo_div(rhs); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `polynomial::Polynomial`, implement `Clone` for it [INFO] [stdout] --> src/polynomial.rs:829:1 [INFO] [stdout] | [INFO] [stdout] 829 + #[derive(Clone)] [INFO] [stdout] 830 | pub struct Polynomial { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/polynomial/div_rem.rs:251:75 [INFO] [stdout] | [INFO] [stdout] 251 | let (quotient, factor) = self.clone().checked_exact_pseudo_div(rhs.borrow())?; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `polynomial::Polynomial` does not implement `Borrow`, so calling `borrow` on `&polynomial::Polynomial` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 251 - let (quotient, factor) = self.clone().checked_exact_pseudo_div(rhs.borrow())?; [INFO] [stdout] 251 + let (quotient, factor) = self.clone().checked_exact_pseudo_div(rhs)?; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `polynomial::Polynomial`, implement `Clone` for it [INFO] [stdout] --> src/polynomial.rs:829:1 [INFO] [stdout] | [INFO] [stdout] 829 + #[derive(Clone)] [INFO] [stdout] 830 | pub struct Polynomial { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `algebraics` (lib test) due to 4 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "96aa8d8c20727a34cbe4cd29b269493a0a1f77dfa8a003e664d749593a4c7b2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96aa8d8c20727a34cbe4cd29b269493a0a1f77dfa8a003e664d749593a4c7b2a", kill_on_drop: false }` [INFO] [stdout] 96aa8d8c20727a34cbe4cd29b269493a0a1f77dfa8a003e664d749593a4c7b2a