[INFO] fetching crate agreed 1.1.0... [INFO] checking agreed-1.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate agreed 1.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate agreed 1.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate agreed 1.1.0 [INFO] finished tweaking crates.io crate agreed 1.1.0 [INFO] tweaked toml for crates.io crate agreed 1.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 63 packages to latest compatible versions [INFO] [stderr] Adding derive_more v0.99.18 (available: v1.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b0da9b315996b3d5228cc0481706667639d0a60c3c45096e418d8a4a66265973 [INFO] running `Command { std: "docker" "start" "-a" "b0da9b315996b3d5228cc0481706667639d0a60c3c45096e418d8a4a66265973", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b0da9b315996b3d5228cc0481706667639d0a60c3c45096e418d8a4a66265973", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0da9b315996b3d5228cc0481706667639d0a60c3c45096e418d8a4a66265973", kill_on_drop: false }` [INFO] [stdout] b0da9b315996b3d5228cc0481706667639d0a60c3c45096e418d8a4a66265973 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0cdc59c09a36ec05ff64f2506127a76131a684911f585229a8eefb8c5c3f85b2 [INFO] running `Command { std: "docker" "start" "-a" "0cdc59c09a36ec05ff64f2506127a76131a684911f585229a8eefb8c5c3f85b2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking agreed v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `futures::stream::FuturesOrdered::::push`: use `push_back` instead [INFO] [stdout] --> src/core/client.rs:97:45 [INFO] [stdout] | [INFO] [stdout] 97 | self.config_change_committed_cb.push(rx_payload_committed); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `futures::stream::FuturesOrdered::::push`: use `push_back` instead [INFO] [stdout] --> src/core/client.rs:97:45 [INFO] [stdout] | [INFO] [stdout] 97 | self.config_change_committed_cb.push(rx_payload_committed); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `futures::stream::FuturesOrdered::::push`: use `push_back` instead [INFO] [stdout] --> src/core/append_entries.rs:276:37 [INFO] [stdout] | [INFO] [stdout] 276 | self.replicate_to_sm_handle.push(handle); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `futures::stream::FuturesOrdered::::push`: use `push_back` instead [INFO] [stdout] --> src/core/append_entries.rs:314:37 [INFO] [stdout] | [INFO] [stdout] 314 | self.replicate_to_sm_handle.push(handle); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `futures::stream::FuturesOrdered::::push`: use `push_back` instead [INFO] [stdout] --> src/core/append_entries.rs:276:37 [INFO] [stdout] | [INFO] [stdout] 276 | self.replicate_to_sm_handle.push(handle); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `futures::stream::FuturesOrdered::::push`: use `push_back` instead [INFO] [stdout] --> src/core/append_entries.rs:314:37 [INFO] [stdout] | [INFO] [stdout] 314 | self.replicate_to_sm_handle.push(handle); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `futures::stream::FuturesOrdered::::push`: use `push_back` instead [INFO] [stdout] --> src/core/admin.rs:173:37 [INFO] [stdout] | [INFO] [stdout] 173 | self.cancel_catch_up_cb.push(cancel_catch_up_rx); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `futures::stream::FuturesOrdered::::push`: use `push_back` instead [INFO] [stdout] --> src/core/admin.rs:345:14 [INFO] [stdout] | [INFO] [stdout] 345 | .push(rx_config_change_committed); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `futures::stream::FuturesOrdered::::push`: use `push_back` instead [INFO] [stdout] --> src/core/admin.rs:173:37 [INFO] [stdout] | [INFO] [stdout] 173 | self.cancel_catch_up_cb.push(cancel_catch_up_rx); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `futures::stream::FuturesOrdered::::push`: use `push_back` instead [INFO] [stdout] --> src/core/admin.rs:345:14 [INFO] [stdout] | [INFO] [stdout] 345 | .push(rx_config_change_committed); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::mpsc::Receiver<(VoteResponse, u64)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/mod.rs:865:17 [INFO] [stdout] | [INFO] [stdout] 865 | let mut pending_votes = self.spawn_parallel_vote_requests(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 873 | / tokio::select! { [INFO] [stdout] 874 | | _ = timeout_fut => break, // This election has timed-out. Break to outer loop, which starts a new term. [INFO] [stdout] 875 | | Some((res, peer)) = pending_votes.recv() => self.handle_vote_response(res, peer).await?, [INFO] [stdout] 876 | | Some(msg) = self.core.rx_api.recv() => match msg { [INFO] [stdout] ... | [INFO] [stdout] 913 | | Ok(_) = &mut self.core.rx_shutdown => self.core.set_target_state(State::Shutdown), [INFO] [stdout] 914 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::mpsc::Receiver<(VoteResponse, u64)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/mod.rs:865:17 [INFO] [stdout] | [INFO] [stdout] 865 | let mut pending_votes = self.spawn_parallel_vote_requests(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 873 | / tokio::select! { [INFO] [stdout] 874 | | _ = timeout_fut => break, // This election has timed-out. Break to outer loop, which starts a new term. [INFO] [stdout] 875 | | Some((res, peer)) = pending_votes.recv() => self.handle_vote_response(res, peer).await?, [INFO] [stdout] 876 | | Some(msg) = self.core.rx_api.recv() => match msg { [INFO] [stdout] ... | [INFO] [stdout] 913 | | Ok(_) = &mut self.core.rx_shutdown => self.core.set_target_state(State::Shutdown), [INFO] [stdout] 914 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `handle` is never read [INFO] [stdout] --> src/replication/mod.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub(crate) struct ReplicationStream { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 20 | /// The spawn handle the `ReplicationCore` task. [INFO] [stdout] 21 | pub handle: JoinHandle<()>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `handle` is never read [INFO] [stdout] --> src/replication/mod.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub(crate) struct ReplicationStream { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 20 | /// The spawn handle the `ReplicationCore` task. [INFO] [stdout] 21 | pub handle: JoinHandle<()>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `agreed` (lib) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `agreed` (lib test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0cdc59c09a36ec05ff64f2506127a76131a684911f585229a8eefb8c5c3f85b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0cdc59c09a36ec05ff64f2506127a76131a684911f585229a8eefb8c5c3f85b2", kill_on_drop: false }` [INFO] [stdout] 0cdc59c09a36ec05ff64f2506127a76131a684911f585229a8eefb8c5c3f85b2