[INFO] fetching crate aether_lib 0.1.2... [INFO] checking aether_lib-0.1.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate aether_lib 0.1.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate aether_lib 0.1.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate aether_lib 0.1.2 [INFO] finished tweaking crates.io crate aether_lib 0.1.2 [INFO] tweaked toml for crates.io crate aether_lib 0.1.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 103 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (available: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.18) [INFO] [stderr] Adding criterion v0.3.6 (available: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (available: v0.5.0) [INFO] [stderr] Adding foreign-types v0.3.2 (available: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding serde_yaml v0.8.26 (available: v0.9.34+deprecated) [INFO] [stderr] Adding textwrap v0.11.0 (available: v0.16.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 79107bdf5f86796299a55982bc7a985a3bb3d53636e1d309b67a7aa0ad8f7799 [INFO] running `Command { std: "docker" "start" "-a" "79107bdf5f86796299a55982bc7a985a3bb3d53636e1d309b67a7aa0ad8f7799", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "79107bdf5f86796299a55982bc7a985a3bb3d53636e1d309b67a7aa0ad8f7799", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "79107bdf5f86796299a55982bc7a985a3bb3d53636e1d309b67a7aa0ad8f7799", kill_on_drop: false }` [INFO] [stdout] 79107bdf5f86796299a55982bc7a985a3bb3d53636e1d309b67a7aa0ad8f7799 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5f46efc1224c8083d3ae7fc29ecc9b80b144450b34ba8985f6e1c4e7369ad57c [INFO] running `Command { std: "docker" "start" "-a" "5f46efc1224c8083d3ae7fc29ecc9b80b144450b34ba8985f6e1c4e7369ad57c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Compiling cc v1.1.22 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling openssl-src v300.3.2+3.3.2 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Checking aether_lib v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer/mod.rs:436:15 [INFO] [stdout] | [INFO] [stdout] 356 | let mut connections_lock = connections.lock().expect("unable to lock failed list"); [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 363 | let handshake_thread = move |init: Initialized, request: ConnectionRequest| { [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | match (*connections_lock).remove(&request.username) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer/mod.rs:436:15 [INFO] [stdout] | [INFO] [stdout] 356 | let mut connections_lock = connections.lock().expect("unable to lock failed list"); [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 363 | let handshake_thread = move |init: Initialized, request: ConnectionRequest| { [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | match (*connections_lock).remove(&request.username) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aether_lib` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aether_lib` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "5f46efc1224c8083d3ae7fc29ecc9b80b144450b34ba8985f6e1c4e7369ad57c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f46efc1224c8083d3ae7fc29ecc9b80b144450b34ba8985f6e1c4e7369ad57c", kill_on_drop: false }` [INFO] [stdout] 5f46efc1224c8083d3ae7fc29ecc9b80b144450b34ba8985f6e1c4e7369ad57c