[INFO] updating cached repository https://github.com/NotQuiteApex/usb-picoboot-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 951bb149a103adc94c19769635926a2e81e024dc [INFO] checking NotQuiteApex/usb-picoboot-rs/951bb149a103adc94c19769635926a2e81e024dc against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNotQuiteApex%2Fusb-picoboot-rs" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/NotQuiteApex/usb-picoboot-rs on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/NotQuiteApex/usb-picoboot-rs [INFO] finished tweaking git repo https://github.com/NotQuiteApex/usb-picoboot-rs [INFO] tweaked toml for git repo https://github.com/NotQuiteApex/usb-picoboot-rs written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/NotQuiteApex/usb-picoboot-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aa0492cdd54b2f4f49c77cb9178096cb467937b6b8e8abff4d9a6f949402968e [INFO] running `Command { std: "docker" "start" "-a" "aa0492cdd54b2f4f49c77cb9178096cb467937b6b8e8abff4d9a6f949402968e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aa0492cdd54b2f4f49c77cb9178096cb467937b6b8e8abff4d9a6f949402968e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa0492cdd54b2f4f49c77cb9178096cb467937b6b8e8abff4d9a6f949402968e", kill_on_drop: false }` [INFO] [stdout] aa0492cdd54b2f4f49c77cb9178096cb467937b6b8e8abff4d9a6f949402968e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1514a5c8cf5d566bc866c3e2f6b08b123904237f8627814b803fed7711c9c82b [INFO] running `Command { std: "docker" "start" "-a" "1514a5c8cf5d566bc866c3e2f6b08b123904237f8627814b803fed7711c9c82b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling cc v1.1.8 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.207 [INFO] [stderr] Compiling rusb v0.9.4 [INFO] [stderr] Checking uf2-decode v0.2.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Compiling libusb1-sys v0.7.0 [INFO] [stderr] Compiling serde_derive v1.0.207 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking usb_picoboot_rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `rusb::Device` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/picousb.rs:307:19 [INFO] [stdout] | [INFO] [stdout] 292 | pub fn new(mut ctx: T) -> Self { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | let mut d = open_device(&mut ctx, PICOBOOT_VID, PICOBOOT_PID_RP2040); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 307 | Some((device, desc, handle)) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `access_not_exclusive`, `access_exclusive`, and `enter_xip` are never used [INFO] [stdout] --> src/picousb.rs:468:12 [INFO] [stdout] | [INFO] [stdout] 291 | impl PicobootConnection { [INFO] [stdout] | ----------------------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 468 | pub fn access_not_exclusive(&mut self) -> rusb::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 472 | pub fn access_exclusive(&mut self) -> rusb::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 518 | pub fn enter_xip(&mut self) -> rusb::Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `rusb::Device` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/picousb.rs:307:19 [INFO] [stdout] | [INFO] [stdout] 292 | pub fn new(mut ctx: T) -> Self { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | let mut d = open_device(&mut ctx, PICOBOOT_VID, PICOBOOT_PID_RP2040); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 307 | Some((device, desc, handle)) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `usb_picoboot_rs` (bin "usb_picoboot_rs" test) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: methods `access_not_exclusive`, `access_exclusive`, and `enter_xip` are never used [INFO] [stdout] --> src/picousb.rs:468:12 [INFO] [stdout] | [INFO] [stdout] 291 | impl PicobootConnection { [INFO] [stdout] | ----------------------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 468 | pub fn access_not_exclusive(&mut self) -> rusb::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 472 | pub fn access_exclusive(&mut self) -> rusb::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 518 | pub fn enter_xip(&mut self) -> rusb::Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `usb_picoboot_rs` (bin "usb_picoboot_rs") due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "1514a5c8cf5d566bc866c3e2f6b08b123904237f8627814b803fed7711c9c82b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1514a5c8cf5d566bc866c3e2f6b08b123904237f8627814b803fed7711c9c82b", kill_on_drop: false }` [INFO] [stdout] 1514a5c8cf5d566bc866c3e2f6b08b123904237f8627814b803fed7711c9c82b