[INFO] cloning repository https://github.com/MinkowskiMetric/my_rust_lox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MinkowskiMetric/my_rust_lox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMinkowskiMetric%2Fmy_rust_lox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMinkowskiMetric%2Fmy_rust_lox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3496e2dde413a430903bee4bf9a8f278877700e9 [INFO] checking MinkowskiMetric/my_rust_lox/3496e2dde413a430903bee4bf9a8f278877700e9 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMinkowskiMetric%2Fmy_rust_lox" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MinkowskiMetric/my_rust_lox on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MinkowskiMetric/my_rust_lox [INFO] finished tweaking git repo https://github.com/MinkowskiMetric/my_rust_lox [INFO] tweaked toml for git repo https://github.com/MinkowskiMetric/my_rust_lox written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MinkowskiMetric/my_rust_lox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b62e1410ce1ce8c1d59bba93926b06bf119fca52812874de3cf884663a2f8111 [INFO] running `Command { std: "docker" "start" "-a" "b62e1410ce1ce8c1d59bba93926b06bf119fca52812874de3cf884663a2f8111", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b62e1410ce1ce8c1d59bba93926b06bf119fca52812874de3cf884663a2f8111", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b62e1410ce1ce8c1d59bba93926b06bf119fca52812874de3cf884663a2f8111", kill_on_drop: false }` [INFO] [stdout] b62e1410ce1ce8c1d59bba93926b06bf119fca52812874de3cf884663a2f8111 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cff7a9b0167a2b25bd803721741fc4889250e4a7bb8cc37d0f7c3e823a05596b [INFO] running `Command { std: "docker" "start" "-a" "cff7a9b0167a2b25bd803721741fc4889250e4a7bb8cc37d0f7c3e823a05596b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling libc v0.2.117 [INFO] [stderr] Compiling anyhow v1.0.53 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling delegate-attr v0.2.9 [INFO] [stderr] Checking owned_chars v0.3.2 [INFO] [stderr] Checking my-rox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error_collector.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 26 | let values = F::from_iter(&mut self); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | match self.errors() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), UnwindableLoxError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:100:15 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn call_function(self, body: &ResolvedStatement) -> LoxResult { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | match self.interpreter.accept_statement(body) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error_collector.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 26 | let values = F::from_iter(&mut self); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | match self.errors() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), UnwindableLoxError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:100:15 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn call_function(self, body: &ResolvedStatement) -> LoxResult { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | match self.interpreter.accept_statement(body) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/core_parser.rs:690:15 [INFO] [stdout] | [INFO] [stdout] 689 | fn errors(self) -> Option> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 690 | match (self.tokens.errors(), self.errors) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:482:15 [INFO] [stdout] | [INFO] [stdout] 481 | fn errors(self) -> Option> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 482 | match (self.upstream_errors, self.errors) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `value::Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:212:14 [INFO] [stdout] | [INFO] [stdout] 208 | fn check_value_equal_rust(v: Value, t: T) -> bool [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | v == t.into() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:220:15 [INFO] [stdout] | [INFO] [stdout] 215 | fn check_rust_equal_value(check_value: T, v: Value) -> bool [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | match T::try_from(v) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/core_parser.rs:690:15 [INFO] [stdout] | [INFO] [stdout] 689 | fn errors(self) -> Option> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 690 | match (self.tokens.errors(), self.errors) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:230:15 [INFO] [stdout] | [INFO] [stdout] 226 | fn check_invalid_type(check_value: Value, check_type_str: &str) -> bool [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | match T::try_from(check_value.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `my-rox` (bin "my-rox" test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `(Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:482:15 [INFO] [stdout] | [INFO] [stdout] 481 | fn errors(self) -> Option> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 482 | match (self.upstream_errors, self.errors) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `my-rox` (bin "my-rox") due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "cff7a9b0167a2b25bd803721741fc4889250e4a7bb8cc37d0f7c3e823a05596b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cff7a9b0167a2b25bd803721741fc4889250e4a7bb8cc37d0f7c3e823a05596b", kill_on_drop: false }` [INFO] [stdout] cff7a9b0167a2b25bd803721741fc4889250e4a7bb8cc37d0f7c3e823a05596b