[INFO] cloning repository https://github.com/Logicalshift/flo_scene [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Logicalshift/flo_scene" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLogicalshift%2Fflo_scene", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLogicalshift%2Fflo_scene'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f87d1d8db4efe4fc99e1ba582752c4f0a6eadd1c [INFO] checking Logicalshift/flo_scene/f87d1d8db4efe4fc99e1ba582752c4f0a6eadd1c against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLogicalshift%2Fflo_scene" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Logicalshift/flo_scene on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Logicalshift/flo_scene [INFO] finished tweaking git repo https://github.com/Logicalshift/flo_scene [INFO] tweaked toml for git repo https://github.com/Logicalshift/flo_scene written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Logicalshift/flo_scene already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c5d984290c1fa2e729880ae6d8e1179252d5d6a4271e83b98de08e6f77cb1f68 [INFO] running `Command { std: "docker" "start" "-a" "c5d984290c1fa2e729880ae6d8e1179252d5d6a4271e83b98de08e6f77cb1f68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c5d984290c1fa2e729880ae6d8e1179252d5d6a4271e83b98de08e6f77cb1f68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5d984290c1fa2e729880ae6d8e1179252d5d6a4271e83b98de08e6f77cb1f68", kill_on_drop: false }` [INFO] [stdout] c5d984290c1fa2e729880ae6d8e1179252d5d6a4271e83b98de08e6f77cb1f68 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 85b2c9684643a2996fda5741f0af152ec2fbf44fe710e8637644d461e9b581b6 [INFO] running `Command { std: "docker" "start" "-a" "85b2c9684643a2996fda5741f0af152ec2fbf44fe710e8637644d461e9b581b6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.125 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking desync v0.8.2 [INFO] [stderr] Checking flo_stream v0.7.0 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking flo_scene v0.2.0 (/opt/rustwide/workdir/scene) [INFO] [stdout] warning: unused import: `crate::commands::*` [INFO] [stdout] --> scene/src/scene.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::commands::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio_errors::*` [INFO] [stdout] --> scene/src/error.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | pub use tokio_errors::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::commands::*` [INFO] [stdout] --> scene/src/scene.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::commands::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio_errors::*` [INFO] [stdout] --> scene/src/error.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | pub use tokio_errors::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option>>, std::option::Option>>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> scene/src/scene_context.rs:160:57 [INFO] [stdout] | [INFO] [stdout] 156 | ...command(&self, command: TCommand, input: impl 'static + Send + Stream) -> Result [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option>>, std::option::Option>>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> scene/src/scene_context.rs:246:57 [INFO] [stdout] | [INFO] [stdout] 240 | ...ommand>(&self, command: TCommand, query: impl 'static + QueryRequest, query_target: impl Into [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option>>, std::option::Option>>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> scene/src/scene_context.rs:160:57 [INFO] [stdout] | [INFO] [stdout] 156 | ...command(&self, command: TCommand, input: impl 'static + Send + Stream) -> Result [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option>>, std::option::Option>>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> scene/src/scene_context.rs:246:57 [INFO] [stdout] | [INFO] [stdout] 240 | ...ommand>(&self, command: TCommand, query: impl 'static + QueryRequest, query_target: impl Into [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option>>, std::option::Option>>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> scene/src/scene_context.rs:71:57 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn send(&self, target: impl Into) -> Result, ConnectionError> [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | if let (Some(scene_core), Some(program_core)) = (self.scene_core.upgrade(), self.program_core.upgrade()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option>>, std::option::Option>>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> scene/src/scene_context.rs:71:57 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn send(&self, target: impl Into) -> Result, ConnectionError> [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | if let (Some(scene_core), Some(program_core)) = (self.scene_core.upgrade(), self.program_core.upgrade()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `type_name` [INFO] [stdout] --> scene/src/stream_id.rs:646:48 [INFO] [stdout] | [INFO] [stdout] 646 | SerializedStreamId::RustType { type_name, target } => { [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `type_name: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `target` [INFO] [stdout] --> scene/src/stream_id.rs:646:59 [INFO] [stdout] | [INFO] [stdout] 646 | SerializedStreamId::RustType { type_name, target } => { [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `target: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option<(subprogram_id::SubProgramId, TMessage)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> scene/src/input_stream.rs:427:42 [INFO] [stdout] | [INFO] [stdout] 425 | let mut core = self.core.lock().unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 426 | [INFO] [stdout] 427 | if let Some((source, message)) = core.waiting_messages.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option<(subprogram_id::SubProgramId, TMessage)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> scene/src/input_stream.rs:477:42 [INFO] [stdout] | [INFO] [stdout] 475 | let mut core = self.core.lock().unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 476 | [INFO] [stdout] 477 | if let Some((source, message)) = core.waiting_messages.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `type_name` [INFO] [stdout] --> scene/src/stream_id.rs:646:48 [INFO] [stdout] | [INFO] [stdout] 646 | SerializedStreamId::RustType { type_name, target } => { [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `type_name: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `target` [INFO] [stdout] --> scene/src/stream_id.rs:646:59 [INFO] [stdout] | [INFO] [stdout] 646 | SerializedStreamId::RustType { type_name, target } => { [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `target: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option<(subprogram_id::SubProgramId, TMessage)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> scene/src/input_stream.rs:427:42 [INFO] [stdout] | [INFO] [stdout] 425 | let mut core = self.core.lock().unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 426 | [INFO] [stdout] 427 | if let Some((source, message)) = core.waiting_messages.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option<(subprogram_id::SubProgramId, TMessage)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> scene/src/input_stream.rs:477:42 [INFO] [stdout] | [INFO] [stdout] 475 | let mut core = self.core.lock().unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 476 | [INFO] [stdout] 477 | if let Some((source, message)) = core.waiting_messages.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>::SerializeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> scene/src/serialization.rs:175:26 [INFO] [stdout] | [INFO] [stdout] 174 | let typed_serializer = move |input: TMessageType| -> Result, TMessageType> { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | if let Ok(val) = input.to_serialized() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>::SerializeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> scene/src/serialization.rs:175:26 [INFO] [stdout] | [INFO] [stdout] 174 | let typed_serializer = move |input: TMessageType| -> Result, TMessageType> { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | if let Ok(val) = input.to_serialized() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flo_scene` (lib) due to 7 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flo_scene` (lib test) due to 7 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "85b2c9684643a2996fda5741f0af152ec2fbf44fe710e8637644d461e9b581b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85b2c9684643a2996fda5741f0af152ec2fbf44fe710e8637644d461e9b581b6", kill_on_drop: false }` [INFO] [stdout] 85b2c9684643a2996fda5741f0af152ec2fbf44fe710e8637644d461e9b581b6