[INFO] cloning repository https://github.com/LiptonB/nettap [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LiptonB/nettap" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLiptonB%2Fnettap", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLiptonB%2Fnettap'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 75cec1573fc843e3441d43a96904b809448932e7 [INFO] checking LiptonB/nettap/75cec1573fc843e3441d43a96904b809448932e7 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLiptonB%2Fnettap" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/LiptonB/nettap on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/LiptonB/nettap [INFO] finished tweaking git repo https://github.com/LiptonB/nettap [INFO] tweaked toml for git repo https://github.com/LiptonB/nettap written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/LiptonB/nettap already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 64f245669c9850e81de1cffd9ff954ee5d4e80876addddd79903be8d322e2fd0 [INFO] running `Command { std: "docker" "start" "-a" "64f245669c9850e81de1cffd9ff954ee5d4e80876addddd79903be8d322e2fd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "64f245669c9850e81de1cffd9ff954ee5d4e80876addddd79903be8d322e2fd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64f245669c9850e81de1cffd9ff954ee5d4e80876addddd79903be8d322e2fd0", kill_on_drop: false }` [INFO] [stdout] 64f245669c9850e81de1cffd9ff954ee5d4e80876addddd79903be8d322e2fd0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fc7c2f82214c0bb10c693a68c89795e8a7e4906ccc37cc6609667d94b4be5d54 [INFO] running `Command { std: "docker" "start" "-a" "fc7c2f82214c0bb10c693a68c89795e8a7e4906ccc37cc6609667d94b4be5d54", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.59 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Checking futures-core v0.3.12 [INFO] [stderr] Checking pin-project-lite v0.2.4 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling log v0.4.13 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking futures-sink v0.3.12 [INFO] [stderr] Compiling serde v1.0.121 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Checking tracing-core v0.1.17 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling tokio v1.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking regex-syntax v0.6.22 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking futures-channel v0.3.12 [INFO] [stderr] Checking futures-task v0.3.12 [INFO] [stderr] Checking parking_lot_core v0.8.2 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking mio v0.7.7 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling serde_json v1.0.61 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Checking futures-io v0.3.12 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking pin-project-lite v0.1.11 [INFO] [stderr] Compiling anyhow v1.0.38 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking tokio v0.2.24 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking tracing-log v0.1.1 [INFO] [stderr] Checking sharded-slab v0.1.1 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking regex v1.4.3 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking thread_local v1.1.1 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking tokio-test v0.2.1 [INFO] [stderr] Checking tracing-serde v0.1.2 [INFO] [stderr] Compiling structopt-derive v0.2.18 [INFO] [stderr] Checking structopt v0.2.18 [INFO] [stderr] Compiling tokio-macros v1.0.0 [INFO] [stderr] Compiling futures-macro v0.3.12 [INFO] [stderr] Compiling async-stream-impl v0.3.0 [INFO] [stderr] Compiling tracing-attributes v0.1.11 [INFO] [stderr] Checking async-stream v0.3.0 [INFO] [stderr] Checking tracing v0.1.22 [INFO] [stderr] Checking futures-util v0.3.12 [INFO] [stderr] Checking tracing-subscriber v0.2.15 [INFO] [stderr] Checking futures-executor v0.3.12 [INFO] [stderr] Checking futures v0.3.12 [INFO] [stderr] Checking tokio-stream v0.1.2 [INFO] [stderr] Checking tokio-util v0.6.2 [INFO] [stderr] Checking nettap v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `tokio::io::ReadHalf` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tokio_connection.rs:137:18 [INFO] [stdout] | [INFO] [stdout] 136 | pub async fn run(mut self) -> Result<()> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let (mut readstream, mut writestream) = io::split(self.stream); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 138 | let _ = tokio::try_join! { [INFO] [stdout] | _____________________- [INFO] [stdout] 139 | | io::copy(&mut self.reader, &mut writestream), [INFO] [stdout] 140 | | io::copy(&mut readstream, &mut self.writer), [INFO] [stdout] 141 | | }?; [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::io::ReadHalf` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/tokio_connection.rs:137:18 [INFO] [stdout] | [INFO] [stdout] 136 | pub async fn run(mut self) -> Result<()> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let (mut readstream, mut writestream) = io::split(self.stream); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 138 | let _ = tokio::try_join! { [INFO] [stdout] | _____________________- [INFO] [stdout] 139 | | io::copy(&mut self.reader, &mut writestream), [INFO] [stdout] 140 | | io::copy(&mut readstream, &mut self.writer), [INFO] [stdout] 141 | | }?; [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `futures::futures_channel::mpsc::UnboundedReceiver` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/coordinator.rs:97:21 [INFO] [stdout] | [INFO] [stdout] 97 | let (send1, mut recv1) = futures::channel::mpsc::unbounded(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 102 | let (_, _, _, data1, data2) = join!(conn1, conn2, coord.run(), recv1.next(), recv2.next()); [INFO] [stdout] | ------------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TokioConnection` is never constructed [INFO] [stdout] --> src/connection/tokio_connection.rs:102:16 [INFO] [stdout] | [INFO] [stdout] 102 | pub struct TokioConnection [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ConnectionData` is never constructed [INFO] [stdout] --> src/connection/tokio_connection.rs:112:16 [INFO] [stdout] | [INFO] [stdout] 112 | pub struct ConnectionData { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `run` are never used [INFO] [stdout] --> src/connection/tokio_connection.rs:121:16 [INFO] [stdout] | [INFO] [stdout] 116 | / impl TokioConnection [INFO] [stdout] 117 | | where [INFO] [stdout] 118 | | R: AsyncRead + Unpin, [INFO] [stdout] 119 | | W: AsyncWrite + Unpin, [INFO] [stdout] | |______________________________- associated items in this implementation [INFO] [stdout] 120 | { [INFO] [stdout] 121 | pub fn new(reader: R, writer: W) -> (Self, ConnectionData) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 136 | pub async fn run(mut self) -> Result<()> { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TokioConnection` is never constructed [INFO] [stdout] --> src/connection/tokio_connection.rs:102:16 [INFO] [stdout] | [INFO] [stdout] 102 | pub struct TokioConnection [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ConnectionData` is never constructed [INFO] [stdout] --> src/connection/tokio_connection.rs:112:16 [INFO] [stdout] | [INFO] [stdout] 112 | pub struct ConnectionData { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `run` are never used [INFO] [stdout] --> src/connection/tokio_connection.rs:121:16 [INFO] [stdout] | [INFO] [stdout] 116 | / impl TokioConnection [INFO] [stdout] 117 | | where [INFO] [stdout] 118 | | R: AsyncRead + Unpin, [INFO] [stdout] 119 | | W: AsyncWrite + Unpin, [INFO] [stdout] | |______________________________- associated items in this implementation [INFO] [stdout] 120 | { [INFO] [stdout] 121 | pub fn new(reader: R, writer: W) -> (Self, ConnectionData) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 136 | pub async fn run(mut self) -> Result<()> { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nettap` (bin "nettap" test) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nettap` (bin "nettap") due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fc7c2f82214c0bb10c693a68c89795e8a7e4906ccc37cc6609667d94b4be5d54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc7c2f82214c0bb10c693a68c89795e8a7e4906ccc37cc6609667d94b4be5d54", kill_on_drop: false }` [INFO] [stdout] fc7c2f82214c0bb10c693a68c89795e8a7e4906ccc37cc6609667d94b4be5d54