[INFO] cloning repository https://github.com/Jekahome/Data-Structures [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Jekahome/Data-Structures" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJekahome%2FData-Structures", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJekahome%2FData-Structures'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4e6e767382d523084437ef31bb42e38e620454fa [INFO] checking Jekahome/Data-Structures/4e6e767382d523084437ef31bb42e38e620454fa against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJekahome%2FData-Structures" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Jekahome/Data-Structures on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Jekahome/Data-Structures [INFO] finished tweaking git repo https://github.com/Jekahome/Data-Structures [INFO] tweaked toml for git repo https://github.com/Jekahome/Data-Structures written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Jekahome/Data-Structures already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0901d29b4d18ea7b407a06a2ac13f1309bd4544db08a7216aea7d02ae21ae4c0 [INFO] running `Command { std: "docker" "start" "-a" "0901d29b4d18ea7b407a06a2ac13f1309bd4544db08a7216aea7d02ae21ae4c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0901d29b4d18ea7b407a06a2ac13f1309bd4544db08a7216aea7d02ae21ae4c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0901d29b4d18ea7b407a06a2ac13f1309bd4544db08a7216aea7d02ae21ae4c0", kill_on_drop: false }` [INFO] [stdout] 0901d29b4d18ea7b407a06a2ac13f1309bd4544db08a7216aea7d02ae21ae4c0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 63fa3a7c84d122a86999a3da22a3195972f5d2d79c46dfb42c2bc7cdb6483630 [INFO] running `Command { std: "docker" "start" "-a" "63fa3a7c84d122a86999a3da22a3195972f5d2d79c46dfb42c2bc7cdb6483630", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking ds v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `btree::*` [INFO] [stdout] --> src/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub use btree::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | mod graph; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `graph` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | pub use graph::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | mod graph; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `heap::*` [INFO] [stdout] --> src/lib.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub use heap::*; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `map::*` [INFO] [stdout] --> src/lib.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub use map::*; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `set::*` [INFO] [stdout] --> src/lib.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | pub use set::*; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `trie::*` [INFO] [stdout] --> src/lib.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | pub use trie::*; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `btree::*` [INFO] [stdout] --> src/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub use btree::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | mod graph; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `graph` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | pub use graph::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | mod graph; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `heap::*` [INFO] [stdout] --> src/lib.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub use heap::*; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `map::*` [INFO] [stdout] --> src/lib.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub use map::*; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `set::*` [INFO] [stdout] --> src/lib.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | pub use set::*; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `trie::*` [INFO] [stdout] --> src/lib.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | pub use trie::*; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/red_black_tree/red_black_tree_vec.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 85 | unimplemented!(); [INFO] [stdout] | ---------------- any code following this expression is unreachable [INFO] [stdout] 86 | self.nodes.iter().map(|v|v.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/red_black_tree/red_black_tree_vec.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 85 | unimplemented!(); [INFO] [stdout] | ---------------- any code following this expression is unreachable [INFO] [stdout] 86 | self.nodes.iter().map(|v|v.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/red_black_tree/red_black_tree_vec.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 71 | unimplemented!(); [INFO] [stdout] | ---------------- any code following this expression is unreachable [INFO] [stdout] ... [INFO] [stdout] 80 | None [INFO] [stdout] | ^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, binary_tree_rc::Node>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_tree/binary_tree_rc.rs:214:32 [INFO] [stdout] | [INFO] [stdout] 213 | fn replace_node(&mut self, node: &NodeLink, r: Option) { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | if let Some(parent) = &node.borrow().parent { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/red_black_tree/red_black_tree_vec.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 71 | unimplemented!(); [INFO] [stdout] | ---------------- any code following this expression is unreachable [INFO] [stdout] ... [INFO] [stdout] 80 | None [INFO] [stdout] | ^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, binary_search_tree_rcrefcell::Node>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_search_tree/binary_search_tree_rcrefcell.rs:211:32 [INFO] [stdout] | [INFO] [stdout] 210 | fn replace_node(&mut self, node: &NodeLink, r: Option) { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | if let Some(parent) = &node.borrow().parent { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `weight` [INFO] [stdout] --> src/graph/simple_directed_weighted_sparse_graph.rs:246:22 [INFO] [stdout] | [INFO] [stdout] 246 | for (weight, to_vertex) in from_to { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_weight` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/red_black_tree/red_black_tree_vec.rs:70:46 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn successor_dfs_in_order(&self, value: T) -> Option<&T> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `depth_first_get_values` is never used [INFO] [stdout] --> src/binary_search_tree/binary_search_tree_good_nonnull.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 29 | impl Tree { [INFO] [stdout] | --------------------------------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 74 | fn depth_first_get_values(&self, start_node: Link) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_node_checked` is never used [INFO] [stdout] --> src/red_black_tree/red_black_tree_vec.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl Tree { [INFO] [stdout] | --------------------------------------------------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 115 | fn get_node_checked(&self, index: &IndexNode) -> Option<&Node> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ds` (lib) due to 3 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Ref<'_, binary_tree_rc::Node>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_tree/binary_tree_rc.rs:214:32 [INFO] [stdout] | [INFO] [stdout] 213 | fn replace_node(&mut self, node: &NodeLink, r: Option) { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | if let Some(parent) = &node.borrow().parent { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, binary_search_tree_rcrefcell::Node>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_search_tree/binary_search_tree_rcrefcell.rs:211:32 [INFO] [stdout] | [INFO] [stdout] 210 | fn replace_node(&mut self, node: &NodeLink, r: Option) { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | if let Some(parent) = &node.borrow().parent { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `weight` [INFO] [stdout] --> src/graph/simple_directed_weighted_sparse_graph.rs:246:22 [INFO] [stdout] | [INFO] [stdout] 246 | for (weight, to_vertex) in from_to { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_weight` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/red_black_tree/red_black_tree_vec.rs:70:46 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn successor_dfs_in_order(&self, value: T) -> Option<&T> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `nodes` [INFO] [stdout] --> src/red_black_tree/rb_tree.rs:626:13 [INFO] [stdout] | [INFO] [stdout] 626 | let nodes: Vec = vec![5, 4, 6]; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_nodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `depth_first_get_values` is never used [INFO] [stdout] --> src/binary_search_tree/binary_search_tree_good_nonnull.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 29 | impl Tree { [INFO] [stdout] | --------------------------------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 74 | fn depth_first_get_values(&self, start_node: Link) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_node_checked` is never used [INFO] [stdout] --> src/red_black_tree/red_black_tree_vec.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl Tree { [INFO] [stdout] | --------------------------------------------------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 115 | fn get_node_checked(&self, index: &IndexNode) -> Option<&Node> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ds` (lib test) due to 3 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "63fa3a7c84d122a86999a3da22a3195972f5d2d79c46dfb42c2bc7cdb6483630", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63fa3a7c84d122a86999a3da22a3195972f5d2d79c46dfb42c2bc7cdb6483630", kill_on_drop: false }` [INFO] [stdout] 63fa3a7c84d122a86999a3da22a3195972f5d2d79c46dfb42c2bc7cdb6483630