[INFO] cloning repository https://github.com/Hamzakh777/rust-tokio [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Hamzakh777/rust-tokio" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHamzakh777%2Frust-tokio", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHamzakh777%2Frust-tokio'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] eb98955d5d6e58d4568c6d1f9221dbdf763b6c32 [INFO] checking Hamzakh777/rust-tokio/eb98955d5d6e58d4568c6d1f9221dbdf763b6c32 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FHamzakh777%2Frust-tokio" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Hamzakh777/rust-tokio on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Hamzakh777/rust-tokio [INFO] finished tweaking git repo https://github.com/Hamzakh777/rust-tokio [INFO] tweaked toml for git repo https://github.com/Hamzakh777/rust-tokio written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Hamzakh777/rust-tokio already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b3398521d66252c8298dd20a34eb1ecce75df2a1d411018678e004349dbd87fb [INFO] running `Command { std: "docker" "start" "-a" "b3398521d66252c8298dd20a34eb1ecce75df2a1d411018678e004349dbd87fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b3398521d66252c8298dd20a34eb1ecce75df2a1d411018678e004349dbd87fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3398521d66252c8298dd20a34eb1ecce75df2a1d411018678e004349dbd87fb", kill_on_drop: false }` [INFO] [stdout] b3398521d66252c8298dd20a34eb1ecce75df2a1d411018678e004349dbd87fb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c5f9c59108704573839f9de823a04658f3d4e83fcf051df0ec51181606ccf105 [INFO] running `Command { std: "docker" "start" "-a" "c5f9c59108704573839f9de823a04658f3d4e83fcf051df0ec51181606ccf105", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling unicode-segmentation v1.10.1 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking parking_lot_core v0.9.8 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking socket2 v0.5.3 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Checking regex-automata v0.3.7 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking chrono v0.4.27 [INFO] [stderr] Checking atoi v0.3.3 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking regex v1.9.4 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Compiling tracing-attributes v0.1.26 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking mini-redis v0.4.1 [INFO] [stderr] Checking rust-tokio v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/connection.rs:126:13 [INFO] [stdout] | [INFO] [stdout] 125 | Err(_) => Ok(None), [INFO] [stdout] | ------ matches all the relevant values [INFO] [stdout] 126 | Err(e) => Err(e.into()), [INFO] [stdout] | ^^^^^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stream` [INFO] [stdout] --> src/connection.rs:135:14 [INFO] [stdout] | [INFO] [stdout] 135 | let (stream, socket) = listener.accept().await?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `socket` [INFO] [stdout] --> src/connection.rs:135:22 [INFO] [stdout] | [INFO] [stdout] 135 | let (stream, socket) = listener.accept().await?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_socket` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buffer` [INFO] [stdout] --> src/connection.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | let mut buffer: [u8; 1024] = [0; 1024]; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_buffer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/connection.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | let mut buffer: [u8; 1024] = [0; 1024]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Connection` is never constructed [INFO] [stdout] --> src/connection.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | struct Connection { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `read_frame`, `write_frame`, `write_decimal`, and `parse_frame` are never used [INFO] [stdout] --> src/connection.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 12 | impl Connection { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 13 | pub fn new(stream: TcpStream) -> Connection { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | pub async fn read_frame(&mut self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | pub async fn write_frame(&mut self, frame: &Frame) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 93 | async fn write_decimal(&mut self, val: u64) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 108 | fn parse_frame(&mut self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/connection.rs:132:10 [INFO] [stdout] | [INFO] [stdout] 132 | async fn main() -> Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/connection.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | self.stream.flush().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 87 | let _ = self.stream.flush().await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `State0` is never constructed [INFO] [stdout] --> src/bin/async_intro.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 36 | enum MainFuture { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 37 | // Initialized, never polled [INFO] [stdout] 38 | State0, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::MutexGuard<'_, HashMap>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/server.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 20 | async fn process(socket: TcpStream, db: Arc>>) { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | use mini_redis::Command::{self, Get, Set}; [INFO] [stdout] 22 | let mut db = db.lock().await; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `State0` is never constructed [INFO] [stdout] --> src/bin/async_intro.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 36 | enum MainFuture { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 37 | // Initialized, never polled [INFO] [stdout] 38 | State0, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::MutexGuard<'_, HashMap>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/server.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 20 | async fn process(socket: TcpStream, db: Arc>>) { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | use mini_redis::Command::{self, Get, Set}; [INFO] [stdout] 22 | let mut db = db.lock().await; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-tokio` (bin "server") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-tokio` (bin "server" test) due to 2 previous errors [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/connection.rs:126:13 [INFO] [stdout] | [INFO] [stdout] 125 | Err(_) => Ok(None), [INFO] [stdout] | ------ matches all the relevant values [INFO] [stdout] 126 | Err(e) => Err(e.into()), [INFO] [stdout] | ^^^^^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stream` [INFO] [stdout] --> src/connection.rs:135:14 [INFO] [stdout] | [INFO] [stdout] 135 | let (stream, socket) = listener.accept().await?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `socket` [INFO] [stdout] --> src/connection.rs:135:22 [INFO] [stdout] | [INFO] [stdout] 135 | let (stream, socket) = listener.accept().await?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_socket` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buffer` [INFO] [stdout] --> src/connection.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | let mut buffer: [u8; 1024] = [0; 1024]; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_buffer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/connection.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | let mut buffer: [u8; 1024] = [0; 1024]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Connection` is never constructed [INFO] [stdout] --> src/connection.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | struct Connection { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `read_frame`, `write_frame`, `write_decimal`, and `parse_frame` are never used [INFO] [stdout] --> src/connection.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 12 | impl Connection { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 13 | pub fn new(stream: TcpStream) -> Connection { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | pub async fn read_frame(&mut self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | pub async fn write_frame(&mut self, frame: &Frame) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 93 | async fn write_decimal(&mut self, val: u64) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 108 | fn parse_frame(&mut self) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/connection.rs:132:10 [INFO] [stdout] | [INFO] [stdout] 132 | async fn main() -> Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/connection.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | self.stream.flush().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 87 | let _ = self.stream.flush().await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "c5f9c59108704573839f9de823a04658f3d4e83fcf051df0ec51181606ccf105", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5f9c59108704573839f9de823a04658f3d4e83fcf051df0ec51181606ccf105", kill_on_drop: false }` [INFO] [stdout] c5f9c59108704573839f9de823a04658f3d4e83fcf051df0ec51181606ccf105