[INFO] cloning repository https://github.com/DeveloperGY/rust_engine_test [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DeveloperGY/rust_engine_test" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDeveloperGY%2Frust_engine_test", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDeveloperGY%2Frust_engine_test'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7b71b124739bb398607dadca6204e9231f5b78ca [INFO] checking DeveloperGY/rust_engine_test/7b71b124739bb398607dadca6204e9231f5b78ca against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDeveloperGY%2Frust_engine_test" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DeveloperGY/rust_engine_test on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DeveloperGY/rust_engine_test [INFO] finished tweaking git repo https://github.com/DeveloperGY/rust_engine_test [INFO] tweaked toml for git repo https://github.com/DeveloperGY/rust_engine_test written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DeveloperGY/rust_engine_test already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c788210fc8c5d5876541e3839c0ffcf9d044cf4ecd10b745a36118f2f596385a [INFO] running `Command { std: "docker" "start" "-a" "c788210fc8c5d5876541e3839c0ffcf9d044cf4ecd10b745a36118f2f596385a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c788210fc8c5d5876541e3839c0ffcf9d044cf4ecd10b745a36118f2f596385a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c788210fc8c5d5876541e3839c0ffcf9d044cf4ecd10b745a36118f2f596385a", kill_on_drop: false }` [INFO] [stdout] c788210fc8c5d5876541e3839c0ffcf9d044cf4ecd10b745a36118f2f596385a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9b91789a501fd030b7f95cfeb5d3c0ae9a1168fe6b9e76fedd49ad52a9abb987 [INFO] running `Command { std: "docker" "start" "-a" "9b91789a501fd030b7f95cfeb5d3c0ae9a1168fe6b9e76fedd49ad52a9abb987", kill_on_drop: false }` [INFO] [stderr] Checking engine v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `MutexGuard<'_, HashMap>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecs/component.rs:87:26 [INFO] [stdout] | [INFO] [stdout] 85 | component: C, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | ) -> Result<(), Error> { [INFO] [stdout] 87 | if let Some(v) = self.components.lock().unwrap().get(&TypeId::of::()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scene/mod.rs:262:30 [INFO] [stdout] | [INFO] [stdout] 261 | pub fn swap_scenes(&self, engine: Arc) { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | if let Some(scene) = self.next_scene.lock().unwrap().take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/mod.rs:115:28 [INFO] [stdout] | [INFO] [stdout] 114 | let mut queue = self.queue.lock().unwrap(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | if let Some(job) = queue.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, HashMap>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecs/component.rs:87:26 [INFO] [stdout] | [INFO] [stdout] 85 | component: C, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | ) -> Result<(), Error> { [INFO] [stdout] 87 | if let Some(v) = self.components.lock().unwrap().get(&TypeId::of::()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `as_any` and `clear` are never used [INFO] [stdout] --> src/ecs/component.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 38 | trait ComponentArray { [INFO] [stdout] | -------------- methods in this trait [INFO] [stdout] 39 | fn as_any(&self) -> &dyn Any; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 40 | fn as_any_mut(&mut self) -> &mut dyn Any; [INFO] [stdout] 41 | fn clear(&mut self); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `engine` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `MutexGuard<'_, Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scene/mod.rs:262:30 [INFO] [stdout] | [INFO] [stdout] 261 | pub fn swap_scenes(&self, engine: Arc) { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | if let Some(scene) = self.next_scene.lock().unwrap().take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/mod.rs:115:28 [INFO] [stdout] | [INFO] [stdout] 114 | let mut queue = self.queue.lock().unwrap(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | if let Some(job) = queue.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `as_any` and `clear` are never used [INFO] [stdout] --> src/ecs/component.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 38 | trait ComponentArray { [INFO] [stdout] | -------------- methods in this trait [INFO] [stdout] 39 | fn as_any(&self) -> &dyn Any; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 40 | fn as_any_mut(&mut self) -> &mut dyn Any; [INFO] [stdout] 41 | fn clear(&mut self); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `engine` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "9b91789a501fd030b7f95cfeb5d3c0ae9a1168fe6b9e76fedd49ad52a9abb987", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b91789a501fd030b7f95cfeb5d3c0ae9a1168fe6b9e76fedd49ad52a9abb987", kill_on_drop: false }` [INFO] [stdout] 9b91789a501fd030b7f95cfeb5d3c0ae9a1168fe6b9e76fedd49ad52a9abb987