[INFO] cloning repository https://github.com/Dentosal/factory [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Dentosal/factory" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDentosal%2Ffactory", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDentosal%2Ffactory'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f7d445ea41d298dde69509cdd83fe39c30b92dda [INFO] checking Dentosal/factory/f7d445ea41d298dde69509cdd83fe39c30b92dda against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDentosal%2Ffactory" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Dentosal/factory on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Dentosal/factory [INFO] finished tweaking git repo https://github.com/Dentosal/factory [INFO] tweaked toml for git repo https://github.com/Dentosal/factory written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Dentosal/factory already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0b287191b067d8005a9a57feece13e9e3004406f923e63b2943fbc1008c4c103 [INFO] running `Command { std: "docker" "start" "-a" "0b287191b067d8005a9a57feece13e9e3004406f923e63b2943fbc1008c4c103", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0b287191b067d8005a9a57feece13e9e3004406f923e63b2943fbc1008c4c103", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b287191b067d8005a9a57feece13e9e3004406f923e63b2943fbc1008c4c103", kill_on_drop: false }` [INFO] [stdout] 0b287191b067d8005a9a57feece13e9e3004406f923e63b2943fbc1008c4c103 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c6155090f82e12a095f354f4036c11ac5d997071e4959b312b67c0dd1c2f62d [INFO] running `Command { std: "docker" "start" "-a" "5c6155090f82e12a095f354f4036c11ac5d997071e4959b312b67c0dd1c2f62d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.6 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling serde v1.0.101 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling itoa v0.4.4 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling unindent v0.1.5 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Compiling unicode-segmentation v1.5.0 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking termcolor v1.0.5 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking paw-raw v1.0.0 [INFO] [stderr] Checking number_prefix v0.3.0 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Compiling aho-corasick v0.7.6 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Checking clicolors-control v1.0.1 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking terminal_size v0.1.8 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking chrono v0.4.9 [INFO] [stderr] Compiling regex v1.3.1 [INFO] [stderr] Checking console v0.9.1 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking pretty_env_logger v0.3.1 [INFO] [stderr] Checking indicatif v0.13.0 [INFO] [stderr] Compiling pyo3-derive-backend v0.8.3 [INFO] [stderr] Compiling proc-macro-error v0.2.6 [INFO] [stderr] Compiling serde_derive v1.0.101 [INFO] [stderr] Compiling proc-macro-hack v0.5.11 [INFO] [stderr] Compiling ghost v0.1.1 [INFO] [stderr] Compiling inventory-impl v0.1.4 [INFO] [stderr] Compiling ctor v0.1.12 [INFO] [stderr] Compiling structopt-derive v0.3.3 [INFO] [stderr] Compiling paw-attributes v1.0.2 [INFO] [stderr] Checking paw v1.0.0 [INFO] [stderr] Checking inventory v0.1.4 [INFO] [stderr] Compiling paste-impl v0.1.6 [INFO] [stderr] Compiling indoc-impl v0.3.4 [INFO] [stderr] Checking structopt v0.3.3 [INFO] [stderr] Compiling pyo3cls v0.8.3 [INFO] [stderr] Checking indoc v0.3.4 [INFO] [stderr] Checking paste v0.1.6 [INFO] [stderr] Checking toml v0.5.3 [INFO] [stderr] Checking serde_json v1.0.41 [INFO] [stderr] Compiling pyo3 v0.8.3 [INFO] [stderr] Checking factory v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/config_file.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Deserialize, StructOpt, Default)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_ExecConfig` [INFO] [stdout] ... [INFO] [stdout] 9 | pub struct ExecConfig { [INFO] [stdout] | ---------- `ExecConfig` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/config_file.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Deserialize, StructOpt, Default)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_ExecConfig` [INFO] [stdout] ... [INFO] [stdout] 9 | pub struct ExecConfig { [INFO] [stdout] | ---------- `ExecConfig` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:73:11 [INFO] [stdout] | [INFO] [stdout] 41 | let gil = Python::acquire_gil(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let (steps, cfg_dict) = factory::config::read(py, &args.exec) [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | match factory::run(py, &steps, &target_name, cfg_dict, &args.exec, py_factory) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:73:11 [INFO] [stdout] | [INFO] [stdout] 41 | let gil = Python::acquire_gil(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let (steps, cfg_dict) = factory::config::read(py, &args.exec) [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | match factory::run(py, &steps, &target_name, cfg_dict, &args.exec, py_factory) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `factory` (bin "factory") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `factory` (bin "factory" test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "5c6155090f82e12a095f354f4036c11ac5d997071e4959b312b67c0dd1c2f62d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c6155090f82e12a095f354f4036c11ac5d997071e4959b312b67c0dd1c2f62d", kill_on_drop: false }` [INFO] [stdout] 5c6155090f82e12a095f354f4036c11ac5d997071e4959b312b67c0dd1c2f62d