[INFO] cloning repository https://github.com/CreativeWolfies/patpat.rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/CreativeWolfies/patpat.rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCreativeWolfies%2Fpatpat.rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCreativeWolfies%2Fpatpat.rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9675e5ca04bc38a8723721301ffeb618fec12ab7 [INFO] checking CreativeWolfies/patpat.rs/9675e5ca04bc38a8723721301ffeb618fec12ab7 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCreativeWolfies%2Fpatpat.rs" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/CreativeWolfies/patpat.rs on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/CreativeWolfies/patpat.rs [INFO] finished tweaking git repo https://github.com/CreativeWolfies/patpat.rs [INFO] tweaked toml for git repo https://github.com/CreativeWolfies/patpat.rs written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/CreativeWolfies/patpat.rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f75450956eafcf569425b8138f4aeaa9c9b83b85d76a23dd5f23f68babd62b55 [INFO] running `Command { std: "docker" "start" "-a" "f75450956eafcf569425b8138f4aeaa9c9b83b85d76a23dd5f23f68babd62b55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f75450956eafcf569425b8138f4aeaa9c9b83b85d76a23dd5f23f68babd62b55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f75450956eafcf569425b8138f4aeaa9c9b83b85d76a23dd5f23f68babd62b55", kill_on_drop: false }` [INFO] [stdout] f75450956eafcf569425b8138f4aeaa9c9b83b85d76a23dd5f23f68babd62b55 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9ef4aeb3bd365d350c5127af952a3b4ff51557c91f41db9d9fc579d5baca8b78 [INFO] running `Command { std: "docker" "start" "-a" "9ef4aeb3bd365d350c5127af952a3b4ff51557c91f41db9d9fc579d5baca8b78", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling serde v1.0.111 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking rusty_ulid v0.9.3 [INFO] [stderr] Checking patpat v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/ast/resolve/mod.rs:51:37 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn resolve<'a>(ast: AST<'a>) -> RASTRef { [INFO] [stdout] | -- ^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'a` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/ast/resolve/mod.rs:51:37 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn resolve<'a>(ast: AST<'a>) -> RASTRef { [INFO] [stdout] | -- ^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'a` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/resolve/lookup.rs:24:11 [INFO] [stdout] | [INFO] [stdout] 12 | current: RASTRef<'a>, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | match current.borrow().parent.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/resolve/lookup.rs:56:11 [INFO] [stdout] | [INFO] [stdout] 49 | parent: RASTWeak<'a>, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | match parent.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/resolve/lookup.rs:88:11 [INFO] [stdout] | [INFO] [stdout] 81 | parent: RASTWeak<'a>, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | match parent.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `resolve::node::RASTNode<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/resolve/mod.rs:245:21 [INFO] [stdout] | [INFO] [stdout] 133 | res: RASTRef<'a>, [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let parent = res.borrow().parent.clone(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | let expr = [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::rc::Rc>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter/callable.rs:124:45 [INFO] [stdout] | [INFO] [stdout] 71 | parent: Option>, [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let mut init_ctx = Context::from(self.body.clone()); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | if let Some(VariableValue::Type(type_raw)) = parent { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, resolve::RAST<'_>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter/context.rs:25:20 [INFO] [stdout] | [INFO] [stdout] 17 | fn from(ast: RASTRef<'a>) -> Context<'a> { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | depth: ast.borrow().depth, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `value::VariableValue<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter/expr.rs:326:26 [INFO] [stdout] | [INFO] [stdout] 320 | a: ExprValue<'a>, [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | b: ExprValue<'a>, [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | ExprValue::Value(a_val) => match b { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, HashMap>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter/expr.rs:348:5 [INFO] [stdout] | [INFO] [stdout] 347 | fn resolve_access<'a>(obj: InstanceRef<'a>, name: String) -> VariableValue<'a> { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | obj.borrow() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, resolve::RAST<'_>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter/mod.rs:23:49 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn interprete<'a>(ast: RASTRef<'a>, contexes: Vec>) -> VariableValue<'a> { [INFO] [stdout] | --- -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | //! Interpretes an `RAST` block [INFO] [stdout] 19 | let mut contexes = contexes.clone(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | contexes.push(Rc::new(RefCell::new(Context::from(ast.clone())))); [INFO] [stdout] 21 | let mut last_value: VariableValue = VariableValue::Nil; [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | [INFO] [stdout] 23 | if let ASTKind::Tuple | ASTKind::ArgTuple = ast.borrow().kind { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `value::VariableValue<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal/mod.rs:210:48 [INFO] [stdout] | [INFO] [stdout] 209 | let mut iter = args.into_iter(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | if let VariableValue::Tuple(mut vec) = iter.next().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/error.rs:60:24 [INFO] [stdout] | [INFO] [stdout] 60 | panic!(self.infos.remove(0).msg) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 60 | panic!("{}", self.infos.remove(0).msg) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/error.rs:202:35 [INFO] [stdout] | [INFO] [stdout] 202 | CompLocation::Char(loc.src.clone(), loc.line, loc.ch) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/parser/mod.rs:51:36 [INFO] [stdout] | [INFO] [stdout] 51 | let mut trimmed_line = line.clone(); // a copy of the line, which progressively gets trimmed [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `patpat` (lib test) due to 11 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/resolve/lookup.rs:24:11 [INFO] [stdout] | [INFO] [stdout] 12 | current: RASTRef<'a>, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | match current.borrow().parent.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/resolve/lookup.rs:56:11 [INFO] [stdout] | [INFO] [stdout] 49 | parent: RASTWeak<'a>, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | match parent.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/resolve/lookup.rs:88:11 [INFO] [stdout] | [INFO] [stdout] 81 | parent: RASTWeak<'a>, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | match parent.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `resolve::node::RASTNode<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/resolve/mod.rs:245:21 [INFO] [stdout] | [INFO] [stdout] 133 | res: RASTRef<'a>, [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let parent = res.borrow().parent.clone(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | let expr = [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::rc::Rc>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter/callable.rs:124:45 [INFO] [stdout] | [INFO] [stdout] 71 | parent: Option>, [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let mut init_ctx = Context::from(self.body.clone()); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | if let Some(VariableValue::Type(type_raw)) = parent { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, resolve::RAST<'_>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter/context.rs:25:20 [INFO] [stdout] | [INFO] [stdout] 17 | fn from(ast: RASTRef<'a>) -> Context<'a> { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | depth: ast.borrow().depth, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `value::VariableValue<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter/expr.rs:326:26 [INFO] [stdout] | [INFO] [stdout] 320 | a: ExprValue<'a>, [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | b: ExprValue<'a>, [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | ExprValue::Value(a_val) => match b { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, HashMap>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter/expr.rs:348:5 [INFO] [stdout] | [INFO] [stdout] 347 | fn resolve_access<'a>(obj: InstanceRef<'a>, name: String) -> VariableValue<'a> { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | obj.borrow() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, resolve::RAST<'_>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter/mod.rs:23:49 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn interprete<'a>(ast: RASTRef<'a>, contexes: Vec>) -> VariableValue<'a> { [INFO] [stdout] | --- -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | //! Interpretes an `RAST` block [INFO] [stdout] 19 | let mut contexes = contexes.clone(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | contexes.push(Rc::new(RefCell::new(Context::from(ast.clone())))); [INFO] [stdout] 21 | let mut last_value: VariableValue = VariableValue::Nil; [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | [INFO] [stdout] 23 | if let ASTKind::Tuple | ASTKind::ArgTuple = ast.borrow().kind { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `value::VariableValue<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal/mod.rs:210:48 [INFO] [stdout] | [INFO] [stdout] 209 | let mut iter = args.into_iter(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | if let VariableValue::Tuple(mut vec) = iter.next().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/error.rs:60:24 [INFO] [stdout] | [INFO] [stdout] 60 | panic!(self.infos.remove(0).msg) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 60 | panic!("{}", self.infos.remove(0).msg) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/error.rs:202:35 [INFO] [stdout] | [INFO] [stdout] 202 | CompLocation::Char(loc.src.clone(), loc.line, loc.ch) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/parser/mod.rs:51:36 [INFO] [stdout] | [INFO] [stdout] 51 | let mut trimmed_line = line.clone(); // a copy of the line, which progressively gets trimmed [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `patpat` (lib) due to 11 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9ef4aeb3bd365d350c5127af952a3b4ff51557c91f41db9d9fc579d5baca8b78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ef4aeb3bd365d350c5127af952a3b4ff51557c91f41db9d9fc579d5baca8b78", kill_on_drop: false }` [INFO] [stdout] 9ef4aeb3bd365d350c5127af952a3b4ff51557c91f41db9d9fc579d5baca8b78