[INFO] cloning repository https://github.com/Cobord/israeli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Cobord/israeli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCobord%2Fisraeli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCobord%2Fisraeli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d116f0c3464b3ef3d29e869e37678e2d327114e0 [INFO] checking Cobord/israeli/d116f0c3464b3ef3d29e869e37678e2d327114e0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCobord%2Fisraeli" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Cobord/israeli on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Cobord/israeli [INFO] finished tweaking git repo https://github.com/Cobord/israeli [INFO] tweaked toml for git repo https://github.com/Cobord/israeli written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Cobord/israeli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: dependencies.petgraph.feature [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3ff73fb8aeae6b6ceb9ea8b0032b2c2b834a42679454c5d0de9ad095a39ca22c [INFO] running `Command { std: "docker" "start" "-a" "3ff73fb8aeae6b6ceb9ea8b0032b2c2b834a42679454c5d0de9ad095a39ca22c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3ff73fb8aeae6b6ceb9ea8b0032b2c2b834a42679454c5d0de9ad095a39ca22c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ff73fb8aeae6b6ceb9ea8b0032b2c2b834a42679454c5d0de9ad095a39ca22c", kill_on_drop: false }` [INFO] [stdout] 3ff73fb8aeae6b6ceb9ea8b0032b2c2b834a42679454c5d0de9ad095a39ca22c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f8c8bc86d9e5f87852549e6a159733d15760a96bfcb72f2e6a9634ee86147df1 [INFO] running `Command { std: "docker" "start" "-a" "f8c8bc86d9e5f87852549e6a159733d15760a96bfcb72f2e6a9634ee86147df1", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: dependencies.petgraph.feature [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking nonempty v0.10.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking priority-queue v2.0.2 [INFO] [stderr] Checking israeli_queue_etc v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/nested_queue.rs:21:53 [INFO] [stdout] | [INFO] [stdout] 21 | fn values<'a>(&'a self) -> impl Iterator [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/nested_queue.rs:51:53 [INFO] [stdout] | [INFO] [stdout] 51 | fn values<'a>(&'a self) -> impl Iterator [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/nested_queue.rs:113:53 [INFO] [stdout] | [INFO] [stdout] 113 | fn values<'a>(&'a self) -> impl Iterator [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/nested_queue.rs:21:53 [INFO] [stdout] | [INFO] [stdout] 21 | fn values<'a>(&'a self) -> impl Iterator [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/nested_queue.rs:51:53 [INFO] [stdout] | [INFO] [stdout] 51 | fn values<'a>(&'a self) -> impl Iterator [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/nested_queue.rs:113:53 [INFO] [stdout] | [INFO] [stdout] 113 | fn values<'a>(&'a self) -> impl Iterator [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `P` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/israeli_priority.rs:137:36 [INFO] [stdout] | [INFO] [stdout] 133 | fn my_enqueue(&mut self, new_obj: T, new_obj_priority: P) { [INFO] [stdout] | ------- ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let my_shibboleth = new_obj.friendship_shibboleth(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let (priority_changed, new_priority) = [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/israeli_priority.rs:183:34 [INFO] [stdout] | [INFO] [stdout] 182 | fn enqueue_batch(&mut self, new_batch: impl IntoIterator, new_batch_priority: P) { [INFO] [stdout] | ------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | if let Some(new_batch) = NonEmpty::from_vec(new_batch.into_iter().collect()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(H, P)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/israeli_priority.rs:249:17 [INFO] [stdout] | [INFO] [stdout] 239 | let taken_current_friend_group = self.current_friend_group.take(); [INFO] [stdout] | -------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | let new_head_group_shibboleth = self.underlying.pop(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `P` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/israeli_priority.rs:137:36 [INFO] [stdout] | [INFO] [stdout] 133 | fn my_enqueue(&mut self, new_obj: T, new_obj_priority: P) { [INFO] [stdout] | ------- ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let my_shibboleth = new_obj.friendship_shibboleth(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let (priority_changed, new_priority) = [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/israeli_priority.rs:183:34 [INFO] [stdout] | [INFO] [stdout] 182 | fn enqueue_batch(&mut self, new_batch: impl IntoIterator, new_batch_priority: P) { [INFO] [stdout] | ------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | if let Some(new_batch) = NonEmpty::from_vec(new_batch.into_iter().collect()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(H, P)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/israeli_priority.rs:249:17 [INFO] [stdout] | [INFO] [stdout] 239 | let taken_current_friend_group = self.current_friend_group.take(); [INFO] [stdout] | -------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | let new_head_group_shibboleth = self.underlying.pop(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `israeli_queue_etc` (bin "israeli_queue_etc") due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `israeli_queue_etc` (bin "israeli_queue_etc" test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f8c8bc86d9e5f87852549e6a159733d15760a96bfcb72f2e6a9634ee86147df1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f8c8bc86d9e5f87852549e6a159733d15760a96bfcb72f2e6a9634ee86147df1", kill_on_drop: false }` [INFO] [stdout] f8c8bc86d9e5f87852549e6a159733d15760a96bfcb72f2e6a9634ee86147df1