[INFO] cloning repository https://github.com/Beirdo/rustcoinbase [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Beirdo/rustcoinbase" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBeirdo%2Frustcoinbase", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBeirdo%2Frustcoinbase'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 65bdc847b906c05874fe595956cb47e28f49b068 [INFO] checking Beirdo/rustcoinbase/65bdc847b906c05874fe595956cb47e28f49b068 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBeirdo%2Frustcoinbase" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Beirdo/rustcoinbase on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Beirdo/rustcoinbase [INFO] finished tweaking git repo https://github.com/Beirdo/rustcoinbase [INFO] tweaked toml for git repo https://github.com/Beirdo/rustcoinbase written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Beirdo/rustcoinbase already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1d540271c52077b5e5a16a74514b8fc579f95f211183c33c0bac81c07efe8b4a [INFO] running `Command { std: "docker" "start" "-a" "1d540271c52077b5e5a16a74514b8fc579f95f211183c33c0bac81c07efe8b4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1d540271c52077b5e5a16a74514b8fc579f95f211183c33c0bac81c07efe8b4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d540271c52077b5e5a16a74514b8fc579f95f211183c33c0bac81c07efe8b4a", kill_on_drop: false }` [INFO] [stdout] 1d540271c52077b5e5a16a74514b8fc579f95f211183c33c0bac81c07efe8b4a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c691de6cecea4512a9b413a682d4920d036e864c74cc53624cce2f348effa0b [INFO] running `Command { std: "docker" "start" "-a" "4c691de6cecea4512a9b413a682d4920d036e864c74cc53624cce2f348effa0b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling syn v1.0.80 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling futures-core v0.3.17 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Checking futures-sink v0.3.17 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling futures-macro v0.3.17 [INFO] [stderr] Compiling futures-task v0.3.17 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling futures-channel v0.3.17 [INFO] [stderr] Compiling tokio v1.12.0 [INFO] [stderr] Compiling futures-util v0.3.17 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking slab v0.4.4 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking futures-io v0.3.17 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling serde_json v1.0.68 [INFO] [stderr] Compiling async-trait v0.1.51 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tracing-core v0.1.21 [INFO] [stderr] Compiling num-bigint v0.4.2 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling cc v1.0.71 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling zstd-safe v4.1.1+zstd.1.5.0 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling zstd-sys v1.6.1+zstd.1.5.0 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Checking sharded-slab v0.1.3 [INFO] [stderr] Checking instant v0.1.11 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Checking half v1.7.1 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling anyhow v1.0.44 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking parking_lot_core v0.8.5 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking integer-encoding v1.1.7 [INFO] [stderr] Checking serde v0.8.23 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking thrift v0.13.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking rust-ini v0.13.0 [INFO] [stderr] Checking os_str_bytes v3.1.0 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Checking simplelog v0.10.2 [INFO] [stderr] Checking cidr v0.2.1 [INFO] [stderr] Checking serde-hjson v0.9.1 [INFO] [stderr] Compiling tokio-macros v1.4.1 [INFO] [stderr] Compiling pin-project-internal v1.0.8 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking tokio-stream v0.1.7 [INFO] [stderr] Checking futures-executor v0.3.17 [INFO] [stderr] Checking pin-project v1.0.8 [INFO] [stderr] Checking futures v0.3.17 [INFO] [stderr] Compiling tracing-attributes v0.1.18 [INFO] [stderr] Compiling enum-ordinalize v3.1.10 [INFO] [stderr] Checking tokio-util v0.6.8 [INFO] [stderr] Compiling educe v0.4.18 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.4 [INFO] [stderr] Checking opentelemetry v0.16.0 [INFO] [stderr] Compiling tarpc-plugins v0.12.0 [INFO] [stderr] Checking tracing v0.1.29 [INFO] [stderr] Checking opentelemetry-semantic-conventions v0.8.0 [INFO] [stderr] Checking opentelemetry-jaeger v0.15.0 [INFO] [stderr] Checking clap v3.0.0-beta.4 [INFO] [stderr] Checking tracing-serde v0.1.2 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking tokio-serde v0.8.0 [INFO] [stderr] Checking tracing-opentelemetry v0.15.0 [INFO] [stderr] Checking config v0.11.0 [INFO] [stderr] Checking tarpc v0.27.2 [INFO] [stderr] Checking zstd v0.9.0+zstd.1.5.0 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking rustcoinbase v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `log::*` [INFO] [stdout] --> src/rustcoinlib/localaddress.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use log::*; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::*` [INFO] [stdout] --> src/rustcoinlib/localaddress.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use log::*; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rustcoinlib/localaddress.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 25 | let mut value = (*map).entry(key).or_insert(0); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rustcoinlib/localaddress.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 37 | let mut map = self.addr_map.lock().unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rustcoinlib/localaddress.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 47 | let mut map = self.addr_map.lock().unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rustcoinlib/localaddress.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 48 | let mut value: u64 = *(*map).get(&key).unwrap_or(&0); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rustcoinlib/localaddress.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 25 | let mut value = (*map).entry(key).or_insert(0); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rustcoinlib/localaddress.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 37 | let mut map = self.addr_map.lock().unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rustcoinlib/localaddress.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 47 | let mut map = self.addr_map.lock().unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rustcoinlib/localaddress.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 48 | let mut value: u64 = *(*map).get(&key).unwrap_or(&0); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::runtime::Runtime` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/rustcoinbase/p2pserver.rs:273:5 [INFO] [stdout] | [INFO] [stdout] 241 | pub async fn start_p2pserver(settings: &Settings, peerdb: PeerDatabase, localaddresses: &LocalAddressMap ) -> anyhow::Result<()> { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | Ok(()) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/rustcoinbase/p2pserver.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | let mut local_addr_map = localaddresses; [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/rustcoinbase/main.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | let mut localaddresses = LocalAddressMap::new(); [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustcoinbase` (bin "rustcoinbase" test) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `tokio::runtime::Runtime` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/rustcoinbase/p2pserver.rs:273:5 [INFO] [stdout] | [INFO] [stdout] 241 | pub async fn start_p2pserver(settings: &Settings, peerdb: PeerDatabase, localaddresses: &LocalAddressMap ) -> anyhow::Result<()> { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | Ok(()) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/rustcoinbase/p2pserver.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 243 | let mut local_addr_map = localaddresses; [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/rustcoinbase/main.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | let mut localaddresses = LocalAddressMap::new(); [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustcoinbase` (bin "rustcoinbase") due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4c691de6cecea4512a9b413a682d4920d036e864c74cc53624cce2f348effa0b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c691de6cecea4512a9b413a682d4920d036e864c74cc53624cce2f348effa0b", kill_on_drop: false }` [INFO] [stdout] 4c691de6cecea4512a9b413a682d4920d036e864c74cc53624cce2f348effa0b