[INFO] cloning repository https://github.com/Banyc/mptcp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Banyc/mptcp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBanyc%2Fmptcp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBanyc%2Fmptcp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5982c19db0162b02a33c82a7155e4e88fbc35e28 [INFO] checking Banyc/mptcp/5982c19db0162b02a33c82a7155e4e88fbc35e28 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBanyc%2Fmptcp" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Banyc/mptcp on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-1-tc2/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/Banyc/mptcp [INFO] finished tweaking git repo https://github.com/Banyc/mptcp [INFO] tweaked toml for git repo https://github.com/Banyc/mptcp written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Banyc/mptcp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cca31dd3132369ed772f383817bef37a92b1af65676e2c4ef49b0afc37516e7d [INFO] running `Command { std: "docker" "start" "-a" "cca31dd3132369ed772f383817bef37a92b1af65676e2c4ef49b0afc37516e7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cca31dd3132369ed772f383817bef37a92b1af65676e2c4ef49b0afc37516e7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cca31dd3132369ed772f383817bef37a92b1af65676e2c4ef49b0afc37516e7d", kill_on_drop: false }` [INFO] [stdout] cca31dd3132369ed772f383817bef37a92b1af65676e2c4ef49b0afc37516e7d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6c8bc0be03056a7cdc8d1716c824874e62e3a2c400483c2cd0be81c9e2a70138 [INFO] running `Command { std: "docker" "start" "-a" "6c8bc0be03056a7cdc8d1716c824874e62e3a2c400483c2cd0be81c9e2a70138", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking reusable-box-future v0.2.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking lock_api v0.4.12 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking async_async_io v0.2.0 [INFO] [stderr] Checking mptcp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receiver.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | let leftover_data_segment = self.leftover_data_segment.take(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 144 | / tokio::select! { [INFO] [stdout] 145 | | () = recv_buf_inserted => (), [INFO] [stdout] 146 | | res = self.recv_tasks.join_next() => { [INFO] [stdout] 147 | | if let Some(task) = res { [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] 158 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receiver.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | let leftover_data_segment = self.leftover_data_segment.take(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 144 | / tokio::select! { [INFO] [stdout] 145 | | () = recv_buf_inserted => (), [INFO] [stdout] 146 | | res = self.recv_tasks.join_next() => { [INFO] [stdout] 147 | | if let Some(task) = res { [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] 158 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `JoinSet>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receiver.rs:54:33 [INFO] [stdout] | [INFO] [stdout] 51 | let res = select! { [INFO] [stdout] | _______________________________________- [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] 52 | | () = closed_tx.closed() => { [INFO] [stdout] 53 | | // Prevent triggering TCP RST from our side [INFO] [stdout] 54 | | let mut drain_task = JoinSet::new(); [INFO] [stdout] | | ^^^^^^^^^^^^^^ [INFO] [stdout] ... | [INFO] [stdout] 66 | | / tokio::select! { [INFO] [stdout] 67 | | | res = drain_task.join_next() => { [INFO] [stdout] 68 | | | if let Some(task) = res { [INFO] [stdout] 69 | | | // In case the task panicked [INFO] [stdout] ... | | [INFO] [stdout] 73 | | | () = tokio::time::sleep(LINGER) => (), [INFO] [stdout] 74 | | | } [INFO] [stdout] | | | - [INFO] [stdout] | | |_____________________________| [INFO] [stdout] | | |_____________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_____________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_____________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_____________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_____________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_____________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_____________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 78 | | | res = Message::decode(&mut stream) => res, [INFO] [stdout] 79 | | | }; [INFO] [stdout] | | | - [INFO] [stdout] | |_______|_____________________| [INFO] [stdout] | |_______|_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______|_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______|_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______|_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______|_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______|_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______|_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `JoinSet>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receiver.rs:54:33 [INFO] [stdout] | [INFO] [stdout] 51 | let res = select! { [INFO] [stdout] | _______________________________________- [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] | |_______________________________________| [INFO] [stdout] 52 | | () = closed_tx.closed() => { [INFO] [stdout] 53 | | // Prevent triggering TCP RST from our side [INFO] [stdout] 54 | | let mut drain_task = JoinSet::new(); [INFO] [stdout] | | ^^^^^^^^^^^^^^ [INFO] [stdout] ... | [INFO] [stdout] 66 | | / tokio::select! { [INFO] [stdout] 67 | | | res = drain_task.join_next() => { [INFO] [stdout] 68 | | | if let Some(task) = res { [INFO] [stdout] 69 | | | // In case the task panicked [INFO] [stdout] ... | | [INFO] [stdout] 73 | | | () = tokio::time::sleep(LINGER) => (), [INFO] [stdout] 74 | | | } [INFO] [stdout] | | | - [INFO] [stdout] | | |_____________________________| [INFO] [stdout] | | |_____________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_____________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_____________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_____________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_____________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_____________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_____________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 78 | | | res = Message::decode(&mut stream) => res, [INFO] [stdout] 79 | | | }; [INFO] [stdout] | | | - [INFO] [stdout] | |_______|_____________________| [INFO] [stdout] | |_______|_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______|_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______|_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______|_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______|_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______|_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______|_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mptcp` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mptcp` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "6c8bc0be03056a7cdc8d1716c824874e62e3a2c400483c2cd0be81c9e2a70138", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c8bc0be03056a7cdc8d1716c824874e62e3a2c400483c2cd0be81c9e2a70138", kill_on_drop: false }` [INFO] [stdout] 6c8bc0be03056a7cdc8d1716c824874e62e3a2c400483c2cd0be81c9e2a70138