[INFO] cloning repository https://github.com/AberrantWolf/coffeeshop [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AberrantWolf/coffeeshop" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAberrantWolf%2Fcoffeeshop", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAberrantWolf%2Fcoffeeshop'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 627854f68f8da459df56107d0522d485ba586832 [INFO] checking AberrantWolf/coffeeshop/627854f68f8da459df56107d0522d485ba586832 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAberrantWolf%2Fcoffeeshop" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/AberrantWolf/coffeeshop on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/AberrantWolf/coffeeshop [INFO] finished tweaking git repo https://github.com/AberrantWolf/coffeeshop [INFO] tweaked toml for git repo https://github.com/AberrantWolf/coffeeshop written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/AberrantWolf/coffeeshop already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 406cf088887d122725e9ba560d5b9bcd72919162456ab671e46a142d9ab52212 [INFO] running `Command { std: "docker" "start" "-a" "406cf088887d122725e9ba560d5b9bcd72919162456ab671e46a142d9ab52212", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "406cf088887d122725e9ba560d5b9bcd72919162456ab671e46a142d9ab52212", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "406cf088887d122725e9ba560d5b9bcd72919162456ab671e46a142d9ab52212", kill_on_drop: false }` [INFO] [stdout] 406cf088887d122725e9ba560d5b9bcd72919162456ab671e46a142d9ab52212 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] db09ec1be25b81d1c2c9d713f3b055b3354bec294a80e067affb4378a9e196e8 [INFO] running `Command { std: "docker" "start" "-a" "db09ec1be25b81d1c2c9d713f3b055b3354bec294a80e067affb4378a9e196e8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling sfml-build v0.3.0 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling fnv v1.0.6 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.15 [INFO] [stderr] Checking arc-swap v0.4.5 [INFO] [stderr] Compiling csfml-system-sys v0.5.0 [INFO] [stderr] Compiling csfml-window-sys v0.5.0 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Compiling csfml-audio-sys v0.5.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.2 [INFO] [stderr] Compiling proc-macro-error v1.0.2 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-iter v0.1.40 [INFO] [stderr] Compiling csfml-graphics-sys v0.5.0 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking array-macro v1.0.4 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking bytes v0.5.4 [INFO] [stderr] Checking widestring v0.4.0 [INFO] [stderr] Checking futures-core v0.3.4 [INFO] [stderr] Checking pin-project-lite v0.1.4 [INFO] [stderr] Compiling const-random-macro v0.1.8 [INFO] [stderr] Checking xi-unicode v0.2.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking crossbeam-channel v0.4.2 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking signal-hook v0.1.13 [INFO] [stderr] Compiling ncurses v5.99.0 [INFO] [stderr] Checking sfml v0.15.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking const-random v0.1.8 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking ahash v0.2.18 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking pancurses v0.16.1 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.106 [INFO] [stderr] Compiling enum-map-derive v0.4.3 [INFO] [stderr] Compiling tokio-macros v0.2.5 [INFO] [stderr] Checking enum-map v0.6.2 [INFO] [stderr] Checking tokio v0.2.18 [INFO] [stderr] Compiling structopt-derive v0.4.6 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling enumset_derive v0.4.4 [INFO] [stderr] Checking structopt v0.3.13 [INFO] [stderr] Checking enumset v0.4.5 [INFO] [stderr] Checking cursive v0.14.0 [INFO] [stderr] Checking bincode v1.2.1 [INFO] [stderr] Checking uuid v0.8.1 [INFO] [stderr] Checking coffeeshop v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `passthrough::PassthroughLayer` [INFO] [stdout] --> src/coffee_audio/layers.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use passthrough::PassthroughLayer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `swap_left_right::SwapLRLayer` [INFO] [stdout] --> src/coffee_audio/layers.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub use swap_left_right::SwapLRLayer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `file_source::FileSource` [INFO] [stdout] --> src/coffee_audio/sources.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use file_source::FileSource; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `filtered_source::FilteredSource` [INFO] [stdout] --> src/coffee_audio/sources.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub use filtered_source::FilteredSource; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `AudioController_Inner` should have an upper camel case name [INFO] [stdout] --> src/coffee_audio.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | struct AudioController_Inner {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `AudioControllerInner` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `passthrough::PassthroughLayer` [INFO] [stdout] --> src/coffee_audio/layers.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use passthrough::PassthroughLayer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `swap_left_right::SwapLRLayer` [INFO] [stdout] --> src/coffee_audio/layers.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub use swap_left_right::SwapLRLayer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `file_source::FileSource` [INFO] [stdout] --> src/coffee_audio/sources.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use file_source::FileSource; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `filtered_source::FilteredSource` [INFO] [stdout] --> src/coffee_audio/sources.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub use filtered_source::FilteredSource; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `AudioController_Inner` should have an upper camel case name [INFO] [stdout] --> src/coffee_audio.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | struct AudioController_Inner {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `AudioControllerInner` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Peer` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/coffee_network/peer.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 218 | let mut peer = self.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 221 | / tokio::select! { [INFO] [stdout] 222 | | _ = &mut delay => { [INFO] [stdout] 223 | | if let Ok(ping_bytes) = bincode::serialize(&PeerMessageUdp::Ping {}) { [INFO] [stdout] 224 | | if peer.udp_write(&ping_bytes).await.is_err() { [INFO] [stdout] ... | [INFO] [stdout] 236 | | } [INFO] [stdout] 237 | | }; [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Peer` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/coffee_network/peer.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 218 | let mut peer = self.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 221 | / tokio::select! { [INFO] [stdout] 222 | | _ = &mut delay => { [INFO] [stdout] 223 | | if let Ok(ping_bytes) = bincode::serialize(&PeerMessageUdp::Ping {}) { [INFO] [stdout] 224 | | if peer.udp_write(&ping_bytes).await.is_err() { [INFO] [stdout] ... | [INFO] [stdout] 236 | | } [INFO] [stdout] 237 | | }; [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ui_state` [INFO] [stdout] --> src/coffee_ui.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | let ui_state = Arc::new(Mutex::new(MainUiState { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ui_state` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `audio_controller` is never read [INFO] [stdout] --> src/coffee_app.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct CoffeeAppContext { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 6 | net_controller: NetworkController, [INFO] [stdout] 7 | audio_controller: AudioController, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CoffeeAppContext` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `inner` is never read [INFO] [stdout] --> src/coffee_audio.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct AudioController { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 10 | inner: Arc>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AudioController` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AudioNetReceiver` is never constructed [INFO] [stdout] --> src/coffee_audio.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | struct AudioNetReceiver {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/coffee_audio/sources/file_source.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 26 | impl FileSource { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn new(file: &str) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `add_filter` are never used [INFO] [stdout] --> src/coffee_audio/sources/filtered_source.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl FilteredSource { [INFO] [stdout] | -------------------------------------- associated items in this implementation [INFO] [stdout] 12 | pub fn new(base: T) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn add_filter(&mut self, filter: A) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `set_channel_count`, and `set_sample_rate` are never used [INFO] [stdout] --> src/coffee_audio/types.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl AudioChunk { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 11 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn set_channel_count(&mut self, count: u32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn set_sample_rate(&mut self, rate: u32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `chat_view` is never read [INFO] [stdout] --> src/coffee_ui.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | struct MainUiState { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 13 | chat_view: Arc>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/coffee_network/peer.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Serialize, Debug, Deserialize, Clone, Eq, PartialEq, Hash)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_PeerInfo` [INFO] [stdout] 12 | struct PeerInfo { [INFO] [stdout] | -------- `PeerInfo` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/coffee_network/peer.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Serialize, Debug, Deserialize, Clone, Eq, PartialEq, Hash)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_PeerInfo` [INFO] [stdout] 12 | struct PeerInfo { [INFO] [stdout] | -------- `PeerInfo` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/coffee_network/peer.rs:310:10 [INFO] [stdout] | [INFO] [stdout] 310 | #[derive(Deserialize, Serialize, Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_PeerMessageTcp` [INFO] [stdout] 311 | enum PeerMessageTcp { [INFO] [stdout] | -------------- `PeerMessageTcp` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/coffee_network/peer.rs:310:23 [INFO] [stdout] | [INFO] [stdout] 310 | #[derive(Deserialize, Serialize, Clone)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_PeerMessageTcp` [INFO] [stdout] 311 | enum PeerMessageTcp { [INFO] [stdout] | -------------- `PeerMessageTcp` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/coffee_network/peer.rs:317:10 [INFO] [stdout] | [INFO] [stdout] 317 | #[derive(Deserialize, Serialize, Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_PeerMessageUdp` [INFO] [stdout] 318 | enum PeerMessageUdp { [INFO] [stdout] | -------------- `PeerMessageUdp` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/coffee_network/peer.rs:317:23 [INFO] [stdout] | [INFO] [stdout] 317 | #[derive(Deserialize, Serialize, Clone)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_PeerMessageUdp` [INFO] [stdout] 318 | enum PeerMessageUdp { [INFO] [stdout] | -------------- `PeerMessageUdp` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `coffeeshop` (bin "coffeeshop") due to 2 previous errors; 19 warnings emitted [INFO] [stdout] warning: unused variable: `ui_state` [INFO] [stdout] --> src/coffee_ui.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | let ui_state = Arc::new(Mutex::new(MainUiState { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ui_state` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `audio_controller` is never read [INFO] [stdout] --> src/coffee_app.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct CoffeeAppContext { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 6 | net_controller: NetworkController, [INFO] [stdout] 7 | audio_controller: AudioController, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CoffeeAppContext` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `inner` is never read [INFO] [stdout] --> src/coffee_audio.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct AudioController { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 10 | inner: Arc>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AudioController` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AudioNetReceiver` is never constructed [INFO] [stdout] --> src/coffee_audio.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | struct AudioNetReceiver {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/coffee_audio/sources/file_source.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 26 | impl FileSource { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn new(file: &str) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `add_filter` are never used [INFO] [stdout] --> src/coffee_audio/sources/filtered_source.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl FilteredSource { [INFO] [stdout] | -------------------------------------- associated items in this implementation [INFO] [stdout] 12 | pub fn new(base: T) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn add_filter(&mut self, filter: A) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `set_channel_count`, and `set_sample_rate` are never used [INFO] [stdout] --> src/coffee_audio/types.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl AudioChunk { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 11 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn set_channel_count(&mut self, count: u32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn set_sample_rate(&mut self, rate: u32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `chat_view` is never read [INFO] [stdout] --> src/coffee_ui.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | struct MainUiState { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 13 | chat_view: Arc>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/coffee_network/peer.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Serialize, Debug, Deserialize, Clone, Eq, PartialEq, Hash)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_PeerInfo` [INFO] [stdout] 12 | struct PeerInfo { [INFO] [stdout] | -------- `PeerInfo` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/coffee_network/peer.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Serialize, Debug, Deserialize, Clone, Eq, PartialEq, Hash)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_PeerInfo` [INFO] [stdout] 12 | struct PeerInfo { [INFO] [stdout] | -------- `PeerInfo` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/coffee_network/peer.rs:310:10 [INFO] [stdout] | [INFO] [stdout] 310 | #[derive(Deserialize, Serialize, Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_PeerMessageTcp` [INFO] [stdout] 311 | enum PeerMessageTcp { [INFO] [stdout] | -------------- `PeerMessageTcp` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/coffee_network/peer.rs:310:23 [INFO] [stdout] | [INFO] [stdout] 310 | #[derive(Deserialize, Serialize, Clone)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_PeerMessageTcp` [INFO] [stdout] 311 | enum PeerMessageTcp { [INFO] [stdout] | -------------- `PeerMessageTcp` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/coffee_network/peer.rs:317:10 [INFO] [stdout] | [INFO] [stdout] 317 | #[derive(Deserialize, Serialize, Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_PeerMessageUdp` [INFO] [stdout] 318 | enum PeerMessageUdp { [INFO] [stdout] | -------------- `PeerMessageUdp` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/coffee_network/peer.rs:317:23 [INFO] [stdout] | [INFO] [stdout] 317 | #[derive(Deserialize, Serialize, Clone)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_PeerMessageUdp` [INFO] [stdout] 318 | enum PeerMessageUdp { [INFO] [stdout] | -------------- `PeerMessageUdp` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `coffeeshop` (bin "coffeeshop" test) due to 2 previous errors; 19 warnings emitted [INFO] running `Command { std: "docker" "inspect" "db09ec1be25b81d1c2c9d713f3b055b3354bec294a80e067affb4378a9e196e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db09ec1be25b81d1c2c9d713f3b055b3354bec294a80e067affb4378a9e196e8", kill_on_drop: false }` [INFO] [stdout] db09ec1be25b81d1c2c9d713f3b055b3354bec294a80e067affb4378a9e196e8