[INFO] cloning repository https://github.com/46bit/comms [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/46bit/comms" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F46bit%2Fcomms", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F46bit%2Fcomms'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6d96ab1c55c57c5ae6d84e9064756cabe32135c4 [INFO] checking 46bit/comms/6d96ab1c55c57c5ae6d84e9064756cabe32135c4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F46bit%2Fcomms" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/46bit/comms on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/46bit/comms [INFO] finished tweaking git repo https://github.com/46bit/comms [INFO] tweaked toml for git repo https://github.com/46bit/comms written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/46bit/comms already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe5c28fb6a2a59bda8e113e45d4da7e99083a281fdae04cb6fea95bc0e574c2e [INFO] running `Command { std: "docker" "start" "-a" "fe5c28fb6a2a59bda8e113e45d4da7e99083a281fdae04cb6fea95bc0e574c2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe5c28fb6a2a59bda8e113e45d4da7e99083a281fdae04cb6fea95bc0e574c2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe5c28fb6a2a59bda8e113e45d4da7e99083a281fdae04cb6fea95bc0e574c2e", kill_on_drop: false }` [INFO] [stdout] fe5c28fb6a2a59bda8e113e45d4da7e99083a281fdae04cb6fea95bc0e574c2e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f45dac67c185a081a1039e42f213cf5ad9d3b1ebf84aeb2e576cffddb02665a8 [INFO] running `Command { std: "docker" "start" "-a" "f45dac67c185a081a1039e42f213cf5ad9d3b1ebf84aeb2e576cffddb02665a8", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.21 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking regex-syntax v0.3.9 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Checking futures v0.1.13 [INFO] [stderr] Checking log v0.3.7 [INFO] [stderr] Checking slab v0.3.0 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking tokio-timer v0.1.1 [INFO] [stderr] Checking comms v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self::transmit::*` [INFO] [stdout] --> src/room/mod.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub use self::transmit::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/client/mod.rs:126:39 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn update_status(self) -> Box, Self), Error = Self>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 126 | pub fn update_status(self) -> Box, Self), Error = Self>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking quickcheck v0.2.27 [INFO] [stdout] warning: unused import: `self::transmit::*` [INFO] [stdout] --> src/room/mod.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub use self::transmit::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/client/mod.rs:126:39 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn update_status(self) -> Box, Self), Error = Self>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 126 | pub fn update_status(self) -> Box, Self), Error = Self>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:56:33 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn unpark_noop() -> Arc { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 56 | pub fn unpark_noop() -> Arc { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ReceiveWithHardTimeout, Unfold>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/receive.rs:238:17 [INFO] [stdout] | [INFO] [stdout] 234 | let timer = tokio_timer::Timer::default(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | let mut receive = client.receive().with_hard_timeout(duration, &timer); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ReceiveWithSoftTimeout, Unfold>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/receive.rs:258:17 [INFO] [stdout] | [INFO] [stdout] 254 | let timer = tokio_timer::Timer::default(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | let mut receive = client.receive().with_soft_timeout(duration, &timer); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `client::Client, futures::sync::mpsc::Receiver>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/receive.rs:436:17 [INFO] [stdout] | [INFO] [stdout] 421 | let timer = tokio_timer::Timer::default(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | let timeouted_client = subtest_timeout_happens(&f, duration); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `client::Client, futures::sync::mpsc::Receiver>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/receive.rs:463:17 [INFO] [stdout] | [INFO] [stdout] 448 | let timer = tokio_timer::Timer::default(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 463 | let timeouted_client = subtest_timeout_happens(&f, duration); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Spawn, futures::sync::mpsc::Receiver>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:389:17 [INFO] [stdout] | [INFO] [stdout] 382 | let (_, mut tx_to_client, mut client) = mock_client("client1", 1); [INFO] [stdout] | ---------------- ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 389 | let mut future = executor::spawn(receive.fuse()); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(std::collections::HashMap, room::Room, futures::sync::mpsc::Receiver>>), ()>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/room/mod.rs:303:15 [INFO] [stdout] | [INFO] [stdout] 293 | let mut future = executor::spawn(room.receive_all().fuse()); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | match future.wait_future() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/client/mod.rs:336:53 [INFO] [stdout] | [INFO] [stdout] 336 | let (_, _, client0) = mock_client(client0_id.clone(), 1); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/client/mod.rs:338:53 [INFO] [stdout] | [INFO] [stdout] 338 | let (_, _, client1) = mock_client(client1_id.clone(), 1); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `comms` (lib test) due to 7 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f45dac67c185a081a1039e42f213cf5ad9d3b1ebf84aeb2e576cffddb02665a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f45dac67c185a081a1039e42f213cf5ad9d3b1ebf84aeb2e576cffddb02665a8", kill_on_drop: false }` [INFO] [stdout] f45dac67c185a081a1039e42f213cf5ad9d3b1ebf84aeb2e576cffddb02665a8