[INFO] cloning repository https://github.com/21pages/punch [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/21pages/punch" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F21pages%2Fpunch", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F21pages%2Fpunch'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8e37b4cefbbce07048e1d620a6c92c93a8297cd3 [INFO] checking 21pages/punch/8e37b4cefbbce07048e1d620a6c92c93a8297cd3 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F21pages%2Fpunch" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/21pages/punch on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/21pages/punch [INFO] finished tweaking git repo https://github.com/21pages/punch [INFO] tweaked toml for git repo https://github.com/21pages/punch written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/21pages/punch already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e6c042d10534c295a21f642bada07a072a94a800d94e2e3345fcfc02df37027f [INFO] running `Command { std: "docker" "start" "-a" "e6c042d10534c295a21f642bada07a072a94a800d94e2e3345fcfc02df37027f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e6c042d10534c295a21f642bada07a072a94a800d94e2e3345fcfc02df37027f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6c042d10534c295a21f642bada07a072a94a800d94e2e3345fcfc02df37027f", kill_on_drop: false }` [INFO] [stdout] e6c042d10534c295a21f642bada07a072a94a800d94e2e3345fcfc02df37027f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 60c685ff11d3c5f48a15fdb9f57248bedc51f1b27cbb73d3ea34fdcf3d2e5104 [INFO] running `Command { std: "docker" "start" "-a" "60c685ff11d3c5f48a15fdb9f57248bedc51f1b27cbb73d3ea34fdcf3d2e5104", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling libc v0.2.118 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling protobuf v3.0.0-alpha.6 [INFO] [stderr] Compiling anyhow v1.0.53 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking mio v0.8.0 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling clap_derive v3.1.0 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking clap v3.1.0 [INFO] [stderr] Checking serde v1.0.136 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking serde_json v1.0.79 [INFO] [stderr] Checking punch v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/hybrid_server.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 40 | tcp_listener: TcpListener, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | udp_socket: Arc, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let mut saved_stream_a: Option = None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 46 | loop { [INFO] [stdout] 47 | / tokio::select! { [INFO] [stdout] 48 | | Ok((mut stream, addr)) = tcp_listener.accept() => { [INFO] [stdout] 49 | | log::info!("new client from {:?}", addr); [INFO] [stdout] 50 | | match stream.read(&mut buf).await { [INFO] [stdout] ... | [INFO] [stdout] 97 | | } [INFO] [stdout] 98 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::net::TcpStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/hybrid_client.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | let mut stream = connect_server(server_addr).await?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 84 | let _ = tokio::join!(handle_stdin); [INFO] [stdout] | -------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/hybrid_server.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 40 | tcp_listener: TcpListener, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | udp_socket: Arc, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let mut saved_stream_a: Option = None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 46 | loop { [INFO] [stdout] 47 | / tokio::select! { [INFO] [stdout] 48 | | Ok((mut stream, addr)) = tcp_listener.accept() => { [INFO] [stdout] 49 | | log::info!("new client from {:?}", addr); [INFO] [stdout] 50 | | match stream.read(&mut buf).await { [INFO] [stdout] ... | [INFO] [stdout] 97 | | } [INFO] [stdout] 98 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `punch` (bin "hybrid_server" test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Interval` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/hybrid_client.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 205 | async fn chat(mut stream: TcpStream) -> Result<()> { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | let mut timer = interval(Duration::from_secs(1)); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 215 | / tokio::select! { [INFO] [stdout] 216 | | Ok(n) = stream.read(&mut buf) => { [INFO] [stdout] 217 | | log::info!("recv {} bytes", n); [INFO] [stdout] 218 | | if n == 0 { [INFO] [stdout] ... | [INFO] [stdout] 233 | | [INFO] [stdout] 234 | | } [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::net::TcpStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/hybrid_client.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | let mut stream = connect_server(server_addr).await?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 84 | let _ = tokio::join!(handle_stdin); [INFO] [stdout] | -------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `punch` (bin "hybrid_server") due to 2 previous errors [INFO] [stdout] error: this value of type `Interval` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/hybrid_client.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 205 | async fn chat(mut stream: TcpStream) -> Result<()> { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | let mut timer = interval(Duration::from_secs(1)); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 215 | / tokio::select! { [INFO] [stdout] 216 | | Ok(n) = stream.read(&mut buf) => { [INFO] [stdout] 217 | | log::info!("recv {} bytes", n); [INFO] [stdout] 218 | | if n == 0 { [INFO] [stdout] ... | [INFO] [stdout] 233 | | [INFO] [stdout] 234 | | } [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::net::UdpSocket` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/hybrid_client.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 241 | sender: mpsc::Sender, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | let socket = UdpSocket::bind("0.0.0.0:0").await.unwrap(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 265 | / tokio::select! { [INFO] [stdout] 266 | | _ = timer.tick() => { [INFO] [stdout] 267 | | let register_request = Message::register_request(id.clone()); [INFO] [stdout] 268 | | match socket.send(®ister_request.encode()).await { [INFO] [stdout] ... | [INFO] [stdout] 287 | | } [INFO] [stdout] 288 | | } [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::net::UdpSocket` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/hybrid_client.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 241 | sender: mpsc::Sender, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | let socket = UdpSocket::bind("0.0.0.0:0").await.unwrap(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 265 | / tokio::select! { [INFO] [stdout] 266 | | _ = timer.tick() => { [INFO] [stdout] 267 | | let register_request = Message::register_request(id.clone()); [INFO] [stdout] 268 | | match socket.send(®ister_request.encode()).await { [INFO] [stdout] ... | [INFO] [stdout] 287 | | } [INFO] [stdout] 288 | | } [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `punch` (bin "hybrid_client") due to 4 previous errors [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `punch` (bin "hybrid_client" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "60c685ff11d3c5f48a15fdb9f57248bedc51f1b27cbb73d3ea34fdcf3d2e5104", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60c685ff11d3c5f48a15fdb9f57248bedc51f1b27cbb73d3ea34fdcf3d2e5104", kill_on_drop: false }` [INFO] [stdout] 60c685ff11d3c5f48a15fdb9f57248bedc51f1b27cbb73d3ea34fdcf3d2e5104