[INFO] fetching crate yubikey 0.8.0... [INFO] checking yubikey-0.8.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate yubikey 0.8.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate yubikey 0.8.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate yubikey 0.8.0 [INFO] finished tweaking crates.io crate yubikey 0.8.0 [INFO] tweaked toml for crates.io crate yubikey 0.8.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 101 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding env_logger v0.10.2 (available: v0.11.5) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding secrecy v0.8.0 (available: v0.10.2) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c8365f91a0a9be26bf5323695f53fd879548adbc60ac6a6bab928374996fc711 [INFO] running `Command { std: "docker" "start" "-a" "c8365f91a0a9be26bf5323695f53fd879548adbc60ac6a6bab928374996fc711", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c8365f91a0a9be26bf5323695f53fd879548adbc60ac6a6bab928374996fc711", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c8365f91a0a9be26bf5323695f53fd879548adbc60ac6a6bab928374996fc711", kill_on_drop: false }` [INFO] [stdout] c8365f91a0a9be26bf5323695f53fd879548adbc60ac6a6bab928374996fc711 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 10aedb736634b072278a5b31af7d4b372c06d7b74a5b94271964005f57cbb278 [INFO] running `Command { std: "docker" "start" "-a" "10aedb736634b072278a5b31af7d4b372c06d7b74a5b94271964005f57cbb278", kill_on_drop: false }` [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking flagset v0.4.6 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling pcsc-sys v1.2.1 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking pcsc v2.8.2 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking des v0.8.1 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling der_derive v0.7.3 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking x509-cert v0.2.5 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking p384 v0.13.0 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking yubikey v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/error.rs:195:11 [INFO] [stdout] | [INFO] [stdout] 195 | impl From for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | unused_qualifications [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 195 - impl From for Error { [INFO] [stdout] 195 + impl From for Error { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/error.rs:196:19 [INFO] [stdout] | [INFO] [stdout] 196 | fn from(_err: x509_cert::der::Error) -> Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 196 - fn from(_err: x509_cert::der::Error) -> Error { [INFO] [stdout] 196 + fn from(_err: der::Error) -> Error { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:201:50 [INFO] [stdout] | [INFO] [stdout] 201 | let _ = yk_stored.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 201 - let _ = yk_stored.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] 201 + let _ = yk_stored.disconnect(Disposition::LeaveCard); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:202:49 [INFO] [stdout] | [INFO] [stdout] 202 | let _ = yk_found.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 202 - let _ = yk_found.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] 202 + let _ = yk_found.disconnect(Disposition::LeaveCard); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:249:44 [INFO] [stdout] | [INFO] [stdout] 249 | let _ = yubikey.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 249 - let _ = yubikey.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] 249 + let _ = yubikey.disconnect(Disposition::LeaveCard); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:730:54 [INFO] [stdout] | [INFO] [stdout] 730 | if let Err((_, e)) = card.disconnect(pcsc::Disposition::LeaveCard) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 730 - if let Err((_, e)) = card.disconnect(pcsc::Disposition::LeaveCard) { [INFO] [stdout] 730 + if let Err((_, e)) = card.disconnect(Disposition::LeaveCard) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/error.rs:195:11 [INFO] [stdout] | [INFO] [stdout] 195 | impl From for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | unused_qualifications [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 195 - impl From for Error { [INFO] [stdout] 195 + impl From for Error { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/error.rs:196:19 [INFO] [stdout] | [INFO] [stdout] 196 | fn from(_err: x509_cert::der::Error) -> Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 196 - fn from(_err: x509_cert::der::Error) -> Error { [INFO] [stdout] 196 + fn from(_err: der::Error) -> Error { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:201:50 [INFO] [stdout] | [INFO] [stdout] 201 | let _ = yk_stored.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 201 - let _ = yk_stored.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] 201 + let _ = yk_stored.disconnect(Disposition::LeaveCard); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:202:49 [INFO] [stdout] | [INFO] [stdout] 202 | let _ = yk_found.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 202 - let _ = yk_found.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] 202 + let _ = yk_found.disconnect(Disposition::LeaveCard); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:249:44 [INFO] [stdout] | [INFO] [stdout] 249 | let _ = yubikey.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 249 - let _ = yubikey.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] 249 + let _ = yubikey.disconnect(Disposition::LeaveCard); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:730:54 [INFO] [stdout] | [INFO] [stdout] 730 | if let Err((_, e)) = card.disconnect(pcsc::Disposition::LeaveCard) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 730 - if let Err((_, e)) = card.disconnect(pcsc::Disposition::LeaveCard) { [INFO] [stdout] 730 + if let Err((_, e)) = card.disconnect(Disposition::LeaveCard) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> tests/integration.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 321 | certificate::Certificate::from_bytes(bob_der).expect("Failed to parse valid certificate"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> tests/integration.rs:4:56 [INFO] [stdout] | [INFO] [stdout] 4 | #![warn(missing_docs, rust_2018_idioms, trivial_casts, unused_qualifications)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 321 - certificate::Certificate::from_bytes(bob_der).expect("Failed to parse valid certificate"); [INFO] [stdout] 321 + Certificate::from_bytes(bob_der).expect("Failed to parse valid certificate"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/integration.rs:306:11 [INFO] [stdout] | [INFO] [stdout] 289 | let mut yubikey = YUBIKEY.lock().unwrap(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | let generated = piv::generate( [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | match piv::metadata(&mut yubikey, slot) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yubikey` (test "integration") due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "10aedb736634b072278a5b31af7d4b372c06d7b74a5b94271964005f57cbb278", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10aedb736634b072278a5b31af7d4b372c06d7b74a5b94271964005f57cbb278", kill_on_drop: false }` [INFO] [stdout] 10aedb736634b072278a5b31af7d4b372c06d7b74a5b94271964005f57cbb278