[INFO] fetching crate xi-rpc 0.3.0... [INFO] checking xi-rpc-0.3.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate xi-rpc 0.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate xi-rpc 0.3.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xi-rpc 0.3.0 [INFO] finished tweaking crates.io crate xi-rpc 0.3.0 [INFO] tweaked toml for crates.io crate xi-rpc 0.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 30 packages to latest compatible versions [INFO] [stderr] Adding cfg-if v0.1.10 (available: v1.0.0) [INFO] [stderr] Adding crossbeam v0.7.3 (available: v0.8.4) [INFO] [stderr] Adding crossbeam-channel v0.4.4 (available: v0.5.13) [INFO] [stderr] Adding crossbeam-deque v0.7.4 (available: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (available: v0.9.18) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (available: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (available: v0.8.20) [INFO] [stderr] Adding memoffset v0.5.6 (available: v0.9.1) [INFO] [stderr] Adding time v0.1.45 (available: v0.3.36) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b4a2bbdbb00f2544a99314d2c9147d937a311397e8e46041839551a62c021263 [INFO] running `Command { std: "docker" "start" "-a" "b4a2bbdbb00f2544a99314d2c9147d937a311397e8e46041839551a62c021263", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b4a2bbdbb00f2544a99314d2c9147d937a311397e8e46041839551a62c021263", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4a2bbdbb00f2544a99314d2c9147d937a311397e8e46041839551a62c021263", kill_on_drop: false }` [INFO] [stdout] b4a2bbdbb00f2544a99314d2c9147d937a311397e8e46041839551a62c021263 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 010668b76b9aed010de54748a2bb50acb3820198c53d57467887a44ba3957a43 [INFO] running `Command { std: "docker" "start" "-a" "010668b76b9aed010de54748a2bb50acb3820198c53d57467887a44ba3957a43", kill_on_drop: false }` [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking xi-trace v0.2.0 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Checking xi-rpc v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:411:25 [INFO] [stdout] | [INFO] [stdout] 410 | let _trace = trace_block_payload("send notif", &["rpc"], method.to_owned()); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 411 | if let Err(e) = self.send(&json!({ [INFO] [stdout] | _________________________^ [INFO] [stdout] 412 | | "method": method, [INFO] [stdout] 413 | | "params": params, [INFO] [stdout] 414 | | })) { [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, W>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:451:9 [INFO] [stdout] | [INFO] [stdout] 448 | let _trace = trace_block("send", &["rpc"]); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 451 | self.0.writer.lock().unwrap().write_all(s.as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `IdleProc` is never used [INFO] [stdout] --> src/lib.rs:161:7 [INFO] [stdout] | [INFO] [stdout] 161 | trait IdleProc: Send { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xi-rpc` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:411:25 [INFO] [stdout] | [INFO] [stdout] 410 | let _trace = trace_block_payload("send notif", &["rpc"], method.to_owned()); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 411 | if let Err(e) = self.send(&json!({ [INFO] [stdout] | _________________________^ [INFO] [stdout] 412 | | "method": method, [INFO] [stdout] 413 | | "params": params, [INFO] [stdout] 414 | | })) { [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, W>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:451:9 [INFO] [stdout] | [INFO] [stdout] 448 | let _trace = trace_block("send", &["rpc"]); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 451 | self.0.writer.lock().unwrap().write_all(s.as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `IdleProc` is never used [INFO] [stdout] --> src/lib.rs:161:7 [INFO] [stdout] | [INFO] [stdout] 161 | trait IdleProc: Send { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xi-rpc` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "010668b76b9aed010de54748a2bb50acb3820198c53d57467887a44ba3957a43", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "010668b76b9aed010de54748a2bb50acb3820198c53d57467887a44ba3957a43", kill_on_drop: false }` [INFO] [stdout] 010668b76b9aed010de54748a2bb50acb3820198c53d57467887a44ba3957a43