[INFO] fetching crate xand-secrets-key-vault 0.2.1... [INFO] checking xand-secrets-key-vault-0.2.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate xand-secrets-key-vault 0.2.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate xand-secrets-key-vault 0.2.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xand-secrets-key-vault 0.2.1 [INFO] finished tweaking crates.io crate xand-secrets-key-vault 0.2.1 [INFO] tweaked toml for crates.io crate xand-secrets-key-vault 0.2.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 181 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (available: v0.22.1) [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (available: v0.10.0) [INFO] [stderr] Adding foreign-types v0.3.2 (available: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding h2 v0.3.26 (available: v0.4.6) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (available: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (available: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (available: v1.4.1) [INFO] [stderr] Adding hyper-tls v0.5.0 (available: v0.6.0) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding jsonwebtoken v8.3.0 (available: v9.3.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding mockito v0.31.1 (available: v1.5.0) [INFO] [stderr] Adding pem v1.1.1 (available: v3.0.4) [INFO] [stderr] Adding reqwest v0.11.27 (available: v0.12.7) [INFO] [stderr] Adding ring v0.16.20 (available: v0.17.8) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (available: v2.1.3) [INFO] [stderr] Adding secrecy v0.7.0 (available: v0.10.2) [INFO] [stderr] Adding security-framework v2.11.1 (available: v3.0.0) [INFO] [stderr] Adding spin v0.5.2 (available: v0.9.8) [INFO] [stderr] Adding sync_wrapper v0.1.2 (available: v1.0.1) [INFO] [stderr] Adding system-configuration v0.5.1 (available: v0.6.1) [INFO] [stderr] Adding system-configuration-sys v0.5.0 (available: v0.6.0) [INFO] [stderr] Adding untrusted v0.7.1 (available: v0.9.0) [INFO] [stderr] Adding urlencoding v1.3.3 (available: v2.1.3) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (available: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding winreg v0.50.0 (available: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 46be337a1788a3e0bad7034be4b15ff87314ddf4e76f528e131859d49397796b [INFO] running `Command { std: "docker" "start" "-a" "46be337a1788a3e0bad7034be4b15ff87314ddf4e76f528e131859d49397796b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "46be337a1788a3e0bad7034be4b15ff87314ddf4e76f528e131859d49397796b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46be337a1788a3e0bad7034be4b15ff87314ddf4e76f528e131859d49397796b", kill_on_drop: false }` [INFO] [stdout] 46be337a1788a3e0bad7034be4b15ff87314ddf4e76f528e131859d49397796b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3636a1034c49adfe38e0a6b4ad9829aacda9a9774685fddda9bae7f8adfa9ca2 [INFO] running `Command { std: "docker" "start" "-a" "3636a1034c49adfe38e0a6b4ad9829aacda9a9774685fddda9bae7f8adfa9ca2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking pem v1.1.1 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking urlencoding v1.3.3 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking openssl-sys v0.9.103 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking openssl v0.10.66 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking simple_asn1 v0.6.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking native-tls v0.2.12 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking secrecy v0.7.0 [INFO] [stderr] Checking xand-secrets v0.4.2 [INFO] [stderr] Checking assert-json-diff v2.0.2 [INFO] [stderr] Checking jsonwebtoken v8.3.0 [INFO] [stderr] Checking mockito v0.31.1 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking xand-secrets-key-vault v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `token_type`, `expires_in`, `expires_on`, `not_before`, and `resource` are never read [INFO] [stdout] --> src/models.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct TokenResponse { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 14 | pub access_token: Secret, [INFO] [stdout] 15 | pub token_type: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 16 | pub expires_in: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 17 | pub expires_on: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 18 | pub not_before: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 19 | pub resource: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/models.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct ReadSecretResponse { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 24 | pub value: Secret, [INFO] [stdout] 25 | pub id: String, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `ReadSecretResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:178:54 [INFO] [stdout] | [INFO] [stdout] 158 | let secret_store = create_basic_secret_store(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | [INFO] [stdout] 160 | let mock_token_endpoint = mockito::mock("POST", "/test-tenant-id/oauth2/token") [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | let token_result = secret_store.get_updated_token().await; [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | if let Err(TokenRetrievalError::Authentication { internal_error }) = token_result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:216:49 [INFO] [stdout] | [INFO] [stdout] 195 | let secret_store = create_basic_secret_store(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | [INFO] [stdout] 197 | let mock_token_endpoint = mockito::mock("POST", "/test-tenant-id/oauth2/token") [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | let token_result = secret_store.get_updated_token().await; [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | if let Err(TokenRetrievalError::BodyParse { internal_error }) = token_result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:374:49 [INFO] [stdout] | [INFO] [stdout] 363 | let secret_store = KeyVaultSecretKeyValueStore::create_from_config(KeyVaultConfiguration { [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 372 | let token_result = secret_store.get_updated_token().await; [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 373 | [INFO] [stdout] 374 | if let Err(TokenRetrievalError::Transport { internal_error }) = token_result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `token_type`, `expires_in`, `expires_on`, `not_before`, and `resource` are never read [INFO] [stdout] --> src/models.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct TokenResponse { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 14 | pub access_token: Secret, [INFO] [stdout] 15 | pub token_type: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 16 | pub expires_in: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 17 | pub expires_on: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 18 | pub not_before: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 19 | pub resource: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/models.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct ReadSecretResponse { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 24 | pub value: Secret, [INFO] [stdout] 25 | pub id: String, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `ReadSecretResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xand-secrets-key-vault` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3636a1034c49adfe38e0a6b4ad9829aacda9a9774685fddda9bae7f8adfa9ca2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3636a1034c49adfe38e0a6b4ad9829aacda9a9774685fddda9bae7f8adfa9ca2", kill_on_drop: false }` [INFO] [stdout] 3636a1034c49adfe38e0a6b4ad9829aacda9a9774685fddda9bae7f8adfa9ca2