[INFO] fetching crate workspace 0.4.2... [INFO] checking workspace-0.4.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate workspace 0.4.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate workspace 0.4.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate workspace 0.4.2 [INFO] finished tweaking crates.io crate workspace 0.4.2 [INFO] tweaked toml for crates.io crate workspace 0.4.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 67 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (available: v0.7.6) [INFO] [stderr] Adding base64 v0.13.1 (available: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding blake2b_simd v0.5.11 (available: v1.0.2) [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.18) [INFO] [stderr] Adding colored v1.9.4 (available: v2.1.0) [INFO] [stderr] Adding constant_time_eq v0.1.5 (available: v0.3.1) [INFO] [stderr] Adding dirs v1.0.5 (available: v5.0.1) [INFO] [stderr] Adding getrandom v0.1.16 (available: v0.2.15) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding redox_syscall v0.1.57 (available: v0.5.6) [INFO] [stderr] Adding redox_users v0.3.5 (available: v0.4.6) [INFO] [stderr] Adding rust-argon2 v0.8.3 (available: v2.1.0) [INFO] [stderr] Adding serde_yaml v0.8.26 (available: v0.9.34+deprecated) [INFO] [stderr] Adding strsim v0.8.0 (available: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (available: v0.13.1) [INFO] [stderr] Adding term_grid v0.1.7 (available: v0.2.0) [INFO] [stderr] Adding textwrap v0.11.0 (available: v0.16.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 00ccf5e9e382e1008175d81375d214d35c3e756c8857fbbf29d729941b4600af [INFO] running `Command { std: "docker" "start" "-a" "00ccf5e9e382e1008175d81375d214d35c3e756c8857fbbf29d729941b4600af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "00ccf5e9e382e1008175d81375d214d35c3e756c8857fbbf29d729941b4600af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00ccf5e9e382e1008175d81375d214d35c3e756c8857fbbf29d729941b4600af", kill_on_drop: false }` [INFO] [stdout] 00ccf5e9e382e1008175d81375d214d35c3e756c8857fbbf29d729941b4600af [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7464d23ad15cea73941bc571aaf2b24511ebf04e86e47924759a8ea901b28bb3 [INFO] running `Command { std: "docker" "start" "-a" "7464d23ad15cea73941bc571aaf2b24511ebf04e86e47924759a8ea901b28bb3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking gimli v0.31.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking term_grid v0.1.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking colored v1.9.4 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking addr2line v0.24.1 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking workspace v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: derive helper attribute is used before it is introduced [INFO] [stdout] --> src/workspace.rs:15:3 [INFO] [stdout] | [INFO] [stdout] 15 | #[serde(deny_unknown_fields)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] 16 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | --------- the attribute is introduced here [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79202 [INFO] [stdout] = note: `#[warn(legacy_derive_helpers)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/macros.rs:10:77 [INFO] [stdout] | [INFO] [stdout] 10 | eprintln!(concat!("{} ", $message), "error:".red().bold()$(, $arg)*); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] ::: src/workspace.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | error!("Please set $BROWSER to open browser tabs") [INFO] [stdout] | -------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `error` [INFO] [stdout] = note: `#[warn(semicolon_in_expressions_from_macros)]` on by default [INFO] [stdout] = note: this warning originates in the macro `error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/macros.rs:29:60 [INFO] [stdout] | [INFO] [stdout] 29 | eprintln!(concat!(" ", $message)$(, $arg)*); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] ::: src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / indent_warn!( [INFO] [stdout] 35 | | "To set `ws` up in your shell, see the README.md or run `workspace shell --help`" [INFO] [stdout] 36 | | ) [INFO] [stdout] | |_________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `indent_warn` [INFO] [stdout] = note: this warning originates in the macro `indent_warn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derive helper attribute is used before it is introduced [INFO] [stdout] --> src/workspace.rs:15:3 [INFO] [stdout] | [INFO] [stdout] 15 | #[serde(deny_unknown_fields)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] 16 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | --------- the attribute is introduced here [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79202 [INFO] [stdout] = note: `#[warn(legacy_derive_helpers)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/macros.rs:10:77 [INFO] [stdout] | [INFO] [stdout] 10 | eprintln!(concat!("{} ", $message), "error:".red().bold()$(, $arg)*); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] ::: src/workspace.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | error!("Please set $BROWSER to open browser tabs") [INFO] [stdout] | -------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `error` [INFO] [stdout] = note: `#[warn(semicolon_in_expressions_from_macros)]` on by default [INFO] [stdout] = note: this warning originates in the macro `error` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/macros.rs:29:60 [INFO] [stdout] | [INFO] [stdout] 29 | eprintln!(concat!(" ", $message)$(, $arg)*); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] ::: src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / indent_warn!( [INFO] [stdout] 35 | | "To set `ws` up in your shell, see the README.md or run `workspace shell --help`" [INFO] [stdout] 36 | | ) [INFO] [stdout] | |_________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `indent_warn` [INFO] [stdout] = note: this warning originates in the macro `indent_warn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/workspace.rs:242:10 [INFO] [stdout] | [INFO] [stdout] 242 | #[derive(Fail, Debug)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_Error` [INFO] [stdout] 243 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/workspace.rs:242:10 [INFO] [stdout] | [INFO] [stdout] 242 | #[derive(Fail, Debug)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_Error` [INFO] [stdout] 243 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/workspace.rs:242:10 [INFO] [stdout] | [INFO] [stdout] 242 | #[derive(Fail, Debug)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_Error` [INFO] [stdout] 243 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/workspace.rs:242:10 [INFO] [stdout] | [INFO] [stdout] 242 | #[derive(Fail, Debug)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_Error` [INFO] [stdout] 243 | pub enum Error { [INFO] [stdout] | ----- `Error` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 25.61s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: workspace v0.4.2 (/opt/rustwide/workdir) [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "7464d23ad15cea73941bc571aaf2b24511ebf04e86e47924759a8ea901b28bb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7464d23ad15cea73941bc571aaf2b24511ebf04e86e47924759a8ea901b28bb3", kill_on_drop: false }` [INFO] [stdout] 7464d23ad15cea73941bc571aaf2b24511ebf04e86e47924759a8ea901b28bb3