[INFO] fetching crate wal-rs 1.0.2... [INFO] checking wal-rs-1.0.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate wal-rs 1.0.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate wal-rs 1.0.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wal-rs 1.0.2 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate wal-rs 1.0.2 [INFO] tweaked toml for crates.io crate wal-rs 1.0.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding cloudabi v0.0.3 (available: v0.1.0) [INFO] [stderr] Adding crc v1.8.1 (available: v3.2.1) [INFO] [stderr] Adding hex v0.3.2 (available: v0.4.3) [INFO] [stderr] Adding rand v0.5.6 (available: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1417bd30a27e0c182951778781d2b1bd38a640cf62635b6c5a5f708bcb88c67e [INFO] running `Command { std: "docker" "start" "-a" "1417bd30a27e0c182951778781d2b1bd38a640cf62635b6c5a5f708bcb88c67e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1417bd30a27e0c182951778781d2b1bd38a640cf62635b6c5a5f708bcb88c67e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1417bd30a27e0c182951778781d2b1bd38a640cf62635b6c5a5f708bcb88c67e", kill_on_drop: false }` [INFO] [stdout] 1417bd30a27e0c182951778781d2b1bd38a640cf62635b6c5a5f708bcb88c67e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 58770bebd53cde3ff4db4d134ed0a37de8d36f341f5d98cadc201223e09024af [INFO] running `Command { std: "docker" "start" "-a" "58770bebd53cde3ff4db4d134ed0a37de8d36f341f5d98cadc201223e09024af", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling build_const v0.2.2 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking wal-rs v1.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/wal/mod.rs:94:52 [INFO] [stdout] | [INFO] [stdout] 94 | fn try_allocate(&mut self, n: usize) -> Result<(usize)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - fn try_allocate(&mut self, n: usize) -> Result<(usize)> { [INFO] [stdout] 94 + fn try_allocate(&mut self, n: usize) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/wal/mod.rs:94:52 [INFO] [stdout] | [INFO] [stdout] 94 | fn try_allocate(&mut self, n: usize) -> Result<(usize)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - fn try_allocate(&mut self, n: usize) -> Result<(usize)> { [INFO] [stdout] 94 + fn try_allocate(&mut self, n: usize) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/tests.rs:76:11 [INFO] [stdout] | [INFO] [stdout] 61 | let testhome = Home::new("testdir"); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | [INFO] [stdout] 63 | let mut seq = Segment::open(&testhome.dir(), 1, 128, true).unwrap(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | match seq.write(&buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `WAL` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wal/tests.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 18 | let testhome = Home::new("testdir"); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let mut wal = WAL::open(&testhome.dir(), cfg.clone()).unwrap(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `HashSet` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wal/tests.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 110 | let testhome = Home::new("testdir"); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let mut wal = WAL::open(&dir, cfg.clone()).unwrap(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let mut set = HashSet::new(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wal-rs` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "58770bebd53cde3ff4db4d134ed0a37de8d36f341f5d98cadc201223e09024af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58770bebd53cde3ff4db4d134ed0a37de8d36f341f5d98cadc201223e09024af", kill_on_drop: false }` [INFO] [stdout] 58770bebd53cde3ff4db4d134ed0a37de8d36f341f5d98cadc201223e09024af