[INFO] fetching crate vpncloud 2.3.0... [INFO] checking vpncloud-2.3.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate vpncloud 2.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate vpncloud 2.3.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/.cargo/config [INFO] started tweaking crates.io crate vpncloud 2.3.0 [INFO] finished tweaking crates.io crate vpncloud 2.3.0 [INFO] tweaked toml for crates.io crate vpncloud 2.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate vpncloud 2.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `chrono` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] decb73156a10175934e514dd59a9db45738c9b9e82ba5b4cad414279d30ab87e [INFO] running `Command { std: "docker" "start" "-a" "decb73156a10175934e514dd59a9db45738c9b9e82ba5b4cad414279d30ab87e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "decb73156a10175934e514dd59a9db45738c9b9e82ba5b4cad414279d30ab87e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "decb73156a10175934e514dd59a9db45738c9b9e82ba5b4cad414279d30ab87e", kill_on_drop: false }` [INFO] [stdout] decb73156a10175934e514dd59a9db45738c9b9e82ba5b4cad414279d30ab87e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8e25a826208f024fb49f0daa41e167853c13961428150d3591ab96075e003f6a [INFO] running `Command { std: "docker" "start" "-a" "8e25a826208f024fb49f0daa41e167853c13961428150d3591ab96075e003f6a", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `chrono` dependency) [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling proc-macro2 v1.0.34 [INFO] [stderr] Compiling syn v1.0.83 [INFO] [stderr] Compiling serde_derive v1.0.132 [INFO] [stderr] Compiling serde v1.0.132 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling semver v1.0.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling typenum v1.14.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Compiling serde_json v1.0.73 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.5 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking xml-rs v0.8.4 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking http v0.2.5 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking wildmatch v1.1.0 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking zeroize v1.4.3 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking boxfnonce v0.1.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking xmltree v0.10.3 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Compiling vpncloud v2.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking iai v0.1.1 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking daemonize v0.4.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rayon-core v1.9.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking sha-1 v0.9.8 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking console v0.15.0 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking rayon v1.5.1 [INFO] [stderr] Checking criterion-plot v0.4.4 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking dialoguer v0.9.0 [INFO] [stderr] Checking attohttpc v0.16.3 [INFO] [stderr] Checking igd v0.12.0 [INFO] [stderr] warning: vpncloud@2.3.0: Error building manpage: No such file or directory (os error 2) [INFO] [stderr] warning: vpncloud@2.3.0: The manpage will not be build. Do you have 'asciidoctor'? [INFO] [stderr] Checking privdrop v0.5.1 [INFO] [stderr] Checking signal v0.7.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking structopt v0.3.25 [INFO] [stderr] Checking tungstenite v0.16.0 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking serde_yaml v0.8.23 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/util.rs:372:26 [INFO] [stdout] | [INFO] [stdout] 372 | '0'..='9' => ((c as usize) % ('0' as usize)), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 372 - '0'..='9' => ((c as usize) % ('0' as usize)), [INFO] [stdout] 372 + '0'..='9' => (c as usize) % ('0' as usize), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `bitrig` [INFO] [stdout] --> src/device.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | target_os = "bitrig", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_os` are: `aix`, `android`, `cuda`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `macos`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `redox`, `rtems`, `solaris`, `solid_asp3`, `teeos`, `trusty`, `tvos`, `uefi`, `unknown`, `visionos`, `vita`, and `vxworks` and 5 more [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `bitrig` [INFO] [stdout] --> src/device.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 194 | target_os = "bitrig", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_os` are: `aix`, `android`, `cuda`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `macos`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `redox`, `rtems`, `solaris`, `solid_asp3`, `teeos`, `trusty`, `tvos`, `uefi`, `unknown`, `visionos`, `vita`, and `vxworks` and 5 more [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `bench` [INFO] [stdout] --> src/net.rs:170:7 [INFO] [stdout] | [INFO] [stdout] 170 | #[cfg(feature = "bench")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `dialoguer`, `igd`, `installer`, `nat`, `tungstenite`, `url`, `websocket`, and `wizard` [INFO] [stdout] = help: consider adding `bench` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking criterion v0.3.5 [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:419:11 [INFO] [stdout] | [INFO] [stdout] 418 | pub fn run_cmd(mut cmd: Command) { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 419 | match cmd.status() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, std::fs::File>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:109:17 [INFO] [stdout] | [INFO] [stdout] 109 | let mut file = file.lock().expect("Lock poisoned"); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/util.rs:192:17 [INFO] [stdout] | [INFO] [stdout] 192 | Err(err) => fail!($format, err) [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:119:11 [INFO] [stdout] | [INFO] [stdout] 116 | let mut cmd = process::Command::new("sh"); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | match cmd.status() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] The following warnings were emitted during compilation: [INFO] [stderr] [INFO] [stderr] warning: vpncloud@2.3.0: Error building manpage: No such file or directory (os error 2) [INFO] [stderr] warning: vpncloud@2.3.0: The manpage will not be build. Do you have 'asciidoctor'? [INFO] [stderr] [INFO] [stderr] error: could not compile `vpncloud` (bin "vpncloud") due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8e25a826208f024fb49f0daa41e167853c13961428150d3591ab96075e003f6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e25a826208f024fb49f0daa41e167853c13961428150d3591ab96075e003f6a", kill_on_drop: false }` [INFO] [stdout] 8e25a826208f024fb49f0daa41e167853c13961428150d3591ab96075e003f6a