[INFO] fetching crate volo 0.10.3... [INFO] checking volo-0.10.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate volo 0.10.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate volo 0.10.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate volo 0.10.3 [INFO] finished tweaking crates.io crate volo 0.10.3 [INFO] tweaked toml for crates.io crate volo 0.10.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 131 packages to latest compatible versions [INFO] [stderr] Adding core-foundation v0.9.4 (available: v0.10.0) [INFO] [stderr] Adding foreign-types v0.3.2 (available: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding rustls v0.22.4 (available: v0.23.13) [INFO] [stderr] Adding security-framework v2.11.1 (available: v3.0.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding tokio-rustls v0.25.0 (available: v0.26.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0347a0a30a408cc40464d1b073babb81b29f5444818d08d004b84ae93fc628d8 [INFO] running `Command { std: "docker" "start" "-a" "0347a0a30a408cc40464d1b073babb81b29f5444818d08d004b84ae93fc628d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0347a0a30a408cc40464d1b073babb81b29f5444818d08d004b84ae93fc628d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0347a0a30a408cc40464d1b073babb81b29f5444818d08d004b84ae93fc628d8", kill_on_drop: false }` [INFO] [stdout] 0347a0a30a408cc40464d1b073babb81b29f5444818d08d004b84ae93fc628d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c2e7c111abe7b8b5d56469159aa1491c50f0af32d16cb47de91485922dd1fc4d [INFO] running `Command { std: "docker" "start" "-a" "c2e7c111abe7b8b5d56469159aa1491c50f0af32d16cb47de91485922dd1fc4d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking parking v2.2.1 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking tower v0.5.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking mur3 v0.1.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking async-broadcast v0.7.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking faststr v0.2.23 [INFO] [stderr] Compiling motore-macros v0.4.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking metainfo v0.7.12 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking motore v0.4.1 [INFO] [stderr] Checking volo v0.10.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `dashmap::Entry<'_, ::Key, Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loadbalance/consistent_hash.rs:289:41 [INFO] [stdout] | [INFO] [stdout] 288 | fn rebalance(&self, changes: Change<::Key>) { [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | if let Entry::Occupied(entry) = self.router.entry(changes.key.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `dashmap::Entry<'_, ::Key, Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loadbalance/random.rs:148:41 [INFO] [stdout] | [INFO] [stdout] 147 | fn rebalance(&self, changes: Change) { [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | if let Entry::Occupied(entry) = self.router.entry(changes.key.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/probe.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 28 | let s = Socket::new(Domain::IPV6, Type::STREAM, Some(Protocol::TCP)); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let s = match s { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | s.bind(&addr.into()).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `volo` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `dashmap::Entry<'_, ::Key, Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loadbalance/consistent_hash.rs:289:41 [INFO] [stdout] | [INFO] [stdout] 288 | fn rebalance(&self, changes: Change<::Key>) { [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | if let Entry::Occupied(entry) = self.router.entry(changes.key.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `dashmap::Entry<'_, ::Key, Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loadbalance/random.rs:148:41 [INFO] [stdout] | [INFO] [stdout] 147 | fn rebalance(&self, changes: Change) { [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | if let Entry::Occupied(entry) = self.router.entry(changes.key.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/probe.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 28 | let s = Socket::new(Domain::IPV6, Type::STREAM, Some(Protocol::TCP)); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let s = match s { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | s.bind(&addr.into()).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `volo` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "c2e7c111abe7b8b5d56469159aa1491c50f0af32d16cb47de91485922dd1fc4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2e7c111abe7b8b5d56469159aa1491c50f0af32d16cb47de91485922dd1fc4d", kill_on_drop: false }` [INFO] [stdout] c2e7c111abe7b8b5d56469159aa1491c50f0af32d16cb47de91485922dd1fc4d