[INFO] fetching crate validify 1.4.0... [INFO] checking validify-1.4.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate validify 1.4.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate validify 1.4.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate validify 1.4.0 [INFO] finished tweaking crates.io crate validify 1.4.0 [INFO] tweaked toml for crates.io crate validify 1.4.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 87 packages to latest compatible versions [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding itertools v0.12.1 (available: v0.13.0) [INFO] [stderr] Adding quick-xml v0.31.0 (available: v0.36.2) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e0e926a8828751922a0714bdad752f1d210083f60ed3ab2f92d92be538284c71 [INFO] running `Command { std: "docker" "start" "-a" "e0e926a8828751922a0714bdad752f1d210083f60ed3ab2f92d92be538284c71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e0e926a8828751922a0714bdad752f1d210083f60ed3ab2f92d92be538284c71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0e926a8828751922a0714bdad752f1d210083f60ed3ab2f92d92be538284c71", kill_on_drop: false }` [INFO] [stdout] e0e926a8828751922a0714bdad752f1d210083f60ed3ab2f92d92be538284c71 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f75f2bf9b2ec7e6d0f79b63deb283e54bdf4705987b1c90c15c600a77eb3d39 [INFO] running `Command { std: "docker" "start" "-a" "2f75f2bf9b2ec7e6d0f79b63deb283e54bdf4705987b1c90c15c600a77eb3d39", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Compiling iana-time-zone v0.1.61 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling bincode v1.3.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking oncemutex v0.1.1 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking quick-xml v0.31.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking card-validate v2.4.0 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Checking regex-cache v0.2.1 [INFO] [stderr] Checking unic-ucd-common v0.9.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling validify_derive v1.4.0 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Compiling phonenumber v0.3.6+8.13.36 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking validify v1.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 223 | pub fn merge(&mut self, errors: ValidationErrors) { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | self.0.append( [INFO] [stdout] 225 | &mut errors [INFO] [stdout] | __________________^ [INFO] [stdout] 226 | | .0 [INFO] [stdout] 227 | | .into_iter() [INFO] [stdout] 228 | | .filter(|err| !self.0.contains(err)) [INFO] [stdout] 229 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `validify` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 223 | pub fn merge(&mut self, errors: ValidationErrors) { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | self.0.append( [INFO] [stdout] 225 | &mut errors [INFO] [stdout] | __________________^ [INFO] [stdout] 226 | | .0 [INFO] [stdout] 227 | | .into_iter() [INFO] [stdout] 228 | | .filter(|err| !self.0.contains(err)) [INFO] [stdout] 229 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `validify` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "2f75f2bf9b2ec7e6d0f79b63deb283e54bdf4705987b1c90c15c600a77eb3d39", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f75f2bf9b2ec7e6d0f79b63deb283e54bdf4705987b1c90c15c600a77eb3d39", kill_on_drop: false }` [INFO] [stdout] 2f75f2bf9b2ec7e6d0f79b63deb283e54bdf4705987b1c90c15c600a77eb3d39