[INFO] fetching crate uflow 0.7.1... [INFO] checking uflow-0.7.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate uflow 0.7.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate uflow 0.7.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate uflow 0.7.1 [INFO] finished tweaking crates.io crate uflow 0.7.1 [INFO] tweaked toml for crates.io crate uflow 0.7.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate uflow 0.7.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] da6a51ce16e324fdaaf40d5f8e25f3da3f3f2debb13f4533625a5cd511a6ec99 [INFO] running `Command { std: "docker" "start" "-a" "da6a51ce16e324fdaaf40d5f8e25f3da3f3f2debb13f4533625a5cd511a6ec99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "da6a51ce16e324fdaaf40d5f8e25f3da3f3f2debb13f4533625a5cd511a6ec99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "da6a51ce16e324fdaaf40d5f8e25f3da3f3f2debb13f4533625a5cd511a6ec99", kill_on_drop: false }` [INFO] [stdout] da6a51ce16e324fdaaf40d5f8e25f3da3f3f2debb13f4533625a5cd511a6ec99 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 00a55758161e682bf35d5e757891cff58c4b1fdd0a4573b8014b9dcb12406107 [INFO] running `Command { std: "docker" "start" "-a" "00a55758161e682bf35d5e757891cff58c4b1fdd0a4573b8014b9dcb12406107", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.102 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking uflow v0.7.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/half_connection/loss_rate.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `assembly_window::WindowEntry` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/half_connection/packet_receiver/assembly_window/mod.rs:164:25 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn try_add(&mut self, idx: usize, datagram: frame::Datagram) -> Option { [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | let prev_entry = std::mem::replace(&mut self.window[idx], new_entry); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/half_connection/frame_queue.rs:333:55 [INFO] [stdout] | [INFO] [stdout] 333 | for fragment_ref in fragment_refs.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: `#[warn(boxed_slice_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 333 | for fragment_ref in fragment_refs.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 333 - for fragment_ref in fragment_refs.into_iter() { [INFO] [stdout] 333 + for fragment_ref in fragment_refs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `uflow` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `assembly_window::WindowEntry` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/half_connection/packet_receiver/assembly_window/mod.rs:164:25 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn try_add(&mut self, idx: usize, datagram: frame::Datagram) -> Option { [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | let prev_entry = std::mem::replace(&mut self.window[idx], new_entry); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/half_connection/packet_receiver/assembly_window/mod.rs:243:17 [INFO] [stdout] | [INFO] [stdout] 236 | let mut window = AssemblyWindow::new(10000); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | [INFO] [stdout] 238 | let packet_data = (0..MAX_FRAGMENT_SIZE*5).map(|i| i as u8).collect::>().into_boxed_slice(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let result = window.try_add(0, Datagram { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box<[u8]>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/half_connection/packet_receiver/mod.rs:825:28 [INFO] [stdout] | [INFO] [stdout] 810 | let mut rx = PacketReceiver::new(MAX_PACKET_WINDOW_SIZE, 0, 100000); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 811 | let mut sink = TestPacketSink::new(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 825 | assert_eq!(sink.pop(), new_packet_data(rx_id)); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `frame::Frame` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/half_connection/mod.rs:591:15 [INFO] [stdout] | [INFO] [stdout] 588 | fn test_data_frame(frame_bytes: &Box<[u8]>, sequence_id: u32, datagrams: Vec) { [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 591 | match frame::Frame::read(frame_bytes).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/half_connection/mod.rs:923:17 [INFO] [stdout] | [INFO] [stdout] 909 | let mut ta = TestApparatus::new(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 910 | [INFO] [stdout] 911 | let p0 = (0 .. 400).map(|i| i as u8).collect::>().into_boxed_slice(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 914 | let frames = ta.emit_frames(0, rtt_ms, MAX_FRAME_SIZE as isize); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 917 | let frames = ta.emit_frames(1, rtt_ms, MAX_FRAME_SIZE as isize); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 923 | let frames = ta.emit_frames(now_ms - 1, rtt_ms, MAX_FRAME_SIZE as isize); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frame/serial/mod.rs:756:24 [INFO] [stdout] | [INFO] [stdout] 752 | let bytes = f.write(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 756 | assert_eq!(Frame::read(&bytes_trunc), None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/half_connection/frame_queue.rs:333:55 [INFO] [stdout] | [INFO] [stdout] 333 | for fragment_ref in fragment_refs.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: `#[warn(boxed_slice_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 333 | for fragment_ref in fragment_refs.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 333 - for fragment_ref in fragment_refs.into_iter() { [INFO] [stdout] 333 + for fragment_ref in fragment_refs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `uflow` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "00a55758161e682bf35d5e757891cff58c4b1fdd0a4573b8014b9dcb12406107", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00a55758161e682bf35d5e757891cff58c4b1fdd0a4573b8014b9dcb12406107", kill_on_drop: false }` [INFO] [stdout] 00a55758161e682bf35d5e757891cff58c4b1fdd0a4573b8014b9dcb12406107