[INFO] fetching crate txn_lock 0.10.0... [INFO] checking txn_lock-0.10.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate txn_lock 0.10.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate txn_lock 0.10.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate txn_lock 0.10.0 [INFO] finished tweaking crates.io crate txn_lock 0.10.0 [INFO] tweaked toml for crates.io crate txn_lock 0.10.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 64 packages to latest compatible versions [INFO] [stderr] Adding attribute-derive v0.6.1 (available: v0.10.1) [INFO] [stderr] Adding attribute-derive-macro v0.6.1 (available: v0.10.1) [INFO] [stderr] Adding ds-ext v0.2.0 (available: v0.3.0) [INFO] [stderr] Adding proc-macro-utils v0.8.0 (available: v0.10.0) [INFO] [stderr] Adding quote-use v0.7.2 (available: v0.8.4) [INFO] [stderr] Adding quote-use-macros v0.7.2 (available: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 624a203fa4f4c9d3c5a7a4a7986cc6815f57198e0bfe66dcc6016e89a3092c5f [INFO] running `Command { std: "docker" "start" "-a" "624a203fa4f4c9d3c5a7a4a7986cc6815f57198e0bfe66dcc6016e89a3092c5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "624a203fa4f4c9d3c5a7a4a7986cc6815f57198e0bfe66dcc6016e89a3092c5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "624a203fa4f4c9d3c5a7a4a7986cc6815f57198e0bfe66dcc6016e89a3092c5f", kill_on_drop: false }` [INFO] [stdout] 624a203fa4f4c9d3c5a7a4a7986cc6815f57198e0bfe66dcc6016e89a3092c5f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2d90c17269dfb2b2d0d2b838783013dd717854ddfb399c24a6f145e7a474449e [INFO] running `Command { std: "docker" "start" "-a" "2d90c17269dfb2b2d0d2b838783013dd717854ddfb399c24a6f145e7a474449e", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling derive-where v1.2.7 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling quote-use-macros v0.7.2 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Compiling quote-use v0.7.2 [INFO] [stderr] Compiling attribute-derive-macro v0.6.1 [INFO] [stderr] Compiling attribute-derive v0.6.1 [INFO] [stderr] Compiling get-size-derive v0.1.3 [INFO] [stderr] Checking ds-ext v0.2.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking txn_lock v0.10.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/semaphore/version.rs:309:78 [INFO] [stdout] | [INFO] [stdout] 309 | pub fn read<'a>(&'a self, target: &'a R, collator: &'a C) -> BoxTryFuture> { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/semaphore/version.rs:412:79 [INFO] [stdout] | [INFO] [stdout] 412 | pub fn write<'a>(&'a self, target: &'a R, collator: &'a C) -> BoxTryFuture> { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/semaphore/version.rs:309:78 [INFO] [stdout] | [INFO] [stdout] 309 | pub fn read<'a>(&'a self, target: &'a R, collator: &'a C) -> BoxTryFuture> { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/semaphore/version.rs:412:79 [INFO] [stdout] | [INFO] [stdout] 412 | pub fn write<'a>(&'a self, target: &'a R, collator: &'a C) -> BoxTryFuture> { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:1156:30 [INFO] [stdout] | [INFO] [stdout] 1147 | let mut state = self.state_mut(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1154 | let permit = self.semaphore.try_write(txn_id, key.clone().into())?; [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1155 | [INFO] [stdout] 1156 | if let Some(value) = state.get_mut(txn_id, key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:1156:30 [INFO] [stdout] | [INFO] [stdout] 1147 | let mut state = self.state_mut(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1154 | let permit = self.semaphore.try_write(txn_id, key.clone().into())?; [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1155 | [INFO] [stdout] 1156 | if let Some(value) = state.get_mut(txn_id, key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::btree_map::Entry<'_, I, Version>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/semaphore/mod.rs:302:15 [INFO] [stdout] | [INFO] [stdout] 267 | let mut versions = self.versions.lock().expect("versions"); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 302 | match versions.entry(txn_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::btree_map::Entry<'_, I, Version>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/semaphore/mod.rs:302:15 [INFO] [stdout] | [INFO] [stdout] 267 | let mut versions = self.versions.lock().expect("versions"); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 302 | match versions.entry(txn_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `txn_lock` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `txn_lock` (lib) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2d90c17269dfb2b2d0d2b838783013dd717854ddfb399c24a6f145e7a474449e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2d90c17269dfb2b2d0d2b838783013dd717854ddfb399c24a6f145e7a474449e", kill_on_drop: false }` [INFO] [stdout] 2d90c17269dfb2b2d0d2b838783013dd717854ddfb399c24a6f145e7a474449e