[INFO] fetching crate trie-db-test 0.26.0... [INFO] checking trie-db-test-0.26.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate trie-db-test 0.26.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate trie-db-test 0.26.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate trie-db-test 0.26.0 [INFO] finished tweaking crates.io crate trie-db-test 0.26.0 [INFO] tweaked toml for crates.io crate trie-db-test 0.26.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 121 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (available: v0.8.11) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.18) [INFO] [stderr] Adding criterion v0.3.6 (available: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (available: v0.5.0) [INFO] [stderr] Adding env_logger v0.9.3 (available: v0.11.5) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding hash-db v0.15.2 (available: v0.16.0) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding hex-literal v0.3.4 (available: v0.4.1) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding keccak-hasher v0.15.3 (available: v0.16.0) [INFO] [stderr] Adding memory-db v0.30.0 (available: v0.32.0) [INFO] [stderr] Adding radium v0.7.0 (available: v1.1.0) [INFO] [stderr] Adding reference-trie v0.26.0 (available: v0.29.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (available: v0.13.1) [INFO] [stderr] Adding textwrap v0.11.0 (available: v0.16.1) [INFO] [stderr] Adding trie-db v0.24.0 (available: v0.29.1) [INFO] [stderr] Adding trie-root v0.17.0 (available: v0.18.0) [INFO] [stderr] Adding trie-standardmap v0.15.2 (available: v0.16.0) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wyz v0.5.1 (available: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 25d033aeba0353f9780bdefd585f1f46b089844f1bb8bb7c0e09731d6c94cdae [INFO] running `Command { std: "docker" "start" "-a" "25d033aeba0353f9780bdefd585f1f46b089844f1bb8bb7c0e09731d6c94cdae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "25d033aeba0353f9780bdefd585f1f46b089844f1bb8bb7c0e09731d6c94cdae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "25d033aeba0353f9780bdefd585f1f46b089844f1bb8bb7c0e09731d6c94cdae", kill_on_drop: false }` [INFO] [stdout] 25d033aeba0353f9780bdefd585f1f46b089844f1bb8bb7c0e09731d6c94cdae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c2e795a7329e6b522ac229b4cb27566df1b8077d0f0935ca8aca5bd3cf797e95 [INFO] running `Command { std: "docker" "start" "-a" "c2e795a7329e6b522ac229b4cb27566df1b8077d0f0935ca8aca5bd3cf797e95", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking hash-db v0.15.2 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling winnow v0.6.20 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking hash256-std-hasher v0.15.2 [INFO] [stderr] Compiling parity-util-mem v0.12.0 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking rustc-hex v2.1.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking byte-slice-cast v1.2.2 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking trie-root v0.17.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling hex-literal v0.3.4 [INFO] [stderr] Checking keccak-hasher v0.15.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking trie-standardmap v0.15.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking trie-db v0.24.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Compiling toml_edit v0.22.22 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling impl-trait-for-tuples v0.2.2 [INFO] [stderr] Compiling parity-util-mem-derive v0.1.0 [INFO] [stderr] Compiling parity-scale-codec-derive v3.6.12 [INFO] [stderr] Checking parity-scale-codec v3.6.12 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Checking memory-db v0.30.0 [INFO] [stderr] Checking reference-trie v0.26.0 [INFO] [stderr] Checking trie-db-test v0.26.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/bench.rs:73:4 [INFO] [stdout] | [INFO] [stdout] 73 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/bench.rs:94:4 [INFO] [stdout] | [INFO] [stdout] 94 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/bench.rs:115:4 [INFO] [stdout] | [INFO] [stdout] 115 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/bench.rs:136:4 [INFO] [stdout] | [INFO] [stdout] 136 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/bench.rs:158:4 [INFO] [stdout] | [INFO] [stdout] 158 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/bench.rs:176:4 [INFO] [stdout] | [INFO] [stdout] 176 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/bench.rs:270:4 [INFO] [stdout] | [INFO] [stdout] 270 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/bench.rs:291:4 [INFO] [stdout] | [INFO] [stdout] 291 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/bench.rs:312:4 [INFO] [stdout] | [INFO] [stdout] 312 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/bench.rs:337:4 [INFO] [stdout] | [INFO] [stdout] 337 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/bench.rs:360:4 [INFO] [stdout] | [INFO] [stdout] 360 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/bench.rs:389:4 [INFO] [stdout] | [INFO] [stdout] 389 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/bench.rs:414:4 [INFO] [stdout] | [INFO] [stdout] 414 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `criterion::Criterion::::bench_function_over_inputs`: Please use BenchmarkGroups instead. [INFO] [stdout] --> benches/bench.rs:440:4 [INFO] [stdout] | [INFO] [stdout] 440 | c.bench_function_over_inputs( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option::Hash as hash_db::Hasher>::Out>, Rc>>), Box::Hash as hash_db::Hasher>::Out, <::Codec as NodeCodec>::Error>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iterator.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 64 | let mut iter = TrieDBNodeIterator::new(&trie).unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | match iter.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `trie_db::node::NodeOwned<[u8; 32]>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie_codec.rs:185:7 [INFO] [stdout] | [INFO] [stdout] 161 | let mut recorder = { [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let node_owned = node.to_owned_node::().unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Recorder` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/triedb.rs:386:7 [INFO] [stdout] | [INFO] [stdout] 353 | let mut cache = TestTrieCache::::default(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | let mut recorder = Recorder::::new(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Recorder` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/triedb.rs:477:7 [INFO] [stdout] | [INFO] [stdout] 440 | let mut cache = TestTrieCache::::default(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 477 | let mut recorder = Recorder::::new(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/triedbmut.rs:515:15 [INFO] [stdout] | [INFO] [stdout] 504 | let mut t = TrieDBMutBuilder::::new(&mut db, &mut root).build(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | assert_eq!(t.remove(&key).unwrap(), Some(Value::Inline(value.into()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trie-db-test` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "c2e795a7329e6b522ac229b4cb27566df1b8077d0f0935ca8aca5bd3cf797e95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2e795a7329e6b522ac229b4cb27566df1b8077d0f0935ca8aca5bd3cf797e95", kill_on_drop: false }` [INFO] [stdout] c2e795a7329e6b522ac229b4cb27566df1b8077d0f0935ca8aca5bd3cf797e95