[INFO] fetching crate tokenizers 0.20.0... [INFO] checking tokenizers-0.20.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate tokenizers 0.20.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate tokenizers 0.20.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tokenizers 0.20.0 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate tokenizers 0.20.0 [INFO] tweaked toml for crates.io crate tokenizers 0.20.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate tokenizers 0.20.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5608df997a65236185b12b271682f583794c67955ce469cd57058d2838a3cc6f [INFO] running `Command { std: "docker" "start" "-a" "5608df997a65236185b12b271682f583794c67955ce469cd57058d2838a3cc6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5608df997a65236185b12b271682f583794c67955ce469cd57058d2838a3cc6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5608df997a65236185b12b271682f583794c67955ce469cd57058d2838a3cc6f", kill_on_drop: false }` [INFO] [stdout] 5608df997a65236185b12b271682f583794c67955ce469cd57058d2838a3cc6f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6c1b6d4c59ca3278f2d3b50dc3d0cb7edb0b2c3a245c1a820adaea0c7eb25acc [INFO] running `Command { std: "docker" "start" "-a" "6c1b6d4c59ca3278f2d3b50dc3d0cb7edb0b2c3a245c1a820adaea0c7eb25acc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.205 [INFO] [stderr] Compiling cc v1.1.8 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling portable-atomic v1.7.0 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking clap_builder v4.5.14 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Compiling macro_rules_attribute-proc_macro v0.2.0 [INFO] [stderr] Checking unicode-normalization-alignments v0.1.12 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking unicode_categories v0.1.1 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking assert_approx_eq v1.1.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking macro_rules_attribute v0.2.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking rayon-cond v0.3.0 [INFO] [stderr] Checking clap v4.5.14 [INFO] [stderr] Compiling onig_sys v69.8.1 [INFO] [stderr] Compiling esaxx-rs v0.1.10 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling serde_derive v1.0.205 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling monostate-impl v0.1.13 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking onig v6.4.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling derive_builder_core v0.20.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling derive_builder_macro v0.20.0 [INFO] [stderr] Checking derive_builder v0.20.0 [INFO] [stderr] Checking spm_precompiled v0.1.4 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking monostate v0.1.13 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking tokenizers v0.20.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] error: this value of type `std::result::Result>, TryLockError>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/cache.rs:72:36 [INFO] [stdout] | [INFO] [stdout] 66 | pub(crate) fn get_values<'a, I, Q>(&self, keys_iter: I) -> Option>> [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | if let Ok(ref mut cache) = self.map.try_read() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>, TryLockError>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/cache.rs:109:32 [INFO] [stdout] | [INFO] [stdout] 91 | pub(crate) fn set_values(&self, entries: I) [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | if let Ok(mut cache) = self.map.try_write() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tokenizers` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::result::Result>, TryLockError>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/cache.rs:72:36 [INFO] [stdout] | [INFO] [stdout] 66 | pub(crate) fn get_values<'a, I, Q>(&self, keys_iter: I) -> Option>> [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | if let Ok(ref mut cache) = self.map.try_read() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>, TryLockError>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/cache.rs:109:32 [INFO] [stdout] | [INFO] [stdout] 91 | pub(crate) fn set_values(&self, entries: I) [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | if let Ok(mut cache) = self.map.try_write() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `serde_json::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoders/mod.rs:229:17 [INFO] [stdout] | [INFO] [stdout] 207 | let parse = serde_json::from_str::(json); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | let parse = serde_json::from_str::(json); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | let parse = serde_json::from_str::(json); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | match parse { [INFO] [stdout] 229 | Err(err) => assert_eq!(format!("{err}"), "missing field `decoders`"), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/bpe/model.rs:813:15 [INFO] [stdout] | [INFO] [stdout] 803 | let mut vocab_file = NamedTempFile::new().unwrap(); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 809 | let mut merges_file = NamedTempFile::new().unwrap(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 813 | match BPE::from_file( [INFO] [stdout] | _______________^ [INFO] [stdout] 814 | | vocab_file.path().to_str().unwrap(), [INFO] [stdout] 815 | | merges_file.path().to_str().unwrap(), [INFO] [stdout] 816 | | ) [INFO] [stdout] 817 | | .build() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/bpe/model.rs:844:15 [INFO] [stdout] | [INFO] [stdout] 834 | let mut vocab_file = NamedTempFile::new().unwrap(); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 840 | let mut merges_file = NamedTempFile::new().unwrap(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 844 | match BPE::from_file( [INFO] [stdout] | _______________^ [INFO] [stdout] 845 | | vocab_file.path().to_str().unwrap(), [INFO] [stdout] 846 | | merges_file.path().to_str().unwrap(), [INFO] [stdout] 847 | | ) [INFO] [stdout] 848 | | .build() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `serde_json::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/mod.rs:336:17 [INFO] [stdout] | [INFO] [stdout] 333 | let reconstructed: std::result::Result = [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | Err(err) => assert_eq!(err.to_string(), "Merges text file invalid at line 1"), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `serde_json::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/normalizers/mod.rs:277:17 [INFO] [stdout] | [INFO] [stdout] 255 | let parse = serde_json::from_str::(json); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | let parse = serde_json::from_str::(json); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | let parse = serde_json::from_str::(json); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | match parse { [INFO] [stdout] 277 | Err(err) => assert_eq!(format!("{err}"), "missing field `normalizers`"), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `serde_json::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pre_tokenizers/mod.rs:312:17 [INFO] [stdout] | [INFO] [stdout] 287 | let reconstructed = serde_json::from_str::(json); [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | let reconstructed = serde_json::from_str::(json).unwrap(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | let reconstructed = serde_json::from_str::(json); [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | let reconstructed = serde_json::from_str::(json); [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 311 | match reconstructed { [INFO] [stdout] 312 | Err(err) => assert_eq!( [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `serde_json::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/processors/mod.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 94 | let reconstructed = serde_json::from_str::(json); [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let reconstructed = serde_json::from_str::(json); [INFO] [stdout] | ------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | match reconstructed { [INFO] [stdout] 121 | Err(err) => assert_eq!( [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tokenizers` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "6c1b6d4c59ca3278f2d3b50dc3d0cb7edb0b2c3a245c1a820adaea0c7eb25acc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c1b6d4c59ca3278f2d3b50dc3d0cb7edb0b2c3a245c1a820adaea0c7eb25acc", kill_on_drop: false }` [INFO] [stdout] 6c1b6d4c59ca3278f2d3b50dc3d0cb7edb0b2c3a245c1a820adaea0c7eb25acc